From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 222E61B168 for ; Tue, 9 Jan 2018 11:46:36 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2018 02:46:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,335,1511856000"; d="scan'208";a="17811989" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.48]) ([10.237.220.48]) by FMSMGA003.fm.intel.com with ESMTP; 09 Jan 2018 02:46:35 -0800 To: Hemant Agrawal , dev@dpdk.org Cc: Ashish Jain References: <1513166759-13466-1-git-send-email-hemant.agrawal@nxp.com> <1513166759-13466-6-git-send-email-hemant.agrawal@nxp.com> From: Ferruh Yigit Message-ID: Date: Tue, 9 Jan 2018 10:46:34 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <1513166759-13466-6-git-send-email-hemant.agrawal@nxp.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 05/18] net/dpaa: set the correct frame size in device MTU X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jan 2018 10:46:37 -0000 On 12/13/2017 12:05 PM, Hemant Agrawal wrote: > From: Ashish Jain > > Setting correct frame size in dpaa_dev_mtu_set > api call. Also setting correct max frame size in > hardware in dev_configure for jumbo frames > > Signed-off-by: Ashish Jain > Acked-by: Hemant Agrawal <...> > @@ -111,19 +111,21 @@ static int > dpaa_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) > { > struct dpaa_if *dpaa_intf = dev->data->dev_private; > + uint32_t frame_size = mtu + ETHER_HDR_LEN + ETHER_CRC_LEN > + + VLAN_TAG_SIZE; > > PMD_INIT_FUNC_TRACE(); > > - if (mtu < ETHER_MIN_MTU) > + if ((mtu < ETHER_MIN_MTU) || (frame_size > DPAA_MAX_RX_PKT_LEN)) checkpatch complains about extra parentheses: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'mtu < ETHER_MIN_MTU' #42: FILE: drivers/net/dpaa/dpaa_ethdev.c:119: + if ((mtu < ETHER_MIN_MTU) || (frame_size > DPAA_MAX_RX_PKT_LEN)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'frame_size > DPAA_MAX_RX_PKT_LEN' #42: FILE: drivers/net/dpaa/dpaa_ethdev.c:119: + if ((mtu < ETHER_MIN_MTU) || (frame_size > DPAA_MAX_RX_PKT_LEN)) <...>