From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 52E2CA04C4;
	Wed, 13 Nov 2019 21:26:52 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id EC5502B87;
	Wed, 13 Nov 2019 21:26:50 +0100 (CET)
Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com
 [209.85.210.194]) by dpdk.org (Postfix) with ESMTP id 27670235
 for <dev@dpdk.org>; Wed, 13 Nov 2019 21:26:49 +0100 (CET)
Received: by mail-pf1-f194.google.com with SMTP id z4so2388958pfn.12
 for <dev@dpdk.org>; Wed, 13 Nov 2019 12:26:49 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=subject:to:cc:references:from:message-id:date:user-agent
 :mime-version:in-reply-to:content-language:content-transfer-encoding;
 bh=b0dRelZfby1noPbQ+hocnKCJaktbWnjZSPS4NjrkQDc=;
 b=jPfBlqL6d3BxMf5H41ucrUrFwuBa3x2ecyoLf95OEFaotQX36QDY6EyQ0iqelRW9W6
 QrnxiHHbM6lk+YTK9hFr+AkAMVIx0A03HOFutTYf0Vi8YgB15zRisP7j6Px2DzpIfJnS
 xZgbfSfMMLNf+8ma9YhzCB8AGHXd2t+IEXkoDid1gSfyZ+A8uLdtiQmnCn7UxIrXGE68
 mG37D/zYDy8z4jlM0RW3dHidAF/s0UGJKzvI12C61hRWtDq0f51mQFds97hAQyYOsO4U
 I8KesbU6R7W/dsotMhDJBUIruinwuHRYyjR7hzsfuLNSbKn1XW+vmJOdHy9HM2ZCxZIe
 KJJg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:subject:to:cc:references:from:message-id:date
 :user-agent:mime-version:in-reply-to:content-language
 :content-transfer-encoding;
 bh=b0dRelZfby1noPbQ+hocnKCJaktbWnjZSPS4NjrkQDc=;
 b=Jmmt1JKwM1CZWo5o1ktIaKcI21mcPoYZTJKt4OeO4F28eIxnvGfcclJPyZSGbMhfV3
 oOiMSe2jBKiiFV+IWULHG2WBhczMY8CGC7dYDZYZFkXyt8OC+P4pOA0PbUKmHGfThb3v
 pBuJkqUOnPOfZRLtc54YNToiOj1u7OZBdU8673UCpTtq7ihYHUF2/dBXjuoB6Yr4h3Oy
 KYKp+3DLGaxWqrYxlOCKFAdCt7zQz0Jyf2ZedERYmhMPWiHwiYrvf2NZpmluCKqC31eC
 CsVUqlAQ6XYmOBVI1OQlBHfnGADCGdh3zfMzQNmWoknHo0vc4squtCbAWGSo7KqzaB9s
 vLrg==
X-Gm-Message-State: APjAAAWUdDpnMGimJ0wNc33kkqS3pC4mYfhITGXcc2Tntdiraq/aXFM2
 oEVvUCsayAgFonW7RIqmKgw=
X-Google-Smtp-Source: APXvYqxy2PuwQ7GBR/DwxYkzBtgNP31LUUBKDHqzLy3RzWSIKOYi8pN5puR3aoy+ZSz+4kwP1fJ6eA==
X-Received: by 2002:a63:d806:: with SMTP id b6mr5822845pgh.122.1573676808243; 
 Wed, 13 Nov 2019 12:26:48 -0800 (PST)
Received: from mugwort.local ([192.47.164.146])
 by smtp.gmail.com with ESMTPSA id 12sm4780644pjm.11.2019.11.13.12.26.46
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 13 Nov 2019 12:26:47 -0800 (PST)
To: Ray Kinsella <mdr@ashroe.eu>, Abdul Halim <abdul.halim@intel.com>,
 dev@dpdk.org
Cc: ray.kinsella@intel.com
References: <1566924290-451677-1-git-send-email-abdul.halim@intel.com>
 <1570183701-407946-1-git-send-email-abdul.halim@intel.com>
 <19a98c7f-b4ac-014e-d03f-e9bbf6c1a9f1@ashroe.eu>
From: Yasufumi Ogawa <yasufum.o@gmail.com>
Message-ID: <a3b5f175-2079-0141-b7dc-d275d85f21ec@gmail.com>
Date: Wed, 13 Nov 2019 12:26:43 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0)
 Gecko/20100101 Thunderbird/60.9.1
MIME-Version: 1.0
In-Reply-To: <19a98c7f-b4ac-014e-d03f-e9bbf6c1a9f1@ashroe.eu>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2] build: add dockerfile for building docker
 image
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 2019/10/15 1:39, Ray Kinsella wrote:
> 
> 
> On 04/10/2019 11:08, Abdul Halim wrote:
>> Adding a Dockerfile with Ubuntu bionic base image to build dpdk as shared
>> library. This docker image could be used as base image to build and run
>> dpdk applications in containers.
Hi Abdul,

I have tested your Dockerfile and confirmed that shared lib is generated 
under /usr/local as described in the Dockerfile.

Just a comment, I wonder if you add an example of usecase in 
documentation for helping users understanding how to use.

Regards,
Yasufumi

>>
>> Signed-off-by: Abdul Halim <abdul.halim@intel.com>
>>
>> ---
>>
>> v2:
>>    * renamed Dockerfile name from Dockerfile.ubuntu to Dockerfile.bionic
>>    * added call to ldconfig to update cache of libraries to include newly
>>      installed DPDK libs
>> ---
>>   extras/Dockerfile.bionic | 40 ++++++++++++++++++++++++++++++++++++++++
>>   extras/README.md         |  8 ++++++++
>>   2 files changed, 48 insertions(+)
>>   create mode 100644 extras/Dockerfile.bionic
>>   create mode 100644 extras/README.md
>>
>> diff --git a/extras/Dockerfile.bionic b/extras/Dockerfile.bionic
>> new file mode 100644
>> index 0000000..f83b720
>> --- /dev/null
>> +++ b/extras/Dockerfile.bionic
>> @@ -0,0 +1,40 @@
>> +# SPDX-License-Identifier: BSD-3-Clause
>> +# Copyright(c) 2019 Intel Corporation
>> +FROM ubuntu:bionic
>> +
>> +# install requirements for getting and building DPDK
>> +# including dependencies for DPDK features
>> +RUN apt-get update && apt-get install -y \
>> +    build-essential \
>> +    pkg-config \
>> +    python3 \
>> +    python3-pip \
>> +    ninja-build \
>> +    libjansson-dev \
>> +    libbsd-dev \
>> +    libnuma-dev \
>> +    libssl-dev \
>> +    zlib1g-dev \
>> +    libpcap-dev \
>> +    libibverbs-dev \
>> +        && pip3 install meson \
>> +        && apt-get clean && rm -rf /var/lib/apt/lists/*
>> +
>> +ADD . /tmp/dpdk
>> +
>> +WORKDIR /tmp/dpdk
>> +
>> +RUN meson build \
>> +    -Ddefault_library=shared \
>> +    -Dmachine=default \
>> +    -Dper_library_versions=false \
>> +        && ninja -C build install \
>> +        && ldconfig \
>> +        && cd /; rm -rf /tmp/dpdk
>> +
>> +WORKDIR /
>> +
>> +# Installed DPDK Shared library location:
>> +# lib dir : /usr/local/lib/
>> +# include : /usr/local/include/
>> +# pkgconfig file: /usr/local/lib/x86_64-linux-gnu/pkgconfig/libdpdk.pc
>> diff --git a/extras/README.md b/extras/README.md
>> new file mode 100644
>> index 0000000..f1aa898
>> --- /dev/null
>> +++ b/extras/README.md
>> @@ -0,0 +1,8 @@
>> +# Build DPDK Docker image
>> +
>> +To build a docker image run the following command from dpdk root directory.
>> +
>> +```
>> +DOCKER_TAG="dpdk"
>> +docker build -t ${DOCKER_TAG} -f extras/Dockerfile.bionic .
>> +```
>>
> Acked-by: Ray Kinsella <mdr@ashroe.eu>
> 
Tested-by: Yasufumi Ogawa <yasufum.o@gmail.com>