From: Andrew Rybchenko <arybchenko@solarflare.com>
To: Michael Pfeiffer <michael.pfeiffer@tu-ilmenau.de>,
Olivier Matz <olivier.matz@6wind.com>
Cc: <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net: calculate checksums for packets with IPv4 options
Date: Mon, 7 Sep 2020 10:48:10 +0300 [thread overview]
Message-ID: <a3c39164-a679-bb51-37f9-706ad5cc2fef@solarflare.com> (raw)
In-Reply-To: <20200901094755.561661-1-michael.pfeiffer@tu-ilmenau.de>
On 9/1/20 12:47 PM, Michael Pfeiffer wrote:
> Currently, rte_ipv4_cksum() and rte_ipv4_udptcp_cksum() assume all IPv4
> headers have sizeof(struct rte_ipv4_hdr) bytes. This is not true for
> those (rare) packets with IPv4 options. Thus, both IPv4 and TCP/UDP
> checksums are calculated wrong.
>
> This patch fixes the issue by using the actual IPv4 header length from
> the packet's IHL field.
>
> Signed-off-by: Michael Pfeiffer <michael.pfeiffer@tu-ilmenau.de>
Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>
next prev parent reply other threads:[~2020-09-07 7:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 11:32 [dpdk-dev] [PATCH] " Michael Pfeiffer
2020-08-29 11:43 ` Andrew Rybchenko
2020-09-01 9:47 ` [dpdk-dev] [PATCH v2] " Michael Pfeiffer
2020-09-07 7:48 ` Andrew Rybchenko [this message]
2020-10-05 22:55 ` Thomas Monjalon
2020-10-06 2:39 ` Stephen Hemminger
2020-10-06 8:10 ` Olivier Matz
2020-10-06 9:51 ` Michael Pfeiffer
2020-10-06 15:10 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3c39164-a679-bb51-37f9-706ad5cc2fef@solarflare.com \
--to=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=michael.pfeiffer@tu-ilmenau.de \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).