From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1FD3FA0032; Tue, 12 Jul 2022 12:09:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0599641109; Tue, 12 Jul 2022 12:09:56 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id D6025410EF for ; Tue, 12 Jul 2022 12:09:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657620594; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Gv3tXTzva39LpY8NUgQetCwgXou+dPYwunrQk0ZAmXI=; b=A9vvlFgnAbPu5y8LDRAw6jhPvBlPGRYAa52h7KqPgArvx0y3usyjPeqGlfsoaf76lbwuMK vQJChEYvuEXw8yv7M2W/SB1eLJkLWzMFubx/2T7ikMPp1WtMzuXx9T4p4r1FQVEHOAZBXC UAhFyn4rEWFgBJSfev/8EuGQNeJqhko= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-259-AB-eTw6GOaCD7qPVjyxcjg-1; Tue, 12 Jul 2022 06:09:49 -0400 X-MC-Unique: AB-eTw6GOaCD7qPVjyxcjg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 015EB85A587; Tue, 12 Jul 2022 10:09:49 +0000 (UTC) Received: from [10.39.208.27] (unknown [10.39.208.27]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1D3221415117; Tue, 12 Jul 2022 10:09:47 +0000 (UTC) Message-ID: Date: Tue, 12 Jul 2022 12:09:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] vhost: fix missing copy length in batched copies To: dev@dpdk.org, chenbo.xia@intel.com, yux.jiang@intel.com, thomas@monjalon.net, david.marchand@redhat.com References: <20220712100447.104162-1-maxime.coquelin@redhat.com> From: Maxime Coquelin In-Reply-To: <20220712100447.104162-1-maxime.coquelin@redhat.com> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 7/12/22 12:04, Maxime Coquelin wrote: > This patch fixes missing the assignement of the copy length s/assignement/assignment/ If this is the only change requested, could it be fixed while applying, or should I send a v2? Thanks, Maxime > when doing batched copies in the sync dequeue path. > > Fixes: cd79d1b030bd ("vhost: fix unnecessary dirty page logging") > > Suggested-by: Chenbo Xia > Signed-off-by: Maxime Coquelin > --- > lib/vhost/virtio_net.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c > index 12b7fbe7f9..35fa4670fd 100644 > --- a/lib/vhost/virtio_net.c > +++ b/lib/vhost/virtio_net.c > @@ -1127,13 +1127,13 @@ sync_fill_seg(struct virtio_net *dev, struct vhost_virtqueue *vq, > batch_copy[vq->batch_copy_nb_elems].src = > rte_pktmbuf_mtod_offset(m, void *, mbuf_offset); > batch_copy[vq->batch_copy_nb_elems].log_addr = buf_iova; > - batch_copy[vq->batch_copy_nb_elems].len = cpy_len; > } else { > batch_copy[vq->batch_copy_nb_elems].dst = > rte_pktmbuf_mtod_offset(m, void *, mbuf_offset); > batch_copy[vq->batch_copy_nb_elems].src = > (void *)((uintptr_t)(buf_addr)); > } > + batch_copy[vq->batch_copy_nb_elems].len = cpy_len; > vq->batch_copy_nb_elems++; > } > }