From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8F95DA0093; Mon, 18 May 2020 11:48:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 486661D170; Mon, 18 May 2020 11:48:04 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 7354B1D16B for ; Mon, 18 May 2020 11:48:01 +0200 (CEST) IronPort-SDR: fQphJcbz0O69t4wq7Sx2jkAEqLJAqNeMIQMAhj1rJ6jQZX3EuAW168J93qhgaGrHoPdKg3MVuk uT6gTkaZZCyQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2020 02:48:00 -0700 IronPort-SDR: i8p+NJocVLD3VokHg/opwfWby38Nz2OOSJzka6cROvQMHI7cwZPeeiQKXJ/7xSdvp7S7X/DkOo KbIMKJw8fPVQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,406,1583222400"; d="scan'208";a="252840121" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.213.193.210]) ([10.213.193.210]) by orsmga007.jf.intel.com with ESMTP; 18 May 2020 02:47:58 -0700 To: Dharmik Thakkar Cc: Wenzhuo Lu , Jingjing Wu , Bernard Iremonger , John McNamara , Marko Kovacevic , "dev@dpdk.org" , nd References: <20200506215847.7628-1-dharmik.thakkar@arm.com> <20200508223829.3228-1-dharmik.thakkar@arm.com> <20200508223829.3228-3-dharmik.thakkar@arm.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJsBBMBCgBWAhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEABQkKqZZ8FiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl6ha3sXGHZrczovL2tl eXMub3BlbnBncC5vcmcACgkQ+TPrQ98TYR8uLA//QwltuFliUWe60xwmu9sY38c1DXvX67wk UryQ1WijVdIoj4H8cf/s2KtyIBjc89R254KMEfJDao/LrXqJ69KyGKXFhFPlF3VmFLsN4XiT PSfxkx8s6kHVaB3O183p4xAqnnl/ql8nJ5ph9HuwdL8CyO5/7dC/MjZ/mc4NGq5O9zk3YRGO lvdZAp5HW9VKW4iynvy7rl3tKyEqaAE62MbGyfJDH3C/nV/4+mPc8Av5rRH2hV+DBQourwuC ci6noiDP6GCNQqTh1FHYvXaN4GPMHD9DX6LtT8Fc5mL/V9i9kEVikPohlI0WJqhE+vQHFzR2 1q5nznE+pweYsBi3LXIMYpmha9oJh03dJOdKAEhkfBr6n8BWkWQMMiwfdzg20JX0o7a/iF8H 4dshBs+dXdIKzPfJhMjHxLDFNPNH8zRQkB02JceY9ESEah3wAbzTwz+e/9qQ5OyDTQjKkVOo cxC2U7CqeNt0JZi0tmuzIWrfxjAUulVhBmnceqyMOzGpSCQIkvalb6+eXsC9V1DZ4zsHZ2Mx Hi+7pCksdraXUhKdg5bOVCt8XFmx1MX4AoV3GWy6mZ4eMMvJN2hjXcrreQgG25BdCdcxKgqp e9cMbCtF+RZax8U6LkAWueJJ1QXrav1Jk5SnG8/5xANQoBQKGz+yFiWcgEs9Tpxth15o2v59 gXK5Ag0EV9ZMvgEQAKc0Db17xNqtSwEvmfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ES YpV8QWj0xK4YM0dLxnDU2IYxjEshSB1TqAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4Ai bPtrHuIXWQOBECcVZTTOdZYGAzaYzxiAONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxD UQljeNvKYt1lZE/gAUUxNLWsYyTT+22/vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/ 3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35piVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVj sM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQI3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdc q9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYHfVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH7 1PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZqw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFB VOQOxCvwRG2QCgcJ/UTn5vlivul+cThi6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI 8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJlRr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYC GwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNhHwUCXqFrngUJCKxSYAAKCRD5M+tD3xNhH3YWD/9b cUiWaHJasX+OpiuZ1Li5GG3m9aw4lR/k2lET0UPRer2Jy1JsL+uqzdkxGvPqzFTBXgx/6Byz EMa2mt6R9BCyR286s3lxVS5Bgr5JGB3EkpPcoJT3A7QOYMV95jBiiJTy78Qdzi5LrIu4tW6H o0MWUjpjdbR01cnj6EagKrDx9kAsqQTfvz4ff5JIFyKSKEHQMaz1YGHyCWhsTwqONhs0G7V2 0taQS1bGiaWND0dIBJ/u0pU998XZhmMzn765H+/MqXsyDXwoHv1rcaX/kcZIcN3sLUVcbdxA WHXOktGTQemQfEpCNuf2jeeJlp8sHmAQmV3dLS1R49h0q7hH4qOPEIvXjQebJGs5W7s2vxbA 5u5nLujmMkkfg1XHsds0u7Zdp2n200VC4GQf8vsUp6CSMgjedHeF9zKv1W4lYXpHp576ZV7T GgsEsvveAE1xvHnpV9d7ZehPuZfYlP4qgo2iutA1c0AXZLn5LPcDBgZ+KQZTzm05RU1gkx7n gL9CdTzVrYFy7Y5R+TrE9HFUnsaXaGsJwOB/emByGPQEKrupz8CZFi9pkqPuAPwjN6Wonokv ChAewHXPUadcJmCTj78Oeg9uXR6yjpxyFjx3vdijQIYgi5TEGpeTQBymLANOYxYWYOjXk+ae dYuOYKR9nbPv+2zK9pwwQ2NXbUBystaGyQ== Message-ID: Date: Mon, 18 May 2020 10:47:57 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 3/5] doc: add cycles per packet in testpmd user guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/15/2020 9:33 PM, Dharmik Thakkar wrote: > Hi Ferruh, > >> On May 15, 2020, at 7:15 AM, Ferruh Yigit wrote: >> >> On 5/8/2020 11:38 PM, Dharmik Thakkar wrote: >>> Update documentation for 'show fwd' testpmd runtime function to show >>> CPU cycles/packet example. >>> >>> Signed-off-by: Dharmik Thakkar >>> Reviewed-by: Honnappa Nagarahalli >>> Reviewed-by: Phil Yang >>> --- >>> v2: >>> - Use shorter lines, up to 100. >>> --- >>> doc/guides/testpmd_app_ug/testpmd_funcs.rst | 53 +++++++++++++-------- >>> 1 file changed, 33 insertions(+), 20 deletions(-) >>> >>> diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst >>> index a360ecccfd3f..441ed41e3803 100644 >>> --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst >>> +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst >>> @@ -351,26 +351,39 @@ Example for the io forwarding engine, with some packet drops on the tx side:: >>> >>> testpmd> show fwd stats all >>> >>> - ------- Forward Stats for RX Port= 0/Queue= 0 -> TX Port= 1/Queue= 0 ------- >>> - RX-packets: 274293770 TX-packets: 274293642 TX-dropped: 128 >>> - >>> - ------- Forward Stats for RX Port= 1/Queue= 0 -> TX Port= 0/Queue= 0 ------- >>> - RX-packets: 274301850 TX-packets: 274301850 TX-dropped: 0 >>> - >>> - ---------------------- Forward statistics for port 0 ---------------------- >>> - RX-packets: 274293802 RX-dropped: 0 RX-total: 274293802 >>> - TX-packets: 274301862 TX-dropped: 0 TX-total: 274301862 >>> - ---------------------------------------------------------------------------- >>> - >>> - ---------------------- Forward statistics for port 1 ---------------------- >>> - RX-packets: 274301894 RX-dropped: 0 RX-total: 274301894 >>> - TX-packets: 274293706 TX-dropped: 128 TX-total: 274293834 >>> - ---------------------------------------------------------------------------- >>> - >>> - +++++++++++++++ Accumulated forward statistics for all ports+++++++++++++++ >>> - RX-packets: 548595696 RX-dropped: 0 RX-total: 548595696 >>> - TX-packets: 548595568 TX-dropped: 128 TX-total: 548595696 >>> - ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ >>> + ------- Forward Stats for RX Port= 0/Queue= 0 -> TX Port= 1/Queue= 0 ------- >>> + RX-packets: 43536504 TX-packets: 43536488 TX-dropped: 0 >>> + >>> + ------- Forward Stats for RX Port= 1/Queue= 0 -> TX Port= 0/Queue= 0 ------- >>> + RX-packets: 149738504 TX-packets: 149738504 TX-dropped: 0 >>> + >>> + ------- Forward Stats for RX Port= 1/Queue= 1 -> TX Port= 0/Queue= 1 ------- >>> + RX-packets: 149753052 TX-packets: 149753052 TX-dropped: 0 >>> + >>> + ---------------------- Forward statistics for port 0 ---------------------- >>> + RX-packets: 43538881 RX-dropped: 72 RX-total: 43538953 >>> + TX-packets: 299491753 TX-dropped: 0 TX-total: 299491753 >>> + ---------------------------------------------------------------------------- >>> + >>> + ---------------------- Forward statistics for port 1 ---------------------- >>> + RX-packets: 299493085 RX-dropped: 8357 RX-total: 299501442 >>> + TX-packets: 43539683 TX-dropped: 0 TX-total: 43539683 >>> + ---------------------------------------------------------------------------- >>> + >>> + +++++++++++++++ Accumulated forward statistics for all ports+++++++++++++++ >>> + RX-packets: 343031966 RX-dropped: 8429 RX-total: 343040395 >>> + TX-packets: 343031436 TX-dropped: 0 TX-total: 343031436 >>> + ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ >>> + >>> + CPU cycles/packet=14.28 (total cycles=4899533541 / total RX packets=343031966) at 200 MHz Clock >> >> Hi Dharmik, >> >> Overall it is OK to show "CPU cycles/packet", but my concern is numbers can be >> misleading, because for example the numbers I am getting is like below: >> >> CPU cycles/packet=4.38 (total cycles=32871036274 / total RX packets=7511734336) >> at 2100 MHz Clock > > CPU cycles/packet shown above is a part of the example. The numbers are as per the statistics shown in the example. I know but now you are showing a performance number and it is specific to a platform, my concern it may be misleading and create false expectations for others. > >> >>> + >>> +.. note:: >>> + >>> + Measuring CPU cycles/packet requires enabling CONFIG_RTE_TEST_PMD_RECORD_CORE_TX_CYCLES >> >> s/TX_CYCLES/CYCLES > > Sorry, didn’t understand this comment. There is no 'CONFIG_RTE_TEST_PMD_RECORD_CORE_TX_CYCLES' config option. > >> >>> + configuration option. On aarch64 platforms, by default, the cycles are counted using >>> + generic counter which runs at a lower frequency than the CPU clock. To get the cycles/packet >>> + at CPU clock frequency, please scale the cycles/packet to CPU clock frequency. >>> + Alternatively, use the PMU based cycle counter. >> >> Not sure the "aarch64 platforms" note suits to here, where documents the >> command. And I can see the platform documentation already updated for this. > > This additional comment about aarch64 platforms is to provide complete information to the users with regards to the config option > and offer a better understanding of the CPU cycles/packet numbers. IMO, without this note, CPU cycles/packet numbers can be misleading. This is testpmd documentation to describe "show fwd stats" command. We are adding a note to say with a config option it may also show performance data, which is OK. But starting to describe the platform differences for this config option looks to much details for the scope of the document. For testpmd I would prefer command usage independent from platforms, otherwise the documentation may become too confusing/complex. But agree to provide the information for the specific platform, which you are already doing in other patch in the platform documentation. > >> >> Combining above two comments, what do you think instead of replacing existing >> stats, add a note saying enabling 'CONFIG_RTE_TEST_PMD_RECORD_CORE_CYCLES' >> appends "CPU cycles/packet" and give above two samples, like: >> >> " >> Enabling RTE_TEST_PMD_RECORD_CORE_CYCLES appends "CPU cycles/packet" stats, like: >> >> CPU cycles/packet=4.38 (total cycles=32871036274 / total RX packets=7511734336) >> at 2100 MHz Clock >> OR >> CPU cycles/packet=14.28 (total cycles=4899533541 / total RX packets=343031966) >> at 200 MHz Clock >> " > > Yes, this is also an option. IMO, numbers shown within CPU cycles/packet example should be consistent with the forward statistics numbers. > This part is just the sample of the "CPU cycles/packet" output, I think it provides enough context to be understandable without matching Rx packet count in above part of the stats.