DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: David Marchand <david.marchand@redhat.com>,
	dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v5] mailmap: add file to DPDK
Date: Thu, 24 Nov 2022 17:34:33 +0000	[thread overview]
Message-ID: <a405343e-c03e-9678-2438-78e6f10973a4@amd.com> (raw)
In-Reply-To: <2605498.Isy0gbHreE@thomas>

On 11/24/2022 5:26 PM, Thomas Monjalon wrote:
> 24/11/2022 18:21, Ferruh Yigit:
>> On 11/24/2022 3:44 PM, David Marchand wrote:
>>> From: Bruce Richardson <bruce.richardson@intel.com>
>>>
>>> Since a number of contributors to DPDK have submitted patches to DPDK
>>> under more than one email address, we should maintain a mailmap file to
>>> properly track their commits using "shortlog".
>>>
>>> It also helps fix up any mangled names, for example, with
>>> surname/firstname reversed, or with incorrect capitalization.
>>> By keeping this file in the DPDK repository, rather than committers
>>> maintaining their own copies, it allows individual contributors to edit
>>> it to update their own email address preferences if so desired.
>>>
>>> While at it, update our checkpatches.sh script and add some
>>> documentation to help new contributors.
>>>
>>> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>>> Signed-off-by: David Marchand <david.marchand@redhat.com>
>>
>> <...>
>>
>>> @@ -148,6 +148,9 @@ Make your planned changes in the cloned ``dpdk`` repo. Here are some guidelines
>>>  
>>>  * Follow the :ref:`coding_style` guidelines.
>>>  
>>> +* If you are a new contributor, or if your mail address changed, please update the ``.mailmap`` file.
>>
>> There is no benefit for new contributors to update .mailmap file, but it
>> adds another thing to update.
>>
>> I think it is simpler to keep .mailmap only for users that has multiple
>> email address in the git repo, and ask only from contributors in this
>> catagory to update the .mailmap instead of all contributors.
> 
> We are doing checks on name and email. Typos are very common.
> So we are maintaining such a file privately.
> We would like to make it public so people can change it if needed.
> 
> If it looks a problem for newcomers, we can reword the doc to say
> if they are missing in the file and not added themselves,
> it will be added with their first patch by maintainers.
> Is it better?
> 

ACK, this is an internal file for project maintenance, so I think better
to batch update it per release etc.. (This approach also may give easy
list of new contributors for that release.)

  reply	other threads:[~2022-11-24 17:34 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-20 13:07 [dpdk-dev] [PATCH] mailmap: add a mailmap " Bruce Richardson
2020-10-20 13:22 ` David Marchand
2020-10-20 14:29 ` Thomas Monjalon
2020-10-20 15:03   ` Bruce Richardson
2020-10-20 15:17     ` Thomas Monjalon
2020-10-20 15:32       ` Bruce Richardson
2020-10-20 15:38         ` Thomas Monjalon
2020-10-20 15:44           ` Bruce Richardson
2020-10-21 16:55 ` [dpdk-dev] [PATCH v2] " Bruce Richardson
2022-11-04 12:13 ` [PATCH v3] mailmap: add " Bruce Richardson
2022-11-04 12:16   ` Bruce Richardson
2022-11-24 12:13 ` [PATCH v4] " David Marchand
2022-11-24 13:43   ` Bruce Richardson
2022-11-24 13:49     ` David Marchand
2022-11-24 13:57       ` Thomas Monjalon
2022-11-24 15:08         ` Bruce Richardson
2022-11-24 17:21           ` Thomas Monjalon
2022-11-24 16:51     ` Stephen Hemminger
2022-11-24 17:19       ` Thomas Monjalon
2022-11-28 17:18         ` Tyler Retzlaff
2022-11-24 15:44 ` [PATCH v5] " David Marchand
2022-11-24 17:21   ` Ferruh Yigit
2022-11-24 17:26     ` Thomas Monjalon
2022-11-24 17:34       ` Ferruh Yigit [this message]
2022-11-24 19:42         ` Thomas Monjalon
2022-11-25 14:54 ` [PATCH v6] " David Marchand
2022-11-25 16:08   ` Dumitrescu, Cristian
2022-11-27 10:27     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a405343e-c03e-9678-2438-78e6f10973a4@amd.com \
    --to=ferruh.yigit@amd.com \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).