From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id BFF689E4; Mon, 18 Jun 2018 12:00:59 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jun 2018 03:00:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,238,1526367600"; d="scan'208";a="65025161" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.252.30.40]) ([10.252.30.40]) by fmsmga001.fm.intel.com with ESMTP; 18 Jun 2018 03:00:56 -0700 To: Dariusz Stojaczyk , dev@dpdk.org Cc: thomas.monjalon@6wind.com, stable@dpdk.org References: <1528461427-164113-1-git-send-email-dariuszx.stojaczyk@intel.com> From: "Burakov, Anatoly" Message-ID: Date: Mon, 18 Jun 2018 11:00:55 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <1528461427-164113-1-git-send-email-dariuszx.stojaczyk@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/2] eal/thread: fix return codes for rte_thread_setname() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jun 2018 10:01:00 -0000 On 08-Jun-18 1:37 PM, Dariusz Stojaczyk wrote: > The doc says this function returns negative errno > on error, but it currently returns either -1 or > positive errno. > > It was incorrectly assumed that pthread_setname_np() > returns negative error numbers. It always returns > positive ones, so this patch negates its return value > before returning. > > While here, also ignore rte_thread_setname() failure > in rte_ctrl_thread_create() and print a debug message > instead. > > Fixes: 3901ed99c2f8 ("eal: fix thread naming on FreeBSD") > Cc: thomas.monjalon@6wind.com > Cc: stable@dpdk.org > > Signed-off-by: Dariusz Stojaczyk > --- For patch contents, Acked-by: Anatoly Burakov However, maybe this should be split in two patches. -- Thanks, Anatoly