DPDK patches and discussions
 help / color / mirror / Atom feed
From: Radu Nicolau <radu.nicolau@intel.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>, dev@dpdk.org
Cc: thomas@monjalon.net, ferruh.yigit@intel.com, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] test: fix hang on FreeBSD
Date: Mon, 21 May 2018 14:33:16 +0100	[thread overview]
Message-ID: <a4173f10-e7ad-6754-09b7-f93b55c52e9e@intel.com> (raw)
In-Reply-To: <d175bfc8-d0e0-4cd5-c944-ce38488e5678@intel.com>



On 5/21/2018 2:28 PM, Burakov, Anatoly wrote:
> On 21-May-18 12:35 PM, Radu Nicolau wrote:
>> Fixes: af75078fece3 ("first public release")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
>> ---
>>   test/test/test_debug.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/test/test/test_debug.c b/test/test/test_debug.c
>> index faf2cf5..56fadce 100644
>> --- a/test/test/test_debug.c
>> +++ b/test/test/test_debug.c
>> @@ -34,7 +34,8 @@ test_panic(void)
>>           printf("Fork Failed\n");
>>           return -1;
>>       }
>> -    wait(&status);
>> +    sleep(1);
>> +    waitpid(pid, &status, WNOHANG);
>>       if(status == 0){
>>           printf("Child process terminated normally!\n");
>>           return -1;
>>
>
> I'd be curious to see which specific problem you are addressing as 
> well. FreeBSD hanging on abort is a known issue, and a workaround is 
> already available:
>
> http://dpdk.org/dev/patchwork/patch/40256/
>
> FreeBSD doesn't really "hang" here, it just spends a 
> looooooooooooooong time doing the core dump because FreeBSD, unlike 
> Linux, doesn't ignore hugepage and zero-page anonymous memory for core 
> dumps, resulting in it trying to dump the entire 128 gigabytes of VA 
> space that we preallocate.
>
> Setting resource limits will address the immediate issue, a more 
> complete fix (some memory subsystem refactor) will be coming for 18.08.
>

So it seems my "fix" only hides the issue and doesn't actually fix 
anything - so I will remove it from patchwork

      reply	other threads:[~2018-05-21 13:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-21 11:35 Radu Nicolau
2018-05-21 12:30 ` Thomas Monjalon
2018-05-21 12:58   ` Radu Nicolau
2018-05-21 13:16     ` Thomas Monjalon
2018-05-21 16:13     ` Stephen Hemminger
2018-05-21 13:28 ` Burakov, Anatoly
2018-05-21 13:33   ` Radu Nicolau [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a4173f10-e7ad-6754-09b7-f93b55c52e9e@intel.com \
    --to=radu.nicolau@intel.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).