From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 47D6643A37; Tue, 6 Feb 2024 19:25:29 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3AB1740271; Tue, 6 Feb 2024 19:25:27 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2065.outbound.protection.outlook.com [40.107.243.65]) by mails.dpdk.org (Postfix) with ESMTP id 8AB534025E for ; Tue, 6 Feb 2024 19:25:26 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JOlPM+tf/UhkQTAH7j3hhP58CMQ5Fb2VTUfdvVYwEjmqsQjSHhYuSokQj3AxneazCwN4vb/qYPBOoiUM2z5/aLZ1RRbXfwMELIA0TOkUu1P7Ny4NmwtiUSCW6Q6Q6VAS8oywhY3lyUmkhCazdrFw9aA7iymUMEsAKLrtH4bBI0igzpg/ioQf0JkAAmuszbwqGALd3SibwyJwyVWZOJTakGwFcTBd4/V+VSfAEPee/uUJgWUnSm7gqWF12MYfG5+ke1bbUW/DnjmdM+Vh+OPM3TVS76083ZMMBhT9qvCcqqNPQvSJxMfSn3PG7NH3c81xOP/tu2D4BdXQB3kKCOZSvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GbYwY/xhBxPzj1xQ3Oqq9YPDc49gIwQh8IsFdmV2syM=; b=MYW2rKlxiZO8UEE/+rhYrpysh6IsnZSEJOCd3iKl+pPPBC1S2ETHQwsVBnYrDnOvq8BZHaPKvewYHi+sdgNmXCe1U8DSMTWzf+DDAFNRWqJulisk1Qrj4eL2iCZZVrQkXrcvYUTsuWhNleZIVlSxB3oTZVB4UXCtB/eZY3iVaNqO7/WbeXW1VwqxLmlvoVPJbw6cvygb61LYy3SfKA/GjtXjmD8c9pKgBo3zQPNKnSIWvhvFyLIoVvmv/ZSU6uN4wM7LdiZxknfy6cEDwDEy7NB3avAfi68XpzAFHieSm69zLYQH20pqEomD6v8WsR9akUzF+7s6sq0IzZWXm945SQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GbYwY/xhBxPzj1xQ3Oqq9YPDc49gIwQh8IsFdmV2syM=; b=BP2vH5sqlcVgJZ8HzXaZGxalyciehLxKxvcc28x1TMKBwV2SKTy/VqXYzwRfaKcMvZ2JGzMcal96ySEMksSofD35bnGom0BX2s1AeoQMSqA9HKePpDNfayK6a98wB/CAPDAhhLXm4LKj8bnp/1m51b2e21nkXkk9oAY3jspXJkM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SN7PR12MB6766.namprd12.prod.outlook.com (2603:10b6:806:26a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.15; Tue, 6 Feb 2024 18:25:24 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f%4]) with mapi id 15.20.7270.016; Tue, 6 Feb 2024 18:25:24 +0000 Message-ID: Date: Tue, 6 Feb 2024 18:25:20 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] examples/ipsec-secgw: fix IPsec performance drop Content-Language: en-US To: Rahul Bhansali , dev@dpdk.org, Radu Nicolau , Akhil Goyal , Konstantin Ananyev , Anoob Joseph References: <20240206123811.3452587-1-rbhansali@marvell.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240206123811.3452587-1-rbhansali@marvell.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P123CA0047.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600::35) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SN7PR12MB6766:EE_ X-MS-Office365-Filtering-Correlation-Id: af07d73a-9adb-4ace-bcf2-08dc2740fbf5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4jocKdXcF048NPWY52PPP+ealckNA/Q6AstISMy/P98x7sQ1bYHJlqyMpD6yIB58+JcyqBst8JWz9HuvohJNpGmDq4UBFA5/DauAi+555i4QIuGz/s5RR2HUzvmUwUTcuCMvUJKHoqgToCQ2y9Bsk4Z4d+S3qHQj2eH2IdMIEfmnQCtXyjEnQTgTdPw4oSYH4c3Y1vvme8njtaLAsByBv7FLSELtsugbzfiryrJN3ZNWRQg1NcN0JJW35CchufGhRByzxpzYw3Psg68Shfrtt3swqpQVBWZ75rDA4F6CC+14IC52eIKHV0eNeF71OuMY7m5cYjthg0DykFFKf5+voHpzeu0vecvoOaxxz2wT7t8sgZmXGgojl9c9FthPYNlPaJqqlIF0DBbjq3oaMWT42TCOFgM5LVSLgQ5tUzMdcy2cCfhqXGGXpJ93LkLvkEq604hNkWMYOI/alXyxgyL8zbJMeJwDTg5WsKYhCmhcBi6Rd3PYUpxNivppfRfqPSu1ZwxKRPV4hgKkrOIMKxHw8AiRULT4R/wIgjbYRfTLmTgPHnfAq8EyflmZswG7zr4xsEl9EDQEdb2W/0DIG0rslka14GBFivS67DBRmCblHKHHO9AD5ylJZFJIy8p5NLOl4Ek6VmMdoI/iOS+IR2jGYA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(396003)(136003)(346002)(39860400002)(366004)(230922051799003)(1800799012)(64100799003)(451199024)(186009)(31686004)(36756003)(6512007)(478600001)(53546011)(6486002)(6506007)(83380400001)(41300700001)(31696002)(26005)(2616005)(2906002)(5660300002)(66556008)(110136005)(44832011)(86362001)(66476007)(8936002)(6666004)(38100700002)(8676002)(66946007)(316002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WG9uSWhHQUhyWFc3dTNQTUVmcHMyeHhoNDZIKzNGVldQdkwyeDFpejBiRXFl?= =?utf-8?B?VWhUeW1hUk04WFdydzExMXFOakRGeWRic01MaDdzdDF2dzd5am1sdHFONUd5?= =?utf-8?B?UldNdytKVUpISnJCR0NZblBUdDdIQW9GbUVFV0J2blA5MFFkYVlxWmJEUmxJ?= =?utf-8?B?TEY0bnJIQUxQblN5Ui9Od09VWkt2eGVONndpVS8zSkFwWUlaMzRheTdNOXZ6?= =?utf-8?B?cnIvVE1IZlFsb2pVV1JZQWQzTURQTGZHS3pvZmZqS1ZDNitUQ09YUVdzZlBn?= =?utf-8?B?VUFJcDRrZ0xxc2grMDJjQm5vTEl0ODlNMVQ1Tis1dVVESVlEa1RSVnMwdkVi?= =?utf-8?B?OFBaODAvem9jM1pwd2xreURxdnVnckpNZE4wU2hDcnVxbXNvMExhSzZrZkUr?= =?utf-8?B?NmgxUHMrNTVnWU5LblFmTDVWaWdZZUdBNTJEbXU0bXE1QmVLeDdpMVNnQ0Vn?= =?utf-8?B?NjU0Qjl4RFVWN0NEd2lINEdRWEJMY0RWVzBpRzZoL0lEcDFUdjhsOUVUQVY0?= =?utf-8?B?OVA5d1FjS0hTN05qZE5QNm5STkEzdm1kdi80RVhMM0RwamJiUG1TZ1hjVzZ5?= =?utf-8?B?Nk1FcU1OdlV2MXNCYnNGdVZBZnZmUDl2VUpYMEpKQmpHWmUyUGhTNE1QNS93?= =?utf-8?B?anIrUjhjMFdaVEk0T3A2WmNRT2JwRDRVaWFpUEZMeDZ5WUh6cmw0TS9TSnhL?= =?utf-8?B?TnlHbGszNDNZOStsaXhnNFNMSTEzbGgwTVdQaS96U1RmRFVFd3V5VisvVWxm?= =?utf-8?B?TW5KdHkyc0FVZGJ1anNiYW9ZNlhObGZCSjFnTmo1V1QrcHFTUVhZWUo1OS9N?= =?utf-8?B?a0F4TVZLbGp0cFI4MU5DcW1YL0NRNFZIMG16TDVZbC9nSVBvTDdtUFAvTlNC?= =?utf-8?B?NmIrSU9sdmtVUGJRd2E2S3pCcnVNRjd1aFhtakl2T2xqTC9WM3pDNU9SV01w?= =?utf-8?B?bEJBRi9UeStnZ3gwR3llQ1ZCWFN2T2R3YzlBcHZ2UlJsVEowb2gvaEFmVjhy?= =?utf-8?B?WExRVm5JNkxQNzdnNjJjcWhhN3haWXJnVGs0UDlMRk43M3d6Tlo3a1MxSVFB?= =?utf-8?B?a2FZaE1Ub2pxNEZwRFhZRHRwUzR6anFucjcvQjR5T0NHOXRsdjAyRzNXdXFX?= =?utf-8?B?a0trQjh2Q3kvMTVudFEvWFAyTjhZRVo4Zm1pbzVHZ0RXVXVWN1pmY1ZNQUNv?= =?utf-8?B?NlFUSkZMSzJPMXZ6YTRqcndTMW5QSFFkcktmRmhGYUc1ME9mVTdPL1hzcGpy?= =?utf-8?B?UlovVFhJMjJZemU5Sk1DTDY1SUFzSFlWR2JKaEhmWXR3dEJZYjFvQk42RmNF?= =?utf-8?B?cjdpZy9yeW5CcXpJbmtuaHhzZFlqTGJLRkFVR3NkVitSOVF2RnJEMVVKT3Rm?= =?utf-8?B?c2JnOFFEUU8rZURZcVNnRGVpMTRzRnJxNy9DVHZwUzFoVDZuSXRwZmk4M0Jm?= =?utf-8?B?dDR1cElHczJ4WWZpVStkZ001VndOMFBMVlR2UjlKcGVXVDlCSlRLTkFmT2ZM?= =?utf-8?B?TmFaNFF3QnVrT0dUZ3N1LzZVWnR1dWxGb1JieGIzckxpREpRYkRYQmIvdHFU?= =?utf-8?B?dTFNVjhPbjhsc3pxNWg3UmJSdVU0azlHeERZMnJLZlhDVDNrRk9yVVdkU0R4?= =?utf-8?B?aVQ1SHYwY3BHRVdCWTBFdVArSDY4eE5vamFyRmp0Y3MwWlVOME4rRjV6N3FB?= =?utf-8?B?WkZDOW5iSGFSaXVYUkxjMkR0Q2ZNZklRY0NETDdESXFEZU9WWkhaRmJFcXNI?= =?utf-8?B?b2ZmUWtpeWd1SVlHaUdEdGJOSlg5MG02eGZneStpdGNDZnRxOXZYdzhsOE5K?= =?utf-8?B?T3lOd1pKeG1HWVJLTWh0TFVvTWp1QVgzTDQ4cytSeC9jS3hKZnhZaDZVOGFD?= =?utf-8?B?QzRNVlQwVUM5djBMVVBWNVU0d2lRRUFaRjlHOEJFVlQ0eUlNUG5mejlKTXMx?= =?utf-8?B?akRWMk8xNUYxVElhYnUzYlJZWm13UEU2WDNrMHE5MlVXVUR3YWtKY1lqckJP?= =?utf-8?B?OWZaVjFRNnlQVTVqQjExVE9RQVlVc1k1K2J4T0Y0VGtFdlhZVHdSRHBMSTU3?= =?utf-8?B?MmFMZXk4SFlVV3p6ZWZtcCt0M2E2SkdZcjN0eVFuY0JiamxEQlFQYXoyT1RC?= =?utf-8?Q?4SoC9+euPZKDxUpZ1ikOrWhlh?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: af07d73a-9adb-4ace-bcf2-08dc2740fbf5 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2024 18:25:24.2514 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8n+Nu6PNrCTRNLLF81kh5QPwlaVwESF7qUXP7zixMoroC9Hmu6boxoGSPFRObu5U X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6766 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/6/2024 12:38 PM, Rahul Bhansali wrote: > Single packet free using rte_pktmbuf_free_bulk() is dropping the > performance. On cn10k, maximum of ~4% drop observed for IPsec > event mode single SA outbound case. > > To fix this issue, single packet free will use rte_pktmbuf_free > API. > > Fixes: bd7c063561b3 ("examples/ipsec-secgw: use bulk free") > > Signed-off-by: Rahul Bhansali > --- > examples/ipsec-secgw/ipsec-secgw.h | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/examples/ipsec-secgw/ipsec-secgw.h b/examples/ipsec-secgw/ipsec-secgw.h > index 8baab44ee7..ec33a982df 100644 > --- a/examples/ipsec-secgw/ipsec-secgw.h > +++ b/examples/ipsec-secgw/ipsec-secgw.h > @@ -229,11 +229,10 @@ free_reassembly_fail_pkt(struct rte_mbuf *mb) > } > > /* helper routine to free bulk of packets */ > -static inline void > -free_pkts(struct rte_mbuf *mb[], uint32_t n) > +static __rte_always_inline void > +free_pkts(struct rte_mbuf *mb[], const uint32_t n) > { > - rte_pktmbuf_free_bulk(mb, n); > - > + n == 1 ? rte_pktmbuf_free(mb[0]) : rte_pktmbuf_free_bulk(mb, n); > core_stats_update_drop(n); > } > Hi Rahul, Do you think the 'rte_pktmbuf_free_bulk()' API performance can be improved by similar change?