From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AA714A0547; Thu, 29 Apr 2021 13:21:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 980854110F; Thu, 29 Apr 2021 13:21:16 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 5E34B410DD for ; Thu, 29 Apr 2021 13:21:14 +0200 (CEST) IronPort-SDR: ixEqW/n1gUF5v6Rk+XVjsOMcjxVTD+LwU5HeOoq5Yx5LIDSO6teJgQXG893D6Y8vhRNLq1CW3K UZqz3z2rDBIw== X-IronPort-AV: E=McAfee;i="6200,9189,9968"; a="258268638" X-IronPort-AV: E=Sophos;i="5.82,259,1613462400"; d="scan'208";a="258268638" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2021 04:21:13 -0700 IronPort-SDR: rYtxq34x5b8tvCICejOg1O8nZ4LGmp3OjAdZyBVVaTsyDLB7Be5WxhaXulMJ2bX064PGLOMrTv UDT4XXrUgnNA== X-IronPort-AV: E=Sophos;i="5.82,259,1613462400"; d="scan'208";a="526903041" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.208.65]) ([10.213.208.65]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2021 04:21:12 -0700 To: Jiawen Wu , dev@dpdk.org References: <20210406093048.2923172-1-jiawenwu@trustnetic.com> <4aa70553-97bd-94a0-883f-5c1ce99e7ea8@intel.com> <009f01d73ce5$bc3694f0$34a3bed0$@trustnetic.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Thu, 29 Apr 2021 12:21:11 +0100 MIME-Version: 1.0 In-Reply-To: <009f01d73ce5$bc3694f0$34a3bed0$@trustnetic.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 0/6] net: ngbe PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/29/2021 11:52 AM, Jiawen Wu wrote: > On Friday, April 9, 2021 10:47 PM, Ferruh Yigit wrote: >> On 4/6/2021 10:30 AM, Jiawen Wu wrote: >>> This patch set provides a skeleton of ngbe PMD, which adapted to >>> Wangxun WX1860 series NICs. >>> >>> v4: >>> - Fix compile error. >>> >>> v3: >>> - Use rte_ether functions to define marcos. >>> >>> v2: >>> - Correct some clerical errors. >>> - Use ethdev debug flags instead of driver own. >>> >>> Jiawen Wu (6): >>> net/ngbe: add build and doc infrastructure >>> net/ngbe: add device IDs >>> net/ngbe: support probe and remove >>> net/ngbe: add device init and uninit >>> net/ngbe: add log type and error type >>> net/ngbe: define registers >>> >> >> Hi Jiawen, >> >> I put some comments on some patches, but as far as I can see the device is not >> functional yet after this set, I assume rest of the support will be submitted >> later. >> But I think the device should have at least bare minimum functionality when it >> is upstreamed, like proper device initialization and primitive Rx/Tx, also it would >> be good to have basic control functions. >> More control and datapath functionality can be added gradually later. >> >> What do you think extending this set to have base minimum functionality? >> >> Thanks, >> ferruh > > Hi Ferruh, > > Unfortunately, this driver may not be merged in 21.05, to follow the roadmap. > There is not enough time for me to improve the patches, because I was busy with other works in these weeks. > > I'll try my best to submit the driver in this release cycle, and hope it will be merged nicely in next release. > That is OK, thanks for heads up.