From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 23C64A0A0E; Wed, 3 Feb 2021 00:11:54 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9A3862403EB; Wed, 3 Feb 2021 00:11:53 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 88D422403E9 for ; Wed, 3 Feb 2021 00:11:52 +0100 (CET) IronPort-SDR: 2459ucfs3/XiuJ9bp5FK73hdrIB6zSbW6jk5U6xFSUfqVvLskZ/7FfwISEi+l+S11O3+06ofoX c2mkYMkB0MAw== X-IronPort-AV: E=McAfee;i="6000,8403,9883"; a="181095024" X-IronPort-AV: E=Sophos;i="5.79,396,1602572400"; d="scan'208";a="181095024" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2021 15:11:51 -0800 IronPort-SDR: ci40wtBMfbnfPkKd9bmHtF0Jy5RoCxbJ10YkMkkN5QH0D+8xfUTiMUTWpG0r7CHmhZ22dUIaWh XRh4JQCNQsMQ== X-IronPort-AV: E=Sophos;i="5.79,396,1602572400"; d="scan'208";a="391920624" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.226.112]) ([10.213.226.112]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2021 15:11:49 -0800 To: "Zhou, JunX W" , Maxime Coquelin , "dev@dpdk.org" , "Wang, Yinan" , "Xia, Chenbo" , "amorenoz@redhat.com" , "david.marchand@redhat.com" , "Ling, WeiX" , "Jiang, YuX" References: <20210201093317.6761-1-maxime.coquelin@redhat.com> From: Ferruh Yigit Message-ID: Date: Tue, 2 Feb 2021 23:11:45 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] net/virtio: fix missing listen FD initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2/2/2021 9:26 AM, Zhou, JunX W wrote: > -----Original Message----- > From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com] > Sent: Monday, February 1, 2021 5:33 PM > To: dev@dpdk.org; Wang, Yinan ; Xia, Chenbo ; amorenoz@redhat.com; david.marchand@redhat.com; Ling, WeiX ; Jiang, YuX > Cc: Maxime Coquelin ; Zhou, JunX W > Subject: [PATCH] net/virtio: fix missing listen FD initialization > > When running in client mode, the listen file descriptor is not initialized, and so has value 0. At destroy time, the listen FD is closed if its value is greater than or equal to zero, which causes STDIN to be closed. > > Bugzilla ID: 630 > Fixes: 949735312f5e ("net/virtio: move vhost-user specifics to its backend") > > Reported-by: Jun W Zhou > Signed-off-by: Maxime Coquelin > > Reviewed-by: David Marchand > > Tested-by: Zhou, Jun > Applied to dpdk-next-net/main, thanks.