From: "lihuisong (C)" <lihuisong@huawei.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: <dev@dpdk.org>, <songx.jiale@intel.com>, <liuyonglong@huawei.com>
Subject: Re: [PATCH] app/testpmd: fix fail to set queue number when attach device
Date: Fri, 21 Feb 2025 09:16:26 +0800 [thread overview]
Message-ID: <a4a62bed-4280-cd3d-9c75-c46e80ac6e10@huawei.com> (raw)
In-Reply-To: <20250220125605.60807aa6@hermes.local>
在 2025/2/21 4:56, Stephen Hemminger 写道:
> On Tue, 18 Feb 2025 19:31:56 +0800
> Huisong Li <lihuisong@huawei.com> wrote:
>
>> Testpmd doesn't modify the Rx/Tx queue number of all ports after attach a
>> new device. The root cause is that "port config all rxq <value>" would
>> check if all ports are stopped and the status of this port is still in
>> 'RTE_PORT_HANDLING'. This status is changed to 'RTE_PORT_STOPPED' in
>> setup_attached_port() when start port.
>>
>> In addition, this new port needs to be initialized in advance because these
>> information are depanded on many commands. Otherwise other commands like
>> "port config xxx" may also encounter similar issue. But the initialization
>> can't be in new event callback as discussed in following commit. So this
>> patch moves setup_attached_port() to the time point 100ms after received
>> the new event.
>>
>> Bugzilla ID: 1663
>> Fixes: 994635edb2c0 ("app/testpmd: add port attach/detach for multiple process")
>>
>> Signed-off-by: Huisong Li <lihuisong@huawei.com>
>> ---
> Applied to next-net with some rewording of commit message to improve grammar.
> Should this patch be cc to stable since it has a Fixes tag?
No need to cc to stable because above Fixes is just in this 25.03 version.
> .
prev parent reply other threads:[~2025-02-21 1:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-18 11:31 Huisong Li
2025-02-20 20:56 ` Stephen Hemminger
2025-02-21 1:16 ` lihuisong (C) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4a62bed-4280-cd3d-9c75-c46e80ac6e10@huawei.com \
--to=lihuisong@huawei.com \
--cc=dev@dpdk.org \
--cc=liuyonglong@huawei.com \
--cc=songx.jiale@intel.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).