From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 09FFD41B91;
	Tue, 31 Jan 2023 18:15:11 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 937D94067B;
	Tue, 31 Jan 2023 18:15:10 +0100 (CET)
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mails.dpdk.org (Postfix) with ESMTP id ED0F640041
 for <dev@dpdk.org>; Tue, 31 Jan 2023 18:15:08 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
 s=mimecast20190719; t=1675185308;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 content-transfer-encoding:content-transfer-encoding:
 in-reply-to:in-reply-to:references:references;
 bh=Z1fHs5pvXdX8NMvvrtX2hEeK1cAFwmvqhY5YiEkb9E8=;
 b=Kd2CDgHFwMoemkOVO4WL1ysuRTKaAjfesyg6jD4xGV9Wfm6TMhaqKYvpiR/6gq2wEzWJJ8
 WRbSpAqzurvApQFSlu5ZOXQdtWg/VKjGUbeEaI0TU+dwMV84ncu5gnjAmUOGkjvDGyyyNS
 /cEmVMarfPZxAaikCfnGdIr21Sd7kys=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-85-USvawEH5M9GoWNJqJdcXAQ-1; Tue, 31 Jan 2023 12:15:07 -0500
X-MC-Unique: USvawEH5M9GoWNJqJdcXAQ-1
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com
 [10.11.54.6])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9BD08800159;
 Tue, 31 Jan 2023 17:15:02 +0000 (UTC)
Received: from [10.39.208.22] (unknown [10.39.208.22])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id 414472166B33;
 Tue, 31 Jan 2023 17:15:01 +0000 (UTC)
Message-ID: <a4b60cc7-9a0d-0a83-3fc4-3caf70011494@redhat.com>
Date: Tue, 31 Jan 2023 18:14:59 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH v4 9/9] vhost: enable lock check
To: David Marchand <david.marchand@redhat.com>, dev@dpdk.org
Cc: stephen@networkplumber.org, chenbo.xia@intel.com, jiayu.hu@intel.com,
 yuanx.wang@intel.com, xuan.ding@intel.com
References: <20220328121758.26632-1-david.marchand@redhat.com>
 <20230119184620.3195267-1-david.marchand@redhat.com>
 <20230119184620.3195267-10-david.marchand@redhat.com>
From: Maxime Coquelin <maxime.coquelin@redhat.com>
In-Reply-To: <20230119184620.3195267-10-david.marchand@redhat.com>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org



On 1/19/23 19:46, David Marchand wrote:
> Now that all locks in this library are annotated, we can enable the
> check.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>   lib/vhost/meson.build | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/lib/vhost/meson.build b/lib/vhost/meson.build
> index bc7272053b..197a51d936 100644
> --- a/lib/vhost/meson.build
> +++ b/lib/vhost/meson.build
> @@ -17,6 +17,8 @@ elif (toolchain == 'icc' and cc.version().version_compare('>=16.0.0'))
>   endif
>   dpdk_conf.set('RTE_LIBRTE_VHOST_POSTCOPY', cc.has_header('linux/userfaultfd.h'))
>   cflags += '-fno-strict-aliasing'
> +
> +annotate_locks = true
>   sources = files(
>           'fd_man.c',
>           'iotlb.c',

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime