From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 21F3345ACC; Sat, 12 Oct 2024 02:37:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A5CA940272; Sat, 12 Oct 2024 02:37:18 +0200 (CEST) Received: from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32]) by mails.dpdk.org (Postfix) with ESMTP id 9E09E40268 for ; Sat, 12 Oct 2024 02:37:17 +0200 (CEST) Received: from mail.maildlp.com (unknown [172.19.88.214]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4XQPhc4YwHz1ymXv; Sat, 12 Oct 2024 08:37:20 +0800 (CST) Received: from dggpeml500024.china.huawei.com (unknown [7.185.36.10]) by mail.maildlp.com (Postfix) with ESMTPS id A69FB1A016C; Sat, 12 Oct 2024 08:37:15 +0800 (CST) Received: from [10.67.121.161] (10.67.121.161) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Sat, 12 Oct 2024 08:37:15 +0800 Message-ID: Date: Sat, 12 Oct 2024 08:37:15 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 0/4] fix segment fault when parse args To: David Marchand CC: , , , References: <20230314124813.39521-1-fengchengwen@huawei.com> <20241009045030.26874-1-fengchengwen@huawei.com> Content-Language: en-US From: fengchengwen In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.121.161] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpeml500024.china.huawei.com (7.185.36.10) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2024/10/11 22:13, David Marchand wrote: > On Wed, Oct 9, 2024 at 6:50 AM Chengwen Feng wrote: >> >> The rte_kvargs_process() was used to parse key-value (e.g. socket_id=0), >> it also supports to parse only-key (e.g. socket_id). But many drivers's >> callback can only handle key-value, it will segment fault if handles >> only-key. so the patchset [1] was introduced. >> >> Because the patchset [1] modified too much drivers, therefore: >> 1) A new API rte_kvargs_process_opt() was introduced, it inherits the >> function of rte_kvargs_process() which could parse both key-value and >> only-key. >> 2) Constraint the rte_kvargs_process() can only parse key-value. >> >> [1] https://patches.dpdk.org/project/dpdk/patch/20230320092110.37295-1-fengchengwen@huawei.com/ >> >> Chengwen Feng (4): >> kvargs: add one new process API >> net/sfc: use new API to parse kvargs >> net/tap: use new API to parse kvargs >> common/nfp: use new API to parse kvargs > > I see Stephen wanted to have a look on the series, but rc1 is close, > and I decided to merge it with following comments. > > I marked the new API as stable from the go. > The reason being that it provides the "legacy" behavior of previous > rte_kvargs_process function, and as such, some users may have been > relying on it. > If you think this is wrong, please submit a followup patch. I just reviewed the merged commit, it's OK. > > I was surprised of the change in behavior wrt to a NULL kvlist input > parameter mixed in the change. > But I left it as is. Idem, a followup patch may be sent. > > > Series applied, thanks for fixing this old issue Chengwen. Thanks David >