From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0DF82A0032; Thu, 1 Sep 2022 12:58:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E3D3740C35; Thu, 1 Sep 2022 12:58:13 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 2C5E940695; Thu, 1 Sep 2022 12:58:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662029892; x=1693565892; h=message-id:date:subject:to:references:from:cc: in-reply-to:content-transfer-encoding:mime-version; bh=6VxfYrZ7iwYGYWCxsckyHVXu/0w+zt1JyS88M4p+Cok=; b=RYEOfugs3mPpV3cIaDhBak1LTgLej04+NlfQKP1qbx7LGUkjwqMs4rP4 3vNgQwUD7KzGGrox5lglVzRHWIjO5TQW7GNLPgCwm/swQ3ZI1IR0QAXdu OulTB8HxVa4cBWbRfqNPrqCr4lvHomJzRHajF3Pzg19xorH7XZ8CYoB+Q pKfcLU1Q11Xn7GTX+foxeiraY3m6cwgpEMSxn5tF4z7W+vNZ+1ZMZauhi hktQQ9YqYkyJ7uCl9AjgZGndI5bi4ANY63Nh/duqZb9RNgWLDdYh1oW5m o9cPQ3ABz3yQeIicDXkahNeMVbUORTOEhwte8EjlJRsVQhaoTC+b7y/nt Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10456"; a="295691348" X-IronPort-AV: E=Sophos;i="5.93,280,1654585200"; d="scan'208";a="295691348" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Sep 2022 03:58:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,280,1654585200"; d="scan'208";a="615298282" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga007.fm.intel.com with ESMTP; 01 Sep 2022 03:58:10 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 1 Sep 2022 03:58:10 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Thu, 1 Sep 2022 03:58:10 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.48) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Thu, 1 Sep 2022 03:58:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XuQwaPUxUx6vBmWAxuK/YDFPbHxoGOjU5pWktVNZj+mGA0RluUxvMF/avuUst/esQTwPRWnI7C06pqqdKJZ1Jg9M8uXrSIw7alAKGGrNyX5wXGYhhWOncOR7YxS3VFtd1YzMTNLLrvUe7/z/YmBB3g7F2O+vsrPQ5z5aWYdrW/DJh7R0iAosSNvIFIsA0B96HoWxM8n7aYYAES+Fr+oBH+WJBjZe0EGSUyHCMwP3tsHKrVG2zX61in8ono0jniSAqZoIGglsOZGxrzvOQi7ql8twpWALxIW01bffJ4Oii0QOKK3gJdQMXY7KWSSz8Nz16vBOs/+SUjiqQ9ti2InIeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S+ZcNkPEKQSrZaDtkOXhgKYjL32wKHFwTWQVf37kjRI=; b=V+eC4qiK1BE7JwcDaTOWAPY+c4flRRC3LFqbwTAcjHyt4LcPbqVsTVOwNuXAS5CNMggE1CY5WuhYJbb/fodfJQPm2OiPpyKyeCaIzF+KPoV4p53Pw5C8MI4l2+9s1RoamZMEJeDNyfnUc/jgEX6APywAyhA/s62815JdiS0N0RVlK1U44Ssn1RlEhZkJtALyzCHtv6D/tO/SXTjnOw/FXwnBXnsv25SJ+j6tNZmhj7bAbrNvwmCWB0AMw3eHw43jobMZtGlUgGMEmYaG+Keb6sLONKzFXRj2MA9COYqnfDgGD8g3Rpsb3s8fIFMKYALzSRih08x6fO0nVXqI2w/NjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from BYAPR11MB3799.namprd11.prod.outlook.com (2603:10b6:a03:fb::19) by MN2PR11MB3951.namprd11.prod.outlook.com (2603:10b6:208:13b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.16; Thu, 1 Sep 2022 10:58:08 +0000 Received: from BYAPR11MB3799.namprd11.prod.outlook.com ([fe80::4959:604c:ca50:38b5]) by BYAPR11MB3799.namprd11.prod.outlook.com ([fe80::4959:604c:ca50:38b5%5]) with mapi id 15.20.5566.021; Thu, 1 Sep 2022 10:58:07 +0000 Message-ID: Date: Thu, 1 Sep 2022 11:58:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v2] examples/distributor: update dynamic configuration Content-Language: en-US To: =?UTF-8?B?QWJkdWxsYWggw5ZtZXIgWWFtYcOn?= References: <20220621211346.81545-1-omer.yamac@ceng.metu.edu.tr> <20220628195425.401077-1-omer.yamac@ceng.metu.edu.tr> From: "Hunt, David" CC: , =?UTF-8?B?QWJkdWxsYWggw5ZtZXIgWWFtYcOn?= , In-Reply-To: <20220628195425.401077-1-omer.yamac@ceng.metu.edu.tr> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DU2PR04CA0212.eurprd04.prod.outlook.com (2603:10a6:10:2b1::7) To BYAPR11MB3799.namprd11.prod.outlook.com (2603:10b6:a03:fb::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b33472b4-85fc-4fa6-a96f-08da8c08d9c5 X-MS-TrafficTypeDiagnostic: MN2PR11MB3951:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WNZiGVMbnWIIuoxA3OD1l4+IKT6AKrmGaRiSdpg6x9LPOoefxXKz5nwxGldpDeckX0MmyWv6T6yaLLWeL8KxQiCLQn867INYgkJ0ZA2cYEjMNaQVaKRLnTbrEI4T1Vc6EPQWH8lTckynvOfpCwsmkSw56skHaZ9LT9A+HG2x0jYyEsZIS/L+VpdSbFho1LUvaeUNzOzk4grf/KhCN6XsmwDJDIwLPNpfTReFtCXNFzM36TV0D1DZ1zLg6ZIrkgc56Qd/e3ZVgS7c5x3wKlY82occS7RNXHLo1y1EWHTBlHyqFVy5pgbGqG327xcZ87xfGfRdf3uJVXIbtRDj0424Ib0SqqEQJhRQe6QxMqKPeksoPeMA2njuNLD0PSHXFqJxMzMRI+G2UAOPphnPhAOvU0IOYstHNLbhjFl+EB8DkulwHM86EgSrDEr8xVfFM0tLDIesZJ1W1nGSarNTLv0RVVG1JU7nXaYPBQNjNsyClPyYzKkzR028XArri4VEtj1clXxc3kbCoxfYWFcfDrr7ReukIm5iYsQqCl4iCTvoc1BfSOyQglQASqM1uGEICJ9OdS7WvZhpQePYlmiVI+60Oc+vR6fB606F11/sUKwsqPMyusNEbeaJDM8QXN6ZRNbNW4ONEPKql4XUH9sorUIxzC8N74rr/2lOsdxtdNA0aq9hsyhZmDr1oGWy+952Auyp8djT8AuSHAhgoqeos/a6XjlcUK97Okht6h4Krk2vUahB6/cE8Z+5q/gLC1dphANhcGdmQAs3Nt02E9CPe70K8A3WYGIt2LcNerZeOVyBuDE= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3799.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(376002)(346002)(396003)(366004)(39860400002)(136003)(8676002)(6512007)(53546011)(31696002)(26005)(6506007)(41300700001)(86362001)(6666004)(478600001)(82960400001)(186003)(83380400001)(66574015)(2616005)(5660300002)(38100700002)(15650500001)(6486002)(8936002)(316002)(36756003)(31686004)(2906002)(4326008)(6916009)(66946007)(66556008)(66476007)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RW0vdE5JVkdRbXM2Qm1peXRLV3RvbXBNRmlJNjFsM0g0aXFybW9mQm1lS0dh?= =?utf-8?B?OVlOelZhTEhTZEo1alY1c1QxbDBlc2ZsaGlGdmNFT0E1L1B2UmlzQVZUK214?= =?utf-8?B?clQrZ1ZZaDFRN3BWMm5GanVJOWUxM1MxUTgzbDIwVG9qOEdKSUljNnVZMnFK?= =?utf-8?B?RTcySjU5TTBidUVnU2lhNytkaC8rdUEvZ0JrbjFZV2dnZ1hNV0NvMDg5R1lw?= =?utf-8?B?WEQ0V1ZNL2lGZnlTTlJHMzI2bDVzbWhsUWRZV0sxTUsxQWJEeG9TZTFWZmxN?= =?utf-8?B?VVF4bVlSNUlkdE1XYnhZaWRqS0MrMXQvN2Rub0NCSnkyVVNlWUdXRVJwMjNO?= =?utf-8?B?UHZyZGdoKzB3QjkwVXMvcUFPL05aZHJPY0hzZ2NHbFd5T2NrMTZTalBDdmhP?= =?utf-8?B?TkNLRmlUOUhMY1VGai9DSVhqMDBQelVTbncyeU0yZU9YNU1IaHZzU2RUTFV2?= =?utf-8?B?N3c3cXpXdjFtaUV0L1pGYm1YNHkxNHRGeWJoRHQrS0ZCeCsyZWNiL01hcWNi?= =?utf-8?B?SEFXVkgvdldjbDJVN1kxd3E1T01FOEVKb3YyeHhOMG9vQ2MwbHFsbDN0OUpK?= =?utf-8?B?QzlCdUNrb2RRMmlMT0dnMzVUMG1zWkh1NllTdFZiY0V2QkIrRlBDWUl3QTUy?= =?utf-8?B?Q0Iwd1hjWEczN2hEOTVGcDNOaWM0K0d1REF1RFg5QlNiQkhETGJ2bkVuV0RW?= =?utf-8?B?WDRIZlU3dGQzRHNkd21aVmJZdGpwOFdKY0Jya1NnakFaKzRZR0ZLZ21pTnJz?= =?utf-8?B?TXAwUzg5RjRGamhRMGUxaEJqaHNkSTU4M1plNnVneUJ1aldqN3BrTGRiRzRF?= =?utf-8?B?Z3RNS0YrdDBzNXEwdG5GQUpwcGVOUTJ3aVlFTlBOdldraXc1SzhqTzNpcEcx?= =?utf-8?B?QjMyc2hDYUhCaXdSK1NjNUQ4VFZBWGZWaWtTdXErTTFrSGU4YThaRGI3WmxE?= =?utf-8?B?K0dYN3FvM3VqNFBTWXdYTGt6Ti9wbmlFVngyS3IzS0k0aEN1cDlSdmloclpU?= =?utf-8?B?dnNwQXlwTTJFL2dtaVUraTZqUCtDaUdwYjJ5NWEydGVDYUp2ckxiUWRLNk0x?= =?utf-8?B?UDNKT25LazlrcWpVRUJDZXJMUDRod0RMWktNYlNmSm5BN2o4ZmtKbnhmbFpD?= =?utf-8?B?TTJrMVhuN0dRL1dDTnN3clJmQ3FoWkxkZHJSNUJsN0ZHV0o0TDhXNFNoNlNu?= =?utf-8?B?SFk5N1RWTnkvb3V4SjZtcGYvY3l4TEFSWUFoL3lSZ1NvbXNkOVBEL2tLdHNZ?= =?utf-8?B?ZWQ0S3hqQ1VwU1RDcWsyVTMyVzdZZkNaTjFQVCs5ZGVPNUJ5cnVGbGt4YVVq?= =?utf-8?B?VGoyQXFkWlJmUHV1b212R3RLVEdpUGNaSHpNM1NVK0NQY2FBOFRRcHV4RUZz?= =?utf-8?B?Q2ZWR0ZEbU9xTklKc0oxZ1BLUEtTNUJVblBmRHJscVpyRkxuTmIvbG5acGpX?= =?utf-8?B?MUlhdHJFOTRQemhZWkM2bmg1WnJjMnhXd3Iyd0ZkWFhYTXRQcDVrSWRRaUhC?= =?utf-8?B?V1pHZ2ZBbkdqRFB0cXIrai9GbjI3VE1uank0RW5HbUI5TklGM0dueU1VZGlT?= =?utf-8?B?d1dPb0Mwb05BQTFEdjV6a0huRWVQMjRGL1VmdEdQbW56eG1Tb2hVcmFTdUpU?= =?utf-8?B?TWI2Q3E5Nnd1ZkZNa09RNy9LZVA1SExabVZSb2tUWTRzZ0I2L1lDRHhGdmE3?= =?utf-8?B?M3F2VmhlOWk0ai9ORFIxRnZmMTNqT2JGU09zN3M1REpJS2ZBcE9NNzVsSG1Q?= =?utf-8?B?UGF1ZmdXejAxazRtTmdFWlV5WjFEVmZpQktJUDlOdzg0K2ZTdjNGSXdsZm1F?= =?utf-8?B?aDI0ZDJZNkEzc0VpRTduQWp5dEVZUWZVM29XNVNwdVAxbkNDbmJ3L3ZIYTVI?= =?utf-8?B?VVpnZDRuL1pJTHNHd2llV3BMeTlYWnlmelVKbThNQ0ZubCs3dTNJVGNNMWJM?= =?utf-8?B?Mml4dmF0bzI3NFpwbytHc1FGWWZPRmJHOUI5cENvNW5YWVh5cU9EaTRtYmd5?= =?utf-8?B?bVVpaEUrYm95eTc4VFE1cUZMSW5ScEVNZjAyQTF3a0llanEreHpudUJVcXVn?= =?utf-8?B?eGkrYmhURnJLbUxZUldUYjcrcXF1WDhzelptNlhHSnRKc3RtdnNaSUNiNmQr?= =?utf-8?B?NDNxZ28ya0ZUYVJKMHdpTkdRb3pILzVBVmdqclo0aWtaOUhNTzJiWElISFRR?= =?utf-8?B?K0E9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: b33472b4-85fc-4fa6-a96f-08da8c08d9c5 X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3799.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 10:58:07.0551 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: w/Rm+ER9I59yFGZVCahjPir3NC1bWPsIvUFdrNE5JAvipGuZB+gnsxH6dw9bRQ7q3Q8Fh7FSLp2cs382omJAhQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3951 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Ömer, On 28/06/2022 20:54, omer.yamac at ceng.metu.edu.tr (Abdullah Ömer Yamaç) wrote: > In this patch, > * It is possible to switch the running mode of the distributor > using the command line argument. > * With "-c" parameter, you can run RX and Distributor > on the same core. > * Without "-c" parameter, you can run RX and Distributor > on the different core. > * Syntax error of the single RX and distributor core is fixed. I believe this particular fix is already merged and back-ported to stable. No need to include this line in the commit message. > * Consecutive termination of the lcores fixed. > The termination order was wrong, and you couldn't terminate the > application while traffic was capturing. The current order is > RX -> Distributor -> TX -> Workers > * When "-c" parameter is active, the wasted distributor core is > also deactivated in the main function. > > Fixes: 4a7f40c0ff9a ("examples/distributor: add dedicated core") > Cc: stable at dpdk.org This is a feature change, not a fix, so I don't believe you need the "Fixes" line or the "Cc: stable" line. > > Signed-off-by: Abdullah ?mer Yama? I've tested this with the "-c" option, works well. Traffic coming into the app is distributed among the core. With -c added to the command line parameters, I have an extra worker core, as expected. Looks good to me. With the above suggested changes to the commit message: Reviewed-by: David Hunt