From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 0DC3D1B194 for ; Thu, 21 Sep 2017 11:34:54 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Sep 2017 02:34:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,424,1500966000"; d="scan'208";a="902512905" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57]) ([10.237.220.57]) by FMSMGA003.fm.intel.com with ESMTP; 21 Sep 2017 02:34:37 -0700 To: Chas Williams <3chas3@gmail.com>, dev@dpdk.org Cc: linville@tuxdriver.com, "Charles (Chas) Williams" , Chas Williams References: <20170919212131.7006-1-3chas3@gmail.com> <20170921032536.4461-1-3chas3@gmail.com> From: Ferruh Yigit Message-ID: Date: Thu, 21 Sep 2017 10:34:36 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170921032536.4461-1-3chas3@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3] net/af_packet: make bypass configurable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Sep 2017 09:34:55 -0000 On 9/21/2017 4:25 AM, Chas Williams wrote: > From: "Charles (Chas) Williams" > > In certain situations, low speed interfaces, it may be desirable to > have the flow control provided by the kernel queueing disciplines. > > Signed-off-by: Chas Williams > --- > drivers/net/af_packet/rte_eth_af_packet.c | 24 ++++++++++++++++++------ > 1 file changed, 18 insertions(+), 6 deletions(-) > > diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c > index 7aa26e5..b95d87d 100644 > --- a/drivers/net/af_packet/rte_eth_af_packet.c > +++ b/drivers/net/af_packet/rte_eth_af_packet.c > @@ -59,6 +59,7 @@ > #define ETH_AF_PACKET_BLOCKSIZE_ARG "blocksz" > #define ETH_AF_PACKET_FRAMESIZE_ARG "framesz" > #define ETH_AF_PACKET_FRAMECOUNT_ARG "framecnt" > +#define ETH_AF_PACKET_BYPASS_ARG "qdisc_bypass" > > #define DFLT_BLOCK_SIZE (1 << 12) > #define DFLT_FRAME_SIZE (1 << 11) > @@ -115,6 +116,7 @@ static const char *valid_arguments[] = { > ETH_AF_PACKET_BLOCKSIZE_ARG, > ETH_AF_PACKET_FRAMESIZE_ARG, > ETH_AF_PACKET_FRAMECOUNT_ARG, > + ETH_AF_PACKET_BYPASS_ARG, There was a comment about the define name, just to double check if this has been missed or intentional. <...>