From: Andrew Rybchenko <arybchenko@solarflare.com>
To: Thomas Monjalon <thomas@monjalon.net>, <dev@dpdk.org>
Cc: <gaetan.rivet@6wind.com>, <ophirmu@mellanox.com>,
<ferruh.yigit@intel.com>, <olivier.matz@6wind.com>,
<remy.horton@intel.com>, <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3 4/4] ethdev: support MAC address as iterator filter
Date: Mon, 22 Oct 2018 16:37:21 +0300 [thread overview]
Message-ID: <a4fd6d5d-2e21-73a4-8601-af98f5956ad3@solarflare.com> (raw)
In-Reply-To: <20181022131530.6403-5-thomas@monjalon.net>
On 10/22/18 4:15 PM, Thomas Monjalon wrote:
> The MAC addresses of a port can be matched with devargs.
>
> As the conflict between rte_ether.h and netinet/ether.h is not resolved,
> the MAC parsing is done with a rte_cmdline function.
> As a result, cmdline library becomes a dependency of ethdev.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
I'd like to share my thought about a new dependency.
Looking at cmdline I think that it is a bad and strange
dependency for kvargs. IMHO, even duplication of the
code to parse MAC address it less evil in this case.
May be it is possible to provide internal wrapper
which is implemented using ether_aton_r() and located
in a separate C file which does not include rte_ether.h etc?
Andrew.
next prev parent reply other threads:[~2018-10-22 13:38 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 2:18 [dpdk-dev] [PATCH 0/4] support more ethdev iterator filters Thomas Monjalon
2018-10-09 2:18 ` [dpdk-dev] [PATCH 1/4] kvargs: support list value Thomas Monjalon
2018-10-09 14:14 ` Gaëtan Rivet
2018-10-09 14:31 ` Thomas Monjalon
2018-10-09 15:11 ` Stephen Hemminger
2018-10-09 17:11 ` Thomas Monjalon
2018-10-10 13:12 ` Remy Horton
2018-10-09 2:18 ` [dpdk-dev] [PATCH 2/4] mk: remove broken check Thomas Monjalon
2018-10-09 11:43 ` Neil Horman
2018-10-09 11:53 ` Thomas Monjalon
2018-10-09 18:11 ` Neil Horman
2018-10-09 2:18 ` [dpdk-dev] [PATCH 3/4] ethdev: move representor parsing functions Thomas Monjalon
2018-10-09 9:06 ` Andrew Rybchenko
2018-10-09 12:38 ` Remy Horton
2018-10-09 13:25 ` Thomas Monjalon
2018-10-09 2:18 ` [dpdk-dev] [PATCH 4/4] ethdev: support representor id for iterating ports Thomas Monjalon
2018-10-09 9:14 ` Andrew Rybchenko
2018-10-10 19:23 ` [dpdk-dev] [PATCH v2 0/4] support more ethdev iterator filters Thomas Monjalon
2018-10-10 19:23 ` [dpdk-dev] [PATCH v2 1/4] kvargs: support list value Thomas Monjalon
2018-10-10 19:23 ` [dpdk-dev] [PATCH v2 2/4] ethdev: move representor parsing functions Thomas Monjalon
2018-10-10 19:23 ` [dpdk-dev] [PATCH v2 3/4] ethdev: support representor id as iterator filter Thomas Monjalon
2018-10-10 19:23 ` [dpdk-dev] [PATCH v2 4/4] ethdev: support MAC address " Thomas Monjalon
2018-10-22 13:15 ` [dpdk-dev] [PATCH v3 0/4] support more ethdev iterator filters Thomas Monjalon
2018-10-22 13:15 ` [dpdk-dev] [PATCH v3 1/4] kvargs: support list value Thomas Monjalon
2018-10-22 13:15 ` [dpdk-dev] [PATCH v3 2/4] ethdev: move representor parsing functions Thomas Monjalon
2018-10-22 13:15 ` [dpdk-dev] [PATCH v3 3/4] ethdev: support representor id as iterator filter Thomas Monjalon
2018-10-22 13:15 ` [dpdk-dev] [PATCH v3 4/4] ethdev: support MAC address " Thomas Monjalon
2018-10-22 13:37 ` Andrew Rybchenko [this message]
2018-10-22 14:02 ` Thomas Monjalon
2018-10-22 14:18 ` Andrew Rybchenko
2018-10-22 21:24 ` Ananyev, Konstantin
2018-10-23 7:20 ` Thomas Monjalon
2018-10-23 8:33 ` Ananyev, Konstantin
2018-10-23 8:53 ` Thomas Monjalon
2018-10-23 21:45 ` Ananyev, Konstantin
2018-10-22 14:25 ` Andrew Rybchenko
2018-10-24 8:27 ` [dpdk-dev] [PATCH v3 0/4] support more ethdev iterator filters Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4fd6d5d-2e21-73a4-8601-af98f5956ad3@solarflare.com \
--to=arybchenko@solarflare.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=gaetan.rivet@6wind.com \
--cc=olivier.matz@6wind.com \
--cc=ophirmu@mellanox.com \
--cc=remy.horton@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).