From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 9700E568A for ; Mon, 22 Oct 2018 15:38:08 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id E1651480076; Mon, 22 Oct 2018 13:38:06 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 22 Oct 2018 14:38:00 +0100 To: Thomas Monjalon , CC: , , , , , References: <20181009021858.19216-1-thomas@monjalon.net> <20181022131530.6403-1-thomas@monjalon.net> <20181022131530.6403-5-thomas@monjalon.net> From: Andrew Rybchenko Message-ID: Date: Mon, 22 Oct 2018 16:37:21 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20181022131530.6403-5-thomas@monjalon.net> Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24170.003 X-TM-AS-Result: No-2.732400-8.000000-10 X-TMASE-MatchedRID: QW5G6BKkLToOwH4pD14DsPHkpkyUphL9j5Ieyo542q9794qAHfSq0oZd Y0GqfUpiMH15E661CBNOrgDJ7aGZ2nupOhUR/AE8pkIW3Gref31zd7C7BtJobgFbHA9TqNLQhbV Mkp0EYS2cYirrolnmjvSPy3QY5R6wQm0CRa3IZy7BtFDYGmaWKpkShYcLpGH9H06W6rwtvNXN2W jbpqXgofa8+G6VxpdYgWg8WzvAdS0FrDF4OCzISWY0Io4Kxb86x22bBvE+WY47LF3pX3rdVLjxa 5EVBV1q4vM1YF6AJbZFi+KwZZttL1QAAzJkx/SoavP8b9lJtWqp5xXhqWqMmq/90zonlHtpJLzy 6J1mHd8oAzMltShZ2GdxHzPlzk5FJTD9MNEPrm9virhtSJ5gvG/vgnOxcG0WAbdaJ2uWD+6vxpr hfFJKxoj6lu1hgrW+ZTl9Ilh1gxo9oWnuncvwvVH4EeTFRoCZR8Ddj45OYneZJB6UtR4MgvOptl TzRhSyAvjBvFUX7YiBYkOEiT3/xQ== X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--2.732400-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24170.003 X-MDID: 1540215488-BSNGSCyCBCN0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v3 4/4] ethdev: support MAC address as iterator filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Oct 2018 13:38:09 -0000 On 10/22/18 4:15 PM, Thomas Monjalon wrote: > The MAC addresses of a port can be matched with devargs. > > As the conflict between rte_ether.h and netinet/ether.h is not resolved, > the MAC parsing is done with a rte_cmdline function. > As a result, cmdline library becomes a dependency of ethdev. > > Signed-off-by: Thomas Monjalon I'd like to share my thought about a new dependency. Looking at cmdline I think that it is a bad and strange dependency for kvargs. IMHO, even duplication of the code to parse MAC address it less evil in this case. May be it is possible to provide internal wrapper which is implemented using ether_aton_r() and located in a separate C file which does not include rte_ether.h etc? Andrew.