[dpdk-dev] [DPDK] examples/ipsec-secgw: fix use of unsupported RSS offloads

[dpdk-dev] [DPDK] examples/ipsec-secgw: fix use of unsupported RSS offloads

[Remy Horton]

Since commit aa1a6d87f15d ("ethdev: force RSS offload rules again")
a check that requested RSS offloads are supported by a PMD is
enforced, whereas in the past asking for unsupported offloads would
not result in an error. This patch changes the IPSec gateway sample
so that it only requests modes that are supported rather than
failing to start up.

Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application")

Signed-off-by: Remy Horton <remy.horton@intel.com>
---
 examples/ipsec-secgw/ipsec-secgw.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c
index a5da8b2..d247d5f 100644
--- a/examples/ipsec-secgw/ipsec-secgw.c
+++ b/examples/ipsec-secgw/ipsec-secgw.c
@@ -1566,6 +1566,11 @@ port_init(uint16_t portid)
 	if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE)
 		local_port_conf.txmode.offloads |=
 			DEV_TX_OFFLOAD_MBUF_FAST_FREE;
+
+	/* Only request RSS offloads the NIC supports. */
+	local_port_conf.rx_adv_conf.rss_conf.rss_hf &=
+		dev_info.flow_type_rss_offloads;
+
 	ret = rte_eth_dev_configure(portid, nb_rx_queue, nb_tx_queue,
 			&local_port_conf);
 	if (ret < 0)
-- 
2.9.5

Re: [dpdk-dev] [DPDK] examples/ipsec-secgw: fix use of unsupported RSS offloads

[Remy Horton]

On 22/06/2018 16:46, Ferruh Yigit wrote:
[..]
> Is following covering this patch:
> https://patches.dpdk.org/patch/41313/

Looks like it. Didn't spot it earlier..

..Remy

Re: [dpdk-dev] [DPDK] examples/ipsec-secgw: fix use of unsupported RSS offloads

[Ferruh Yigit]

On 6/22/2018 2:27 PM, Remy Horton wrote:
> Since commit aa1a6d87f15d ("ethdev: force RSS offload rules again")
> a check that requested RSS offloads are supported by a PMD is
> enforced, whereas in the past asking for unsupported offloads would
> not result in an error. This patch changes the IPSec gateway sample
> so that it only requests modes that are supported rather than
> failing to start up.
> 
> Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample application")
> 
> Signed-off-by: Remy Horton <remy.horton@intel.com>

Hi Remy,

Is following covering this patch:
https://patches.dpdk.org/patch/41313/

> ---
>  examples/ipsec-secgw/ipsec-secgw.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c
> index a5da8b2..d247d5f 100644
> --- a/examples/ipsec-secgw/ipsec-secgw.c
> +++ b/examples/ipsec-secgw/ipsec-secgw.c
> @@ -1566,6 +1566,11 @@ port_init(uint16_t portid)
>  	if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE)
>  		local_port_conf.txmode.offloads |=
>  			DEV_TX_OFFLOAD_MBUF_FAST_FREE;
> +
> +	/* Only request RSS offloads the NIC supports. */
> +	local_port_conf.rx_adv_conf.rss_conf.rss_hf &=
> +		dev_info.flow_type_rss_offloads;
> +
>  	ret = rte_eth_dev_configure(portid, nb_rx_queue, nb_tx_queue,
>  			&local_port_conf);
>  	if (ret < 0)
> 

Re: [dpdk-dev] [DPDK] examples/ipsec-secgw: fix use of unsupported RSS offloads

[Remy Horton]

On 26/06/2018 10:03, Ferruh Yigit wrote:
[..]
> Hi Remy,
>
> Is following covering this patch:
> https://patches.dpdk.org/patch/41313/

Patch was sent out with wrong subject, so consider it Nack'd.