From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7B8E3A09E4; Thu, 22 Apr 2021 10:53:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 05E3C413E6; Thu, 22 Apr 2021 10:53:05 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 1CB954069D; Thu, 22 Apr 2021 10:53:03 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 63DDD7F51B; Thu, 22 Apr 2021 11:53:02 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 63DDD7F51B DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1619081582; bh=yyO5F60eRzFCtIKifCDSaWQrp93pvXmOA5IDY3ea7Fw=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=YgfbzyXexkFh6A+jxR2DGKZhGLAicdv5wXhapqSdSwcxXW9PEmvfYGKS/ltwjo323 2lWzNMHAZkpAp36lp5N/isCg4tA2+WkMroLVJZ6rz4HkHZT3HTncTM8pQbVSKDQ8sr NvrLCu7Ud+MACGNnvdJCTWOO/gnFR9Z9IR6FPOXA= To: Ajit Khaparde , Ferruh Yigit Cc: Igor Russkikh , Pavel Belous , Somalapuram Amaranath , Somnath Kotur , Hemant Agrawal , Sachin Saxena , Jeff Guo , Haiyue Wang , John Daley , Hyong Youb Kim , "Min Hu (Connor)" , Yisen Zhuang , Lijun Ou , Beilei Xing , Qiming Yang , Qi Zhang , Andrew Boyer , Jerin Jacob , Nithin Dabilpuram , Kiran Kumar K , Rasesh Mody , Devendra Singh Rawat , Jiawen Wu , Jian Wang , Thomas Monjalon , Selwin Sebastian , Remy Horton , Chunsong Feng , Huisong Li , Hao Chen , "Wei Hu (Xavier)" , Jingjing Wu , Wenzhuo Lu , Xiaoyun Li , Alvin Zhang , Shannon Nelson , Alfredo Cardigliano , Vamsi Attunuru , Yash Sharma , Ivan Malov , Andrew Lee , dpdk-dev , dpdk stable References: <20210421162058.1352960-1-ferruh.yigit@intel.com> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: Date: Thu, 22 Apr 2021 11:53:02 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] drivers/net: fix FW version get X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/21/21 7:30 PM, Ajit Khaparde wrote: > On Wed, Apr 21, 2021 at 9:21 AM Ferruh Yigit wrote: >> >> Fixes a few different things: >> * Remove 'fw_version' NULL checks, it is allowed if the 'fw_size' is >> zero, 'fw_version' being NULL but 'fw_size' not zero condition checked >> in ethdev layer >> * Be sure required buffer size is returned if provided one is not big >> enough, instead of returning success (0) >> * Document in doxygen comment the '-EINVAL' is a valid return type >> * Take into account that 'snprintf' can return negative value >> * Cast length to 'size_t' to compare it with 'fw_size' >> >> Fixes: bb42aa9ffe4e ("net/atlantic: configure device start/stop") >> Fixes: ff70acdf4299 ("net/axgbe: support reading FW version") >> Fixes: e2652b0a20a0 ("net/bnxt: support get FW version") >> Fixes: cf0fab1d2ca5 ("net/dpaa: support firmware version get API") >> Fixes: 748eccb97cdc ("net/dpaa2: add support for firmware version get") >> Fixes: b883c0644a24 ("net/e1000: add firmware version get") >> Fixes: 293430677e9c ("net/enic: add handler to return firmware version") >> Fixes: 1f5ca0b460cd ("net/hns3: support some device operations") >> Fixes: bd5b86732bc7 ("net/hns3: modify format for firmware version") >> Fixes: ed0dfdd0e976 ("net/i40e: add firmware version get") >> Fixes: e31cb9a36298 ("net/ice: support FW version getting") >> Fixes: 4f09bc55ac3d ("net/igc: implement device base operations") >> Fixes: eec10fb0ce6b ("net/ionic: support FW version") >> Fixes: 8b0b56574269 ("net/ixgbe: add firmware version get") >> Fixes: 4d9f5b8adc02 ("net/octeontx2: add FW version get operation") >> Fixes: f97b56f9f12e ("net/qede: support FW version query") >> Fixes: 83fef46a22b2 ("net/sfc: add callback to retrieve FW version") >> Fixes: bc84ac0fadef ("net/txgbe: support getting FW version") >> Fixes: 21913471202f ("ethdev: add firmware version get") >> Cc: stable@dpdk.org >> >> Signed-off-by: Ferruh Yigit > Thanks! > For bnxt, > Acked-by: Ajit Khaparde For net/sfc, Acked-by: Andrew Rybchenko