From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 9F1573798
 for <dev@dpdk.org>; Tue, 29 Aug 2017 18:12:12 +0200 (CEST)
Received: from orsmga004.jf.intel.com ([10.7.209.38])
 by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 29 Aug 2017 09:12:05 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.41,445,1498546800"; d="scan'208";a="123703055"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57])
 ([10.237.220.57])
 by orsmga004.jf.intel.com with ESMTP; 29 Aug 2017 09:12:04 -0700
To: Ajit Khaparde <ajit.khaparde@broadcom.com>, dev@dpdk.org
References: <20170824162956.62761-1-ajit.khaparde@broadcom.com>
 <20170824162956.62761-7-ajit.khaparde@broadcom.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <a5344805-05ad-647f-8e88-4a5ed2b1a4dd@intel.com>
Date: Tue, 29 Aug 2017 17:12:04 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <20170824162956.62761-7-ajit.khaparde@broadcom.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH 5/8] net/bnxt: add support for
 tx_descriptor_status
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Aug 2017 16:12:13 -0000

On 8/24/2017 5:29 PM, Ajit Khaparde wrote:
> add support for tx_descriptor_status dev_op
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>

<...>

> +static int
> +bnxt_tx_descriptor_status_op(void *tx_queue, uint16_t offset)
> +{
> +	struct bnxt_tx_queue *txq = (struct bnxt_tx_queue *)tx_queue;
> +	struct bnxt_cp_ring_info *cpr;
> +	struct tx_pkt_cmpl *txcmp;
> +	uint32_t cons;
> +
> +	if (!txq)
> +		return -EINVAL;
> +
> +	cpr = txq->cp_ring;
> +
> +	if (offset >= txq->nb_tx_desc)
> +		return -EINVAL;
> +
> +	cons = RING_CMP(cpr->cp_ring_struct, offset);
> +	txcmp = (struct tx_pkt_cmpl *)&cpr->cp_desc_ring[cons];
> +
> +	if (CMP_VALID(txcmp, offset, cpr->cp_ring_struct))
> +		return RTE_ETH_TX_DESC_DONE;
> +
> +	return RTE_ETH_TX_DESC_FULL;

Same comment with Rx one, a check may be required to distinguish between
status FULL and UNAVAIL.

> +}
<...>