From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3C45B42E3A; Mon, 10 Jul 2023 10:36:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0C77D40C35; Mon, 10 Jul 2023 10:36:08 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2052.outbound.protection.outlook.com [40.107.93.52]) by mails.dpdk.org (Postfix) with ESMTP id 4E56340698 for ; Mon, 10 Jul 2023 10:36:07 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YIh5f4kNWpmfJjaPqdA27cioPiZVCFWRo9wbTTCFN5F/eqcNC9J9CpHZbckNc47k1+eMQMk9c6hD45GBUjwjkliQUpH78j+Rnnbd8uxwwWpCe4aGVzSd6O5rz3ypmxjzIs8098w1GAPFIfsfSiaMlVS+yGQWyJrsuKoumMpMZm+PGY6Xdg76VsDY3ESfC1rim2F8n0rEzU8FExqRCR4pupOUjFeVAqehxmDU1RmQ5ckkG0V76c2daZdcQ6DerWU08U128v5Te5egLPDEHCQ75sOzKGC0JUFcJt4gqLpBTRF5CuLVUlgXKDoEwUxahk/YUt5/EVvMP8R4BHNIh1/ICA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T2rfD8GHNF+zozNpwFsaFNtXX0lITfcPPKj4t32n9rY=; b=Dg1bAhor9kh3gfFGknEVe5YsYDsNOUrprseqg5+8mbXvQUO8a1qZomIgW7dZRrpuNRHWEYy5VyFQ7+KWS/LzuigA3yfFO0pFOfFjN1MGVAADnqg4NABHzPyZqfFckp6zx/kPjTW70hvfCiMAHj4z+aG0xD4Shaq+OBYq5ueJrtSZUPsQhjEWYXI4N/7KaXm6JF/Y8yXMgtzrz7rvz0pkvdQcUZk5c/nQdBWQehjtxoSn2OjIqJsuumm5oWlZrElPmQ95qvvS/CGNNCIcCCs1mhmYCzFaqYT1fme8m5+SyVueE3rm5qstkkVVDX1wJHMlunINAkVh9DUWMiR2sRzwvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T2rfD8GHNF+zozNpwFsaFNtXX0lITfcPPKj4t32n9rY=; b=nvjaJT43d5BI++NqzJz5Eav857l+WkcmyhHxY0WR1a1ECYL5Ur9iTO+P/ZWq9VUFiIOzo/KfORDmkmP7lzsrjt6ygY+hUAr96ExKEiHgQDF7oeS0gSqc92UINTNNpjbtV1HEwF9F7ceY3/0vtYdKV0J1bz0u8M9iDnQw85XMBPo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DS7PR12MB9042.namprd12.prod.outlook.com (2603:10b6:8:ed::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.30; Mon, 10 Jul 2023 08:36:05 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::369d:5f05:aaba:ebd8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::369d:5f05:aaba:ebd8%3]) with mapi id 15.20.6565.028; Mon, 10 Jul 2023 08:36:04 +0000 Message-ID: Date: Mon, 10 Jul 2023 09:34:39 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] net/netvsc: set the correct queue state To: Stephen Hemminger , Long Li Cc: "longli@linuxonhyperv.com" , Ferruh Yigit , Andrew Rybchenko , "dev@dpdk.org" , Ajay Sharma References: <1688755996-25172-1-git-send-email-longli@linuxonhyperv.com> <1688755996-25172-2-git-send-email-longli@linuxonhyperv.com> <20230707131601.1b2f9cd1@hermes.local> <20230707185250.32538127@hermes.local> Content-Language: en-US From: Ferruh Yigit In-Reply-To: <20230707185250.32538127@hermes.local> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DBBPR09CA0013.eurprd09.prod.outlook.com (2603:10a6:10:c0::25) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DS7PR12MB9042:EE_ X-MS-Office365-Filtering-Correlation-Id: 19b912e5-4202-44fb-7fdd-08db8120b2f3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +QXZFzyYS7FSwqtTXLWfgHLC8H+S6ZkTm9i9sl6/5f9pMzK8l8sZIQ9kXVylLgI3W9JP/moiWcWHbym+DxZC4PrOiJ0KLElh/qEcnyRUcP89G1Jp0FAyHelHpfc9tnamcfKA+NbWkqdZjQafarVy+yhYzmIymj3fz69CZiGUcxK+Cnq8EzEMRqhMuhToWx2xl0mNLS7qsXifXDygwmiEEa6RilDvHwRyAgx044VdSc6ps/76/ZrSrbp+ZPOiJxhS+gcpDC3AdRt2F7iXfwTnX5twMikK4ZReIPHBgTQzQuNNfvxd3tsnrvYs4LITK1jyJovro9xfC2umUTYeV69B0ym/wEbAV6gJV1QBjADj/tiIrPXkcd7EMotQp1skYvQtgqmnbWkVMTgzmfHd056FOPMnUYZKwCPS8q4gMul0g/YSXwzptsHJ/SE5zmCRWveCbLiUh/YBi2xZJa9CbXFSDbB+WyDyCzY+xA+lbPPbd0sghgXaub4w8odkMbIStZ7av18LX8AaldhjPgwzVEaL9O0u11hqO3UmBqxqrTyfypW09en8tLSp9eMagwcxjDmSNZMiZ5rez/hGQP62LuohkAc/ZWj5r6XJ9gu67M2FGRM39QPmWkhGkp+MuiYg7xHTjKAarVC88OcIU0YBxniITg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(366004)(39860400002)(136003)(376002)(346002)(396003)(451199021)(31686004)(6666004)(6486002)(478600001)(45080400002)(110136005)(54906003)(83380400001)(36756003)(86362001)(31696002)(2616005)(2906002)(66946007)(6506007)(26005)(53546011)(186003)(6512007)(38100700002)(8676002)(4326008)(316002)(66476007)(41300700001)(5660300002)(8936002)(66556008)(44832011)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YjBzZTRpZFU5TFlrZU1aUnhNdWtxVm8rZFQ1NE9qcHMrSnlOV2grdnNHYkNU?= =?utf-8?B?dytUdDJLOWFqUTBCN0djdVh2dlZWV1hGVERFZCsxa0ZWTDFXdldZenlYbUhu?= =?utf-8?B?elF0L0FlOGFUYStzVWxYNnVxM3FqZ0tKc0xzSC9LTUNBS0ZqZFpBajRDVHVs?= =?utf-8?B?VUFwVWgvdUYwNnIyWkhhWjMyckRTNkFETkNiVE5qd0dBbk1zNlQwTXpwOGVZ?= =?utf-8?B?U0FhT3A1c08zQ2UwdmErWmcvdXpYWFdvMzQzUGNBMjRYQStHaDlESmxtUEhG?= =?utf-8?B?TURPSDF2ajNTdXdCQkR6TFhRT0tHTDRSdEFvRTl4dEFGUEV5Mzl3c3NVUTRH?= =?utf-8?B?UjlVcHNSNlVXNUc2a3JXWS82ZnZmSFNtZXoxMTljVUw0TDRTbkNOWTV3ekR4?= =?utf-8?B?QXY2L0wzeTg4N1llUEVUVHFMMGRFT3hISXgvRXBleVNGM1lHTHN5OE1ueWZq?= =?utf-8?B?c0Nqb2hyY3dKbzZQVnowMmIrQzRCMUJ3TUFkLzU0Wm1jVE5pTnF2azQ4ellu?= =?utf-8?B?T1lRVEZLb2wvdFdRUFVOemE2d0JVYi9WdW0wMk13TzJNT2VsY2FNR0IxclBV?= =?utf-8?B?aUNjOGVWMEV0Rkh5S1I2YjJPaklKdGlueXllakc2U0hoNldLMGk2ZjIrZ3JD?= =?utf-8?B?a0MxTTNYY0dhcldBVnFpVk1zQTg4T0lWU1g0THI0aVdlOHdjSmtCcEFpdWZX?= =?utf-8?B?N0N2Nk1kOHlSMUhjcWxXQTRoRVZuVm5abDVmeDN6cE13endtbUhWcjVQd3J3?= =?utf-8?B?RjZMMWZ4TkNPbVV4Z0dTNGNLR3llVU9ReDI5TWZ1RnUvcHd3aWppdFJKbDR6?= =?utf-8?B?cEYvTjFZdWEwdTkyblVhTTNxa1MvdmNSd08wVVhHUHpVU2ppbVpNdnczaCtX?= =?utf-8?B?bVQ5b29pMFFmUnJLWkZ1Mk44b2gzZjZjR213QWlsWi9uN0QzTDBteXpPTUc3?= =?utf-8?B?bmUvbHBPYXMxTktndS9GaWpvbDkxTEJRODMxdXhPMGhEcjhjMmNqMHo4VFJI?= =?utf-8?B?UUhJb0VXZnNjNUJpQldPSzJRQm1vaFpYUVhqQ21idVc0S2NXQXRTY3BoS0Ny?= =?utf-8?B?UmFVNjhJYTY5bDJYa1RKU05DTkcrRVVXdDh6UzZyL1ovV1JPOXZ4S1FTSmJS?= =?utf-8?B?aDVHVjZkY21RU05jc2Y2QzBTdkNCcEZsQ25vQzdSZVR3dXdnSW5uZ1BNN0wr?= =?utf-8?B?TGJxdjRoVm9ySUFRdVlOTTBXZ1RuS0lFdUpxcGZrVENBSnRDYkNYNmt5T2dX?= =?utf-8?B?TGVrbGJydDQySmxSelFCeE5zSkp4eGp1Vkt1R2MvaVJ0aVBWV3VPVGE5VXMv?= =?utf-8?B?eFA0VUFnZHVJQVZUYXduTHdGbnJlRVhQbUhINUVQd1J1YkJOSWZyQ3dQaUhG?= =?utf-8?B?ZDI4TUFQS3E5OGc5TUtaZFZTVXh2cDg5djBGTFlpOXVnTjBnd0dxeDlCMlNB?= =?utf-8?B?WmF1MXAyOFZ5NXFXSm42YmNCNURqUHRHTGR4QWEvOGkycURScTA3eXJ2TGdO?= =?utf-8?B?K3pzZmp0ZFlQSzIwWWNybEgxai9CZG9RVnR3elhJbGtSU0xXbnQxalZUVU1l?= =?utf-8?B?SHNwcUN1SjdKVGhKczJNLzdJWmVuRVBZVXp1L0d0aEhVeGZCSVFqQUc0Y1lh?= =?utf-8?B?cDJmWDZOVlRLbC9XQU5HanQxVGh0TzJtOFU4L3lyVU5jcUFBdnFGdWpTNysx?= =?utf-8?B?VDNwQ2oramtReXZrdHg3aWdhQ2xyRUlzbGNoSWFrSnF2V3JKMW8wQ3pHMnhV?= =?utf-8?B?VkptMHQ3SzJuTHUwQnd1b0F1TExqK1pEbTcrMlBhUWNiWko1UTVSOVVFUHd1?= =?utf-8?B?Ynp0emE2eldLemgyUFhiNTcrZUtXTTZNUzZhd001c25SUGZZQzROWSs1WXY4?= =?utf-8?B?VElBOGJLM1B0RjZYa1dpNEpUbXRkZDZmUnJzdWwrb3UrVVpkOFZRYVNjSTFP?= =?utf-8?B?TGYxQjZzK1NTaUZkc2ovQzdsYVNLNXYyZVd6dXhiREU1MFdRS2FCTkRGd25B?= =?utf-8?B?bUwxYkk2aisvYlJ1QjZGZG0zbmJtTVhoU2dwMGRiZm14RTVBQkRYNjZFQ0du?= =?utf-8?B?ZTF4SEJKek96dXRYdjJyajVWU3kvUEZZSnVzM2Vsa0tXajRrdE5IaGQ2a1N0?= =?utf-8?Q?tsPkQSF1y/XEyv2eqZFMomIyJ?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 19b912e5-4202-44fb-7fdd-08db8120b2f3 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2023 08:36:04.7523 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NL5V/Xeh6cs4rF4VPvIMc99rsRUdvRSiRgHj5nBhy8LzT2RPd65YPVqLK5P78T1O X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB9042 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 7/8/2023 2:52 AM, Stephen Hemminger wrote: > On Fri, 7 Jul 2023 20:43:51 +0000 > Long Li wrote: > >>> Subject: Re: [PATCH] net/netvsc: set the correct queue state >>> >>> On Fri, 7 Jul 2023 11:53:16 -0700 >>> longli@linuxonhyperv.com wrote: >>> >>>> From: Long Li >>>> >>>> Set the queue state when queue is started/stopped. >>>> >>>> Signed-off-by: Long Li >>>> --- >>>> drivers/net/netvsc/hn_ethdev.c | 15 ++++++++++++++- >>>> 1 file changed, 14 insertions(+), 1 deletion(-) >>> >>> Interesting that not all drivers do this. >>> >>> Acked-by: Stephen Hemminger >>> >>> The ones not doing it. >>> af_packet >>> af_xdp >>> avp >>> axgbe >>> bnx2x >>> bonding >>> dpaa >>> dpaa2 >>> e1000 >>> ena >>> enetfec >>> gve >>> hinic >>> igc >>> ipn3ke >>> kni >>> liquidio >>> mana >>> memif >>> mlx4 >>> netvsc >>> nfp >>> null >>> octeon_ep >>> pfe >>> ring >>> softnic >>> vdev_netvsc >>> vhost >>> virtio >>> vmxnet3 >> >> Testpmd added the check for stopped queues: >> 3c4426db54 app/testpmd: do not poll stopped queues >> >> To pass testpmd, PMD needs to set queue state. > > So there are 20 drivers broken by that change! > Sounds like it needs to be reverted. > testpmd change is already reverted in the next-net, but planned to merge it back in next release, and we need driver changes in next release.