From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2F17542B6F; Mon, 22 May 2023 12:28:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 082E840EE7; Mon, 22 May 2023 12:28:27 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2040.outbound.protection.outlook.com [40.107.94.40]) by mails.dpdk.org (Postfix) with ESMTP id 481A140EE5 for ; Mon, 22 May 2023 12:28:25 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gT++dqYMMeYd62svYrxbWSCx+t9vApeesElloc+CGqWX2Cqod0/0p7iG9kwjZTqJHWNDdXajlfEqjJMDquFWaC5JhuuHe5q4Ny669wh9BAYRIB9eN2Y3zUyJDhxkLbHv9IwqoKfZDQ2M9HboP+ioeRBcBGEll5QlrYLN5ce/9q7i0hE8AAD3QZkmJDu9iVriWeDNqWvQi1KUfc9pgBDkiXEZITQqRuRG7atB11Dh7VNNy66GDdpIZ//VTRMAC5zFoswcRiIcthkTeKk2GccHAjEWmPaBlFdjPSwQywfkTe2wN/UNh17XK+pM+/durPYFKd3XbUnneex7ujq9zSKwKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GPOzUjQs0imGeKBOIxpiWvbLBDRf3sYtYzamoRtMMwk=; b=FW9sx7/1gQr7C9Ss/8DmtKaoRpvoRowBpNN6UkX3YRLi25w05RXXSc/yyM1ggTlAkwbQujxXkKaPWT5OclCVEsei4bdpNL049tA9RbiKeMUb0un9kslR2T9VSqeX7ltrdSznjEvmtKYl8acbbOYIbYl+pc/G0llrM1qxEGIcLl+uRkZ+dZ8uvj2ZKzcoHN5jxSDGMA6uSm5vre9eysV+DcSDqENKJmQYG1DeCzeV4dvgiCADC0DVSIlzvxog3+BkA8gWDrWZWTDho1UaWjGAZlHmNOh4a+G8dqcY93ucffT22ot3lc69YmT2AX+XdTFc5KCVecdRxuyPr1pGgbMl5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GPOzUjQs0imGeKBOIxpiWvbLBDRf3sYtYzamoRtMMwk=; b=sIM5etoYbQftBRtZW4WvKPwpzvVbhFnT2xEylgQhNk0w5GY82nVuQ2i2+3B2PtdGnuJLYM/n38LfZEbxN8lgiDr/JlCD4HJvG6MO0Kkild/N/QaHWaFYlKaIP4EsI+qOs/1uN3eiGWQvQITnkfX+uU4/RRW23OgJmlF37Gs5GII= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH7PR12MB7185.namprd12.prod.outlook.com (2603:10b6:510:201::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.28; Mon, 22 May 2023 10:28:19 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a%4]) with mapi id 15.20.6411.028; Mon, 22 May 2023 10:28:19 +0000 Message-ID: Date: Mon, 22 May 2023 11:28:13 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v3] ethdev: add flow rule actions update API Content-Language: en-US To: Alexander Kozyrev , dev@dpdk.org Cc: orika@nvidia.com, matan@nvidia.com, thomas@monjalon.net References: <20230518194943.2338558-1-akozyrev@nvidia.com> <20230518214852.2364233-1-akozyrev@nvidia.com> From: Ferruh Yigit In-Reply-To: <20230518214852.2364233-1-akozyrev@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO3P265CA0021.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:387::8) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH7PR12MB7185:EE_ X-MS-Office365-Filtering-Correlation-Id: cb4b67ac-dbd1-4596-1cd1-08db5aaf42cb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xmsKr5UF/FyDEaFVzJziDmXgnNVwuHS6wf5bszFI4qAdI63PnkcGi0Dzvv8U4qIdPhGkHXXqU1Qjz6w5txaRM3Gkdh6dKNNKRb2Codi1d9DYvqWbqyq4Yik4GmV9Jz+YFYre2Jao6NwuA5C2kYUX1TVls2kGcDrq4gKrKaPEoKaE1UfJUsUZ0IsoQBCQYu/mZFdLDPEvUEadKpNbeLSTTB9jI80jxOnjNX5cxChAQNF1lfGOUyAp9R/GWXmLS14omCYobd63SCW3eXHL0eh6ejZu1smIMpwKmiw95V5hbXlT0gqW4pP44FuUsIddX5NebUGibQojZjS1xchzf4bka0N7nLYgvD4VdRB3H8RiGaAA8gUWFBHgfTrp2+8OZFLPmZRmFIFmBfOZF9O9rJ4b312DKaOmuD2Dn4A0YdnZrnbD2AZVKwLbgGW4wJFFpvDgH3tkuiiEZC+aWx4w/47ToWRNDlM0hEhpOgfIzCrLTm0PiAfZlqjOH6ZUC8m6hdekXyswAoWIosO0kJojith7ro7h40QYAskemoek406hsAOGNHkFzfbvYtDPGLDUzRTkYoknZOgreztbftzgfpbOiRFe1SsbwvqJJwTmZEYBQp8a84bYzuCz9AaqPoQnoU7RXmxX3DZCkFj98eIMgc1b6w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(346002)(136003)(366004)(376002)(396003)(39860400002)(451199021)(478600001)(186003)(31686004)(41300700001)(5660300002)(26005)(6486002)(6666004)(66476007)(316002)(4326008)(6506007)(44832011)(6512007)(8676002)(8936002)(53546011)(15650500001)(4744005)(2906002)(2616005)(83380400001)(66946007)(66556008)(38100700002)(36756003)(31696002)(86362001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eG1GeDB5aXlGcGZYaDlTVFpnMkRid29zSVBiTFBZREEwQ3FLaVdEQmI4SUpU?= =?utf-8?B?YmFuSW9jSTNqSmtLUWFjWFZObGh0LzhGTTMrTFZaR2tIY21hN2lVOVBwVnZw?= =?utf-8?B?R2xubURFQ04rN3lWWnNNRXozbWJRZDF3djFKWGdPdmprQ1NsRGk0WkVabjRU?= =?utf-8?B?Nm1BdG5OWWovbWxVYWlVSVYrQnNXb3lFQzBqY0JaRWtKYVFqejFHM3NzOUM3?= =?utf-8?B?bmJCaVBHRERSbkdQS1VVeUh6dklGTW5UTlFSNG9YTjE3WisvRXZpTUY5UVoz?= =?utf-8?B?OTBMaWdpQ2RuOUtPWU5XWHBFTEJxdm9IZURMeW80SWEvOHJjdDNPenNTNmQ2?= =?utf-8?B?Y2luM1lpSm0veXcrWWFIQ1Z6UFpFeGl1SnhEQ0tvemQ3OVZNOFZSbTFuNHNx?= =?utf-8?B?T2o0QzRzR1J5Qm53VkV1M1JiVXZDWUo3YTRtbEhQRHIrTGlIditLVUoxeEdr?= =?utf-8?B?UEtqRmg2R296WjBvejhpWGJQdUdZd3AxSGdjRE9VUExkQlZnQWpYMHd2NkZZ?= =?utf-8?B?ZmViWUJhOTNJcERkS01YeU5ya3Vrd0JOVmV6c0d1RG1qWGhFYnVnSU95dnV6?= =?utf-8?B?bWdHczdIaEl1UXhKNi9jQlJubk1GWm5BWXU1c0Jlb05oOXZ2dTZwUjBRTFVV?= =?utf-8?B?dkNFWjNIdDRFWW0rMGs3TEtVaXREK00vblVQUFpOSWZBU0dFQ2JUbE5Ed1Rl?= =?utf-8?B?ZlprZWRVcFpSaDV6NmtabzFkSEdrTnhLQ2NBR2Q2Y0R0KzBHZ3RGa3NJWW51?= =?utf-8?B?eEV3ZVdjelZlRjBKa3ZZZG8vTERNdVcra2VnUTNDZFRFZmd2RUJTN1pyZmhj?= =?utf-8?B?RjFLR01uT0oyZGw2azRibzQyUmpYN3dVRkpxVzJUOEJSaFZScXdPaU1OOXQ4?= =?utf-8?B?bEl3WkpoRmVJM0FRME9nSzNDN3FLSHlqd0pnc3BtRUVoU2czQnZBMk01OEF1?= =?utf-8?B?WFkzTXk4aWx3cnV0Y1g5bnBNNk94ZDYydUVOeklrdW5rOGIzZzlLRnNsYWdX?= =?utf-8?B?VVJlVVVzNmdSc2Q4SWxLU0hIblJ0NklrR0NPQ09McEpPVzNjRkNXYlBpSFBp?= =?utf-8?B?NWFiNUNpMjFUSUtGbU16YW5HSmpoSXFERXdMZHJtNmlJeHFRZ0RoMUFSb3hD?= =?utf-8?B?VFlMYnF0VkZNZ3RzZVduQi9ndCtDWHZkRGZDZHM5bnQ2VGp6dS9aTis0SVdt?= =?utf-8?B?RWRsaUZBUG9NWm9oUTdHYlczWHlsNVFJOXJQSkp1cXE0bEd5NlhGcm9EQ1dj?= =?utf-8?B?RGJXYkt2RlpkQ3dLRVBwUVloa1JLVkFqTlhRN3pBSGRhazlrd0Voa3NGZzZn?= =?utf-8?B?OUIzbk1sRFkvM21taUpKUmNoWG4yQVQvWEdiUWZLcHRra0JpaHlOc25iMldq?= =?utf-8?B?cWMrNzRtVFRFY0tqWE1obEJURHNQQnhxdWF6NnFrY2M3QmpPbFRBeTZqZzNC?= =?utf-8?B?QWxqN1ZmL3R3dFFUU0pTUHo2Y2ZoQ2wyUkF1LzUzUVFaRHR6c29YNS9obHhB?= =?utf-8?B?aXdEQWFjbkZxQjMvQzk0MUdGRXJCOEIzT0hVMUowUWNmNTUwb3gwZlR2dzdY?= =?utf-8?B?VEc4bS9ZVTR5ejdkS2MxUk5iZHNwU3I1U2tQdGJ3bW82TVFiQVBhTjhWSlRD?= =?utf-8?B?SnpRY2RsYTJNbjFmVm15NFlVMG93TThFeThhZTk2TjZpUDZLK0dSSU53dm5s?= =?utf-8?B?S2NDUFZhMkUrM2hJalN0aFBVUDh3UENvUzkrZFFkR0VFMzF6eURUbGpBNk45?= =?utf-8?B?RFM2Z0hPc3MyN3BmS2d0VUx5RDhUcUhpMFMweHFNMCthRURsUnVhYXI1MnNp?= =?utf-8?B?bHEvekVVei83SzFKNUNlNG9ScnpSUGJKcElSOU5hNlRZYkJ6UHY3S3ZOSVlX?= =?utf-8?B?WGt5Rld1d0VGcGVxenJHQlI2WGpxV0Y4REMyemZ2QUlRWlZlTXFYODRUNjNS?= =?utf-8?B?c3gvRDFyWEJGOWMwS1BsU3lkNnA3TlpVSzZMU2llT0d1OENSUnZEc21TbUhQ?= =?utf-8?B?NmNGNU1nQ0VlbitKRTliWGpMckdGV0pPSVhxbk9mQ0lxTUpqMkFSNi9SL3dO?= =?utf-8?B?ZTgyOEZGYzAySnN3SFA4ZGpTVmlpV1UvNFdOaGdQbVk4djluSDFhOXMzMXhD?= =?utf-8?Q?5Hc46PEecZxMDxbrIHyaytYRv?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: cb4b67ac-dbd1-4596-1cd1-08db5aaf42cb X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2023 10:28:19.2263 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AYFif+BC//vWZ4qcljb9v70ZS7kfijrb9iMG3IjrBbcov71PBLrn1U4GvaPkiUxn X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7185 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/18/2023 10:48 PM, Alexander Kozyrev wrote: > Introduce the new rte_flow_update() API allowing users > to update the action list in the already existing rule. If the API is only to update actions, does make sense to rename it to explicitly state this, like: `rte_flow_action_update()` Same for async version of the API. > Flow rules can be updated now without the need to destroy > the rule first and create a new one instead. > A single API call ensures that no packets are lost by > guaranteeing atomicity and flow state correctness. > The rte_flow_async_update() is added as well. > The matcher is not updated, only the action list is. > > Signed-off-by: Alexander Kozyrev <...>