From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 54DB0A00C5; Wed, 14 Sep 2022 14:55:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E43524021D; Wed, 14 Sep 2022 14:55:24 +0200 (CEST) Received: from mailgw01.pantheon.sk (mailgw01.pantheon.sk [46.229.239.26]) by mails.dpdk.org (Postfix) with ESMTP id 43EF240156 for ; Wed, 14 Sep 2022 14:55:24 +0200 (CEST) Received: from mailgw01.pantheon.sk (localhost.localdomain [127.0.0.1]) by mailgw01.pantheon.sk (Proxmox) with ESMTP id D64E5201C57; Wed, 14 Sep 2022 14:55:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; h=cc:cc:content-transfer-encoding:content-type:content-type :date:from:from:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=dkim; bh=SMgHWyqywwNA1SVdP463 9hkhpWkVnYeQizkivUdBOv4=; b=FZ8g0caCCvL9tbTYXyx/kqNAwgW43H0MUCuQ P10tBGwgcibPNhRjE42QgGsvhIWyJiWjxbKw61NH9Bx5XSEBB0VwD52FD3Z/6NRe IWnBU9M2/ylSsPj8GP4gkGGWLYPK+Kk/8F1D3ZGekcCmlZ7lvRL1oDqGKn7VAVe+ gwXNcR0nd2h63EbcC0a2k6NFc4Nl1WszpNTK5Ez8HudASdF1WVUHVg5IqJRZgkd6 EJywH7B/BayjE48p2ZQL1UVjwq6OZ5oiln//m9gF4QwGaxWlqSmJtHq2rasVU1Tu IfmrU1zbSxQDUK0e/df+vlQ4XDp78MkjrnsEhW21LOtmPoVpbA== From: =?iso-8859-2?Q?Juraj_Linke=B9?= To: Thomas Monjalon , Bruce Richardson , Honnappa Nagarahalli CC: "david.marchand@redhat.com" , "ronan.randles@intel.com" , "ohilyard@iol.unh.edu" , "lijuan.tu@intel.com" , "dev@dpdk.org" Subject: RE: [PATCH v4 1/9] dts: add project tools config Thread-Topic: [PATCH v4 1/9] dts: add project tools config Thread-Index: AQHYoznHZDjGewL4zEWnwy2VfNS9aq3UQnWAgAL48LCAAANvgIAAJxXwgAZ9s4CAAO+EAIAAWH/A Date: Wed, 14 Sep 2022 12:55:21 +0000 Message-ID: References: <20220728100044.1318484-1-juraj.linkes@pantheon.tech> <2599934.X9hSmTKtgW@thomas> In-Reply-To: <2599934.X9hSmTKtgW@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.101.4.10] Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Thomas Monjalon > Sent: Wednesday, September 14, 2022 11:37 AM > To: Juraj Linke=B9 ; Bruce Richardson > ; Honnappa Nagarahalli > > Cc: david.marchand@redhat.com; ronan.randles@intel.com; > ohilyard@iol.unh.edu; lijuan.tu@intel.com; dev@dpdk.org > Subject: Re: [PATCH v4 1/9] dts: add project tools config >=20 > 13/09/2022 21:19, Honnappa Nagarahalli: > > > > > > > --- /dev/null > > > > > > > +++ b/dts/.editorconfig > > > > > > > @@ -0,0 +1,7 @@ > > > > > > > +# SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2022 > > > > > > > +PANTHEON.tech s.r.o. > > > > > > > +# See https://editorconfig.org/ for syntax reference. > > > > > > > +# > > > > > > > + > > > > > > > +[*.py] > > > > > > > +max_line_length =3D 88 > > > > > > > > > > > > It seems strange to have two different editorconfig settings > > > > > > in DPDK. Is there a reason that: > > > > > > a) we can't use 79, the current DPDK default and recommended le= ngth > by > > > > > > pycodestyle? Or alternatively: > > > > > > b) change all of DPDK to use the 88 setting? > > > > > > > > > > > > Also, 88 seems an unusual number. How was it chosen/arrived at? > > > > > > > > > > > > > > > > The commit message contains a link to Black's documentation > > > > > where they > > > > explain it: > > > > > https://black.readthedocs.io/en/stable/the_black_code_style/curr > > > > > ent_ > > > > > st > > > > > yle.html#line-length > > > > > > > > > > Let me know what you think about it. I think it's reasonable. > > > > > I'll move the > > > > config to the top level .editorconfig file. > > > > > > > > > > > > > I have no objection to moving this to the top level, but others > > > > may like to keep our python style as standard. Realistically I see = three > choices here: > > > > > > > > 1. Force DTS to conform to existing DPDK python style of 79 > > > > characters 2. Allow DTS to use 88 chars but the rest of DPDK to > > > > keep with 79 chars 3. Allow all of DPDK to use 88 chars. > > > > > > > > Of the 3, I like relaxing the 79/80 char limit so #3 seems best to > > > > me as you suggest. However, I'd wait a few days for a desenting > > > > opinion before I'd do a new patchset revision. :-) > > +1 for option #3, it seems reasonable >=20 > In .editorconfig, we have this default: > max_line_length =3D 100 > It is also documented in our guide. >=20 > For Python we have this exception: > [*.py] > indent_style =3D space > indent_size =3D 4 > max_line_length =3D 79 >=20 > I'm OK to increase it to 88 as it does not exceed the default. > In any case, it should be documented in the style guide. >=20 Where is the best place to document it? I'm thinking of adding a DTS Coding= Style into contributor's guidelines, right after DPDK Coding Style. Or do = we want to have separate DTS docs? >=20 >=20