From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1FC9CA0C41; Wed, 17 Nov 2021 13:26:48 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D08C241104; Wed, 17 Nov 2021 13:26:47 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id EA13E407FF for ; Wed, 17 Nov 2021 13:26:44 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10170"; a="221151361" X-IronPort-AV: E=Sophos;i="5.87,241,1631602800"; d="scan'208";a="221151361" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2021 04:26:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,241,1631602800"; d="scan'208";a="549118157" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga008.fm.intel.com with ESMTP; 17 Nov 2021 04:26:43 -0800 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 17 Nov 2021 04:26:43 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 17 Nov 2021 04:26:42 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 17 Nov 2021 04:26:42 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 17 Nov 2021 04:26:42 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RDGGCiT26j8/wGzNWaQcgZwKtQN5vda4uCqxRVbRr/9AOi1SUO08SBGD56QM0m99TNPztOMwHLGZj65VYk2AOcatT5jFloJOQyg1AB3u1KUPAPED8hhe4Os569rFpclzd2WLlK1Bd3bKyXPWPLWRDnni30BffY/rtqb6qwPkzxVh5sPmQorWdLSqrOshPTogBcFjVhmbYUymQCMg+8UEYTqHSLwbNBJPTk+LOLKXTJOn6dnHfvktrUjwL27ql0GHNoo/kbbxC6gyP93x2r1C+Tuo9GYcdhitUxUpMLcE284GNzvBCSZsdJKt3oU++bX7vPpyOtCSkQp5etp78cGnmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8M47SigGrF1Ns0GAtTyBWlIQ1n2bvjKTgTa1BI041ug=; b=ByZiPE6jUPtvRIUW3LFttwyJ15aj0q//MLQ1bX1FtgrzEKgOaLyQd2OxhegM0RJxwRVKv6Y/ccpEf+DJp93kZ1jI9f9vLlAqXUOWNtC4QZmqLzd+lH07tK6RXdkYBGDrdYhCZMWpE93Rbz6Lx7orCgw4I11xpcAzpDTjnUp/pVeNaOkYbc6JZVYiWNKGvbSPLmITpZSN/C1jtla6SCa6RG6NWAEwesa1keeOuPaAtxlkOxJdvit/Wpo0cexv5YUcDmPczqPJKxB8KvcoOKUygmdMj4TATesy1FM0zWuintE01Hj2CtlgY7OgLJnm5Ix2y9oCYeNeVz+PsJB2kv0n9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8M47SigGrF1Ns0GAtTyBWlIQ1n2bvjKTgTa1BI041ug=; b=B6SBavIBvY+cHhF2F4JALHCUe1Iqy0MxbsgMkDxS8zkk/ngH+IK8dDm2iQUpgZvuVh6I2xYntCWmt+hoM57fruvp8ZiXtmcWwWfuhCsnLyXoSoDk8+FzX9D2XniTib42hVETvdUBkZp5NML3ZybjDPHZrtd0D+sbe2i7A8zsHPE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4775.namprd11.prod.outlook.com (2603:10b6:510:34::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.16; Wed, 17 Nov 2021 12:26:41 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c%5]) with mapi id 15.20.4690.028; Wed, 17 Nov 2021 12:26:41 +0000 Message-ID: Date: Wed, 17 Nov 2021 12:26:35 +0000 Subject: Re: [PATCH] app/testpmd: fix tunnel offload validation Content-Language: en-US To: Slava Ovsiienko , Gregory Etelson , "dev@dpdk.org" , Ori Kam CC: Matan Azrad , Raslan Darawsheh , NBU-Contact-Thomas Monjalon References: <20211102122421.4190-1-getelson@nvidia.com> <6725b879-c2fd-3902-eee0-2b5ea284562b@intel.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU2PR04CA0035.eurprd04.prod.outlook.com (2603:10a6:10:234::10) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DU2PR04CA0035.eurprd04.prod.outlook.com (2603:10a6:10:234::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.26 via Frontend Transport; Wed, 17 Nov 2021 12:26:39 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 35ee3064-3b94-4be3-33a7-08d9a9c58267 X-MS-TrafficTypeDiagnostic: PH0PR11MB4775: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wix8eBJ01fVMTN6f3LZf7G5gbU0n0JUiIxywhJQiZSByfBPqC4BAmIkJK3CBv8mevl3LW7ehHmyIHlZY5p5eRW4u6kBbZqkkPrBVlJO5LmrHto+SdCt10uaclgozP6iNilOAcWodc2CPMcIl3pUtSsW+Amjz0DM8KrrrMycX7dQqOEpQEsthBpa3vB7XdAamTLntX1UC2ScOsU9HIEitMLYO1IHT0nw8sirQI+ly1dVUJ4nypni2UZ4un2JTYiJWIlDnQ4tyP+oj9A1x2EDs+uTeTmHz+zrGxNoWwsDBkWQnwfuP1cWf6e5ZSI9XfvX26JLaAlvrwQPldAJim7LhM9oB+uUTaJsdvQoINsVdChLb3W3GHThID1IuiHE9zvTSfqy4Gc9jiJXxk8mvF9qO/o2KgVhMUUGN0Tsrowbm44dKHQD7eOUfb3cVErzqs+k/44MkcGgrWpAO/5+SsDhHmOFKrPVqK2uoYsuqS1qTncn9kGo7jDIW55FrwxOB7ABG5GeDSwh06moUUT6GweXCDYvgXwmm/oOVLEBLbWuStp2QaDfuakr6m4ZC4QtFw7af5yY/qyteBIze/EhMl8QLzfge9l4ZoLqzGQspmE3mmQ4LxHgFInrbITBf+X207NROckTTjfgn1dCh145iD0w8gJhs8mP2kGVIo9JbbKmoKw5allZzUeL1mKzMkNPdXhuW3E1Sy70Jh8revtkK0j5HTA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(16576012)(6666004)(36756003)(2906002)(31686004)(83380400001)(186003)(6486002)(8676002)(4326008)(38100700002)(26005)(956004)(508600001)(53546011)(31696002)(82960400001)(44832011)(8936002)(2616005)(316002)(110136005)(66946007)(66556008)(66476007)(86362001)(54906003)(5660300002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d3NBSSt0OWhQSEtrcXJISHFwNVRRT1FKRWoybGMwNS9ZbWk0V2hwWnRkWTVU?= =?utf-8?B?MTZXT0hnbFh5c1RLR2h6ekJqNC93TWtDMmg1QmhBRHZGRFBxaHJtdXFyNjZa?= =?utf-8?B?MVNkNUsxZFN2c0FGY2tTbG1FTUp2ejJTSEoydjB3eWRmaGxBUDVvVGNuSHl6?= =?utf-8?B?cjJ5akZJN2xpWkszcXlzaFlaYVJSYktTSkRmVVA2bXZ5SS9CTUF0emRxUGVz?= =?utf-8?B?U3ZqUGQxbXlrMFB4OXRMUEFXSUhwM2NSRHFDb2I2b3dJWVRhTml4ZE01M01O?= =?utf-8?B?dm9CaU9oMDBiZnE0MVR5WndYWHRBcDRJNjRsRmVmWm40UCtMbnk4S2QzclRO?= =?utf-8?B?Tjg0d0hPRE9EY1J5RXFscU1BZ2NDbm4rTjhkT3cyVElFTUxzdUIyVTJXQlBR?= =?utf-8?B?b0VaMy9iMFdJVm91dEVRZkVSWmtkL0ZkdXlralVnMlhMNmZWdHBvQ2NRUUtL?= =?utf-8?B?Q0ZFcWxRYjlDbUtpclk3U0RvbnRqQ2lkbXFRa1V4dm1sMFl0bHhidmo3aEFS?= =?utf-8?B?dUdZUWRmR1lLL2RUalNSRm5STlFWLzAyNCtvaDJUcSs4bFFsN212WkR3dlVy?= =?utf-8?B?V0RhWTdMeEo2Ynl2TlIxdmJIMXkyaG14Z2Y5L29hNmtnZW0vL2VUTnBma0ZE?= =?utf-8?B?MDJWUzRyU0hJZXVPTXJEZksvcmZOZ0pqV0V1ajdIUWJTQ3hoTlNqNkpBMFZN?= =?utf-8?B?RWU4L0s5VE9UUXRONVlFa3gyODZQYjV3K2M2d0d1dnNGNUZieG9MM2ROcnBL?= =?utf-8?B?Tit2OU1LMmREUmFvMktvYWJoUzhzKzc2cXd3VmYvTDMvU3JwQUZ1c1RXTFNE?= =?utf-8?B?QkhyRzJoeGN2WUVhbm1nUFBnZDFGMzNiZGxEMS9nZU9iQmlVNko3S2hUcitY?= =?utf-8?B?MllublBOeHdYdkV2eXdSaVlGdnVHSEthaGNhcE9Vb0U5QzI1aXBsbC8yOGI4?= =?utf-8?B?dzU0WStVOGQyajAxTHpRUS9uVXY3bWorcTRLTzladG11VmhVNmlWN3dMcUFa?= =?utf-8?B?UDlOWnUzdENIeDdBT2V6NnI2SFJCS293cS9teFl1TkZMYUFISHdlS01SUFFE?= =?utf-8?B?UTdFbS9sZmhJalUyeUVrbEZDUDVzSkdvdzZFcldlZ1RGVm5GaktmNGY3MlZZ?= =?utf-8?B?WHNaenp3NzlkVXlvRXd4ZjdndnVXK09VUG1MRW12d2RBbStMZ1BJMWsyZklV?= =?utf-8?B?MDNsQnJtSVFHN2dxdTBOeGRLWEE5cWtwVjc3VEVPSWFmWFUrdVhPM2MxMmE4?= =?utf-8?B?c0xwa3EzbGdBS0hUbEdUTGM3b3h3TjFzNitFQXVGMWYyTzcxMjhHYnBMOHhP?= =?utf-8?B?NWZXWVpiRmFiQWE5c05PRzVVN085K2FFMTdSdlcwNzRkUjVTOFZkRHd2Wk4w?= =?utf-8?B?c3lPdWZoUllmOGdaOUdkZTJnUVhPTldUeGlsLzNmSmVIY3VuMXBGWU5xNDhQ?= =?utf-8?B?SXdad0pHNmpjMlhGR0RzTDQ5Ukc5WGZvQzZicnlKR2xOcEhYbnVwZHRHOGN3?= =?utf-8?B?UlUxOHVaSVI5M2p4ZGR1Nld6WGxMOEhGa0ZYMGxhTGZyWDFMTHcza2N3V09k?= =?utf-8?B?Q0poK2lGUTJ2UHZSaUk5THVSNDhjbkR0T3FnanZrRS91ZzV6VHBXZWdNUjk4?= =?utf-8?B?cStKTFhTRGZYekRlSFVFRmthNGZaSnp6eEpRclRCNnVTUFZ4OWZ5UnV6UUIx?= =?utf-8?B?RjJLb25FY3RsQWdlQzVmVmxUOGEwYjg5OWlwWU8rT2x2T09JL2NUTDRMSzk5?= =?utf-8?B?NWpLNmtLMXhsbE1hN0V2d1VwSWMyWjJXR2tCazFMRm13b1FvSXJIWTNMd09P?= =?utf-8?B?aENhUlRIejB3bERBcnlyanJpbWhoVjc2Qm00U2k0SW9kcXoyMTZ3ckRBNFJy?= =?utf-8?B?VjEvSHliSVpsTFU3NzhSL3B4T0Zidm5DRi9vRjhPNVFQdjBiNUxPNndteWRQ?= =?utf-8?B?SURnUElrNjE2R05oRVVVZVRPRHAzekZoTUxQQVpmUHBTYVdBVzN1TlFqdHpS?= =?utf-8?B?YnJqL203UFhQaTVJVXlmZmtOMzJJSEk4M0owd3RkQXRHTzZZTFl0ck12a3RB?= =?utf-8?B?bGhxN0ZnOVhOTFB2L0FKSm43RjYxdnptUXExdERzYWliSFI0S2M2dWJwaWdp?= =?utf-8?B?LzVyc3NVK0V4Y3daejhzK3lTa2QwdWUraWhEU29nRW15aW9wOUIzWUxPNVhU?= =?utf-8?Q?RFG06v+U9DBxQ+UrlLeaiug=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 35ee3064-3b94-4be3-33a7-08d9a9c58267 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2021 12:26:41.5220 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wSF0dr+YkRFtMgauCK78g7klmyQ5U+ptENi7Svl8hEFqzwBmF3P/sIv0YDax+q+dpjVYv+5ngqRJC0F2iyDViA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4775 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/17/2021 10:27 AM, Slava Ovsiienko wrote: >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Wednesday, November 17, 2021 12:10 >> To: Gregory Etelson ; dev@dpdk.org; Ori Kam >> ; Slava Ovsiienko >> Cc: Matan Azrad ; Raslan Darawsheh >> ; NBU-Contact-Thomas Monjalon >> >> Subject: Re: [PATCH] app/testpmd: fix tunnel offload validation >> >> On 11/17/2021 8:57 AM, Gregory Etelson wrote: >>> Hello Ferruh, >>> >>> Can you estimate when this patch will be merged into 21.11 ? >>> >> >> Hi Gregory, >> >> It is not merged because it is missing review. >> >> Ori, Slava, can you please help with the review? >> >> >>> Thank you. >>> >>> Regards, >>> Gregory >>> >>>> -----Original Message----- >>>> From: Gregory Etelson >>>> Sent: Tuesday, November 2, 2021 14:24 >>>> To: dev@dpdk.org; Gregory Etelson >>>> >>>> Cc: Matan Azrad ; Raslan Darawsheh >>>> ; stable@dpdk.org; Xiaoyun Li >>>> >>>> Subject: [PATCH] app/testpmd: fix tunnel offload validation >>>> >>>> Tunnel offload API allows application to restore packet to its >>>> original form if chain of flows missed after DECAP action. >>>> The main idea of the tunnel offload API was to query port PMD to >>>> provide flow elements - actions or items. >>>> Flow elements supplied by PMD are merged with original flow rule >>>> elements provided by testpmd operator to create a new flow rule, >>>> optimal for PMD, to implement the tunnel offload API. >>>> That flow rule transformation is hidden form testpmd operator and >>>> uses internal testpmd resources. >>>> >>>> Current testpmd did not release tunnel offload resources if flow rule >>>> validation failed. >>>> >>>> The patch always releases tunnel offload resources after flow rule >>>> validation returns. >>>> >>>> Cc: stable@dpdk.org >>>> >>>> Fixes: 1b9f274623b8 ("app/testpmd: add commands for tunnel offload") >>>> >>>> Signed-off-by: Gregory Etelson >>>> > Reviewed-by: Viacheslav Ovsiienko > > Applied to dpdk-next-net/main, thanks.