From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B1C0EA0560; Tue, 18 Oct 2022 14:39:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 57BEB40395; Tue, 18 Oct 2022 14:39:10 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2089.outbound.protection.outlook.com [40.107.237.89]) by mails.dpdk.org (Postfix) with ESMTP id 397E04021E for ; Tue, 18 Oct 2022 14:39:09 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RW+lee/H2S46R8RiC1w73W7J9k04Tw0NUqaT8IHh82+eipH37wXE9M97kF79q/vkd6Sv8e2/WXUDyoQ3qBaToNVPVGSKUcxIXtwGfiEvZpiYn/afLDLRjSSNNmIWpwN/4SxNIOQEzH8ZjJtaYjKFurowSs9+8BlCfh/9ZRNqgTH6J407C9LOut8xpqHehUG15iEpQ7oftCLAYP4AahqrzjI6ldTGWqSSPenU/SnVhraXv6nhpW2zNQEknuWJkfO//iau4rtKImpwLKbSyxj0usTfAWlWNSdKl6PzHJv1BBbV4bxPxVkE0ttF8qFbfT45I0BakcdsUs+j534Bs+pujQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KCUMzvuf/1CsAhwO3FQp/eGHraRmIWZsaVRTkyFaqGM=; b=EfXfPhr91qixLbIzDvYevY+p/ngAU2WVtsQ+WouTd2Sp1+WVc8P+wsgliFAReUJmA/PRNKEFCZiqNoVRGf5WpdhidUSHigQ2R2FrdGyLiQhGJFouBQHjh9c3ma2GAFbFL3Z5m0zcoKcnGyc5Sh7Vh4KzkEvw0xTIt4OnQLriKyc2k7vKjXdFNaVkCpU9zhL+rIS9UEue5FikJX3J82jAltWnjqkQL0FG5GwzZWlnvVw8SgTRLwdc2gx9OxYzSFxpNOh6HPtRoEjusp32u5ChnjYuLL7j0uhH16diL8yNY0ihCD7WwG1XztAMOqxkfUSleBm2c8GoHgCVDAY/PCzwFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KCUMzvuf/1CsAhwO3FQp/eGHraRmIWZsaVRTkyFaqGM=; b=KP6je8TepAs92O79LftdHXgyrRt71hbg4J90euYyMxIZImr6zy/hWkFsMF54RqduN8b0ywI3/yzE3RjxabsNPzjlV5PQWxE3+GAVA5UQZZmo03+XPNte1j4hHq5EANFs5lsQ87aGPvvTMhUyfWv3tVeYYztyuT+7/B7JhqqfYDM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) by BN9PR12MB5147.namprd12.prod.outlook.com (2603:10b6:408:118::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.33; Tue, 18 Oct 2022 12:39:07 +0000 Received: from DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b9fd:e732:4585:6b25]) by DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b9fd:e732:4585:6b25%7]) with mapi id 15.20.5723.033; Tue, 18 Oct 2022 12:39:07 +0000 Message-ID: Date: Tue, 18 Oct 2022 13:39:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH v4 01/25] net/nfp: fix the requirement of cpp bridge service Content-Language: en-US To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com References: <1666092434-10357-1-git-send-email-chaoyong.he@corigine.com> <1666092434-10357-2-git-send-email-chaoyong.he@corigine.com> From: Ferruh Yigit In-Reply-To: <1666092434-10357-2-git-send-email-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0526.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:2c5::12) To DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB4297:EE_|BN9PR12MB5147:EE_ X-MS-Office365-Filtering-Correlation-Id: 606f72c6-3d40-4983-2155-08dab105bf4d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: acN9hMOcZFALKC5poTv6AXqgzrAcwc/5rTJuoV1E2zLO9d44OLfTvwNCD6DKPEQI/PXZ2VU1zB97Edd3Hp1jmkLUuXzh406IHaNymYaM30uMeNst8PZNgjfnhWGOYL4i1d2p9x/PheJJ5TjlDdgkqEsCRh1MUZItzF5r7MKyvA/E0iW9c/ZgFcCHi9/1DnfCnWVB88ktFBGGMOWdDveSwpZDzkReJzXXmOYjsdASDntzfA/ZEc0/iQaYd424w438CA23WbX0wJ1IuX8LpyW8FOCfoG7otet3hYpabVCWweWn/ip36BGLECQvPAQ+NCHLWj4ZjyeWwZ+iWkwhVyF5L9DjWr72xkYY9U2H2PHa98HktW+avAEkqu74MAmXWVtDUIsp9qr8SXqdsb/M8tuwz8cfkVIRkAqzt6XtMW29Asl/gOpHH7g1zqaXzhcndpH2tYjBRONwknNcyrJDe1a8kL6C9+Tf+jRZRCWSHvGHVslTZkAcY3QTYBjotbToOCsAJDlsoc5vf9u6PlbT059mnc7B96uA1zwrAxCrdKBU1mJuYmXh7WSxUGVP+Huu6ElL90CaaQYfUa6qtwbpyKaNBp+UCC3m2LJtdNoMnLzKq/kn/Fp03Qb/ypi/JFV03JBThQd7nE1yygGqVpBGvGZ8o9KzLa5Pn3iQdaRXRSIH1cq7rKvZ+f/OF55Ym4+eNXOAr05LVE61vRagxA0ddY6urMdLHZrmzXM9d2HxoTgVJSe9MethA2JqbJQ8HNGjn2LD2JBJO8qF0W71Z/rzCRcDzDo9B8ptyXsb/bVA/0OIXj0= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB4297.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(136003)(376002)(346002)(366004)(396003)(39860400002)(451199015)(31696002)(36756003)(86362001)(31686004)(38100700002)(2906002)(83380400001)(5660300002)(44832011)(6506007)(53546011)(6512007)(6666004)(2616005)(186003)(26005)(6486002)(8936002)(316002)(478600001)(4326008)(66556008)(66476007)(8676002)(66946007)(41300700001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dDQwa3RHTWw0UGZXbUFHV3dSdFhaRW42elhjeWpaRVVtSU1aNVZIdXRNbVJ1?= =?utf-8?B?ZlZyUklhSHI1czZPV1BPbGs4NXdCMWtiY2dCd1h4UmFPS0U3WHMxcEdjODk1?= =?utf-8?B?SmhDL0xiakFKZkt2M2NzU0lVaHI4ZFNyZ0wyZkNXZllXRmxiRnptLzRYa3Bu?= =?utf-8?B?d2VlalQ0QXRqZ3FHNmR5U0FZU3o2M2dDUitaZDlKeHpCditVNndCb3VKQ1ls?= =?utf-8?B?Y0c4UnBPU1F5ZDhNQWwvZEdMYkVHT0ppQmpHOFZ4N2tnYXhRUE5qOUJ2SThz?= =?utf-8?B?RnBGZUpTbFZXeVoyb1VxVitjekM2K3NBNXpnSGZMTkhiWGo3clV2LzdnSE5V?= =?utf-8?B?d2twUkczZmVFTXhYdGR2aGhRb3NkcFMreWgzRFRnUWtPSk1QWWZOK3dmb29Y?= =?utf-8?B?VzA0NUZ1S29nZGp0Ulh2eFNrWFQ5TmNJL01JcTBkSHdib29nbFZ0Z2VvNUli?= =?utf-8?B?dDNYMEVQNHdIRmRNbzdBWUVxZ21NYjRVNlVRQm9CcFV2K2JZOWVKNUw5Qnk5?= =?utf-8?B?Z29kS3RqOFY4VHNEbTFhb2R6YW81TFphaGUzSVZJcUFrdmhxNkhaVG0vSmpW?= =?utf-8?B?ejV0ZVVuZk1uNk5MdjBXdVhxc01FdFI5VGtGb1hpTHI2eGM2YmZYeXpmUE8v?= =?utf-8?B?bWJveVU3TytsVXc0c2JNblNLdEVoWnVvc0NGaW0zNWp5eEhhWkhoQnFiL0pz?= =?utf-8?B?ZnpEY1ArZlJJS0hpelVwamYxbi8vY2VRSGlGYVcrZy9mWW1jcnBjQzlUb1RZ?= =?utf-8?B?TUNyZ0hjWXNLUU1vQXRhWGUvRmZLT3cxTjByNTVQeVlrNXV6bDB4WFg1d0Nm?= =?utf-8?B?Z2s4TVI5dHdPaC9rdnVwd05hNDZRNFJ6SnZVanQ2R05XTGhyZkpMcDB3TENk?= =?utf-8?B?V0hVVHNHeHFaRjZkQXc0eEQ0ajF2TnNFcWQ0NUNlcTZoRzB4ckVVaThJTW5O?= =?utf-8?B?SVpGWGJCR2FLYVVsR3kwZlk0SmcwSy9CQXFSYkxLdHd2MXh4YS9wTHkrWjVI?= =?utf-8?B?cThnK1dxZklmdG9rTXBnWTFvVXBZejlrZWQwSXlVaUdhclFuemdYalNMdlZz?= =?utf-8?B?VGtWRGtLMFd5TlE3SWpQMmRxSDlsdTZuOTRraVo3ckM4U0NqQnViR0lKT0VP?= =?utf-8?B?MWxWZE0xcVMzcWVjcFNkcmtyWlFnSjBqS0hoaTg5S25aMVhnS0p3Tkp6MGdr?= =?utf-8?B?QkYrUkVKQ3dnQkZlL1NYRVhZei9ROHRCc0FQY3E4cWVmU01GWUF1SGxwN2M4?= =?utf-8?B?SndlclpaWHYzcTVzb1UrNlU1VHpzWnVqSXdFdFByc1M3YVVPNHgwaDFYR1cv?= =?utf-8?B?K0o2WXRCdWplUTJ3bzJrUXM2U25wQWtjVW1WUkNWcTVONCtNbFZndkFPeGVw?= =?utf-8?B?V3gxMXppOWtGZ24wRzZKL2lTVUZucVYwTVZ1ZW81S1BtNjFUZEg5cnRmTVo1?= =?utf-8?B?ZUx1d3dCbVpBZnZXSUZMSG4vMmt1RWNkYVR3TDZsblN3Y3kzNDFVL2FJZ2pC?= =?utf-8?B?blNiUmdIbkRWYkNhQ3M2OUxsQklhMXFzdk5JM1hQS1E3Y2dQYkFaVC80ZXYv?= =?utf-8?B?bUE1eTRsc2kveW13cGhOSEpOdllxclJHR1R5ampYN1RXTzRSZS9JY2RiMWJl?= =?utf-8?B?SEtYSjJPeGhubGdXTk0yVlFIQTNSbUlvTUtmNXg5SkJEWFRVQ1lybWZGRjR2?= =?utf-8?B?RjAvWUhqRjczSzlZZmtDaUMreW1obTYvUFlKWnRxbll6cEprQVlhQURsMVYz?= =?utf-8?B?WDN0OGVacVpTNk1abHFTVFJYMnFjQi8xRWhJRW9QNFFoY3N5Q1FlMG53ZHBu?= =?utf-8?B?SmhHMk03WHFpdkxEQlVhTjIvaWdUMTdZaVJuVjdPT1ZmdWl1WGVIWEN5M2pD?= =?utf-8?B?dDl3RWtYSXdWKzJ3SU1aZGx3T2Vqc01Zajg4VFpyY3NYRWx3NFRyZ0Y4Nzl4?= =?utf-8?B?QkpVb3lPcTVZOC9uSnB2Kys4QWUwM3QxWURJNWp3c3dBenJZa2FzNVVuaFlJ?= =?utf-8?B?SjJhcHpTRkJVZy8rVWJJcTZVRWN0TjZhaXlnU3UrNXlvMnpRc1RFZnlkNmNm?= =?utf-8?B?OFBOcW1lYlVHQ0FROW9XV2dSTkFabTJYWmNDRDJMR1czRUNXUXFKN21nTFlq?= =?utf-8?Q?u+nIMBe6gAocNth9ng1qzvct4?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 606f72c6-3d40-4983-2155-08dab105bf4d X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4297.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2022 12:39:07.0677 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kFRoq7ik6UY5P1cMu6NHYwv+IdKYvwIawpM0OUtSoICR2PWpIn68ulzwoVCTm96p X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5147 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/18/2022 12:26 PM, Chaoyong He wrote: > The cpp bridge service is needed for some debug tools, and should be > optional, so remove the mandatory requirement of service lcore parameter. > I assume cpp is 'Command Push Pull', if so please describe it in the commit log (unless it is a common abbreviation), like "The CPP (Command Pull Push) bridge ..." Also in patch title please use abbreviations as upper case, like: net/nfp: fix CPP bridge service requirement > Fixes: b18804219537 ("net/nfp: add initial flower firmware support") > > Signed-off-by: Chaoyong He > --- > drivers/net/nfp/nfp_ethdev.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c > index f11a1b6..b105edb 100644 > --- a/drivers/net/nfp/nfp_ethdev.c > +++ b/drivers/net/nfp/nfp_ethdev.c > @@ -1066,11 +1066,8 @@ > > /* register the CPP bridge service here for primary use */ > ret = nfp_enable_cpp_service(pf_dev->cpp); > - if (ret != 0) { > - PMD_INIT_LOG(ERR, "Enable cpp service failed."); > - ret = -EINVAL; > - goto hwqueues_cleanup; > - } > + if (ret != 0) > + PMD_INIT_LOG(INFO, "Enable cpp service failed.");