From: "Wei Hu (Xavier)" <huwei013@chinasoftinc.com>
To: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com>
Cc: <dev@dpdk.org>, Wei Hu <xavier.huwei@huawei.com>
Subject: Re: [dpdk-dev] [PATCH] ethdev: check if queue setupped in queue-related APIs
Date: Mon, 12 Oct 2020 11:22:35 +0800 [thread overview]
Message-ID: <a5c61bc2-455e-2c9d-0722-8c34dc0e5efd@chinasoftinc.com> (raw)
In-Reply-To: <CAH-L+nPyrC9gcUWYaFydr-teThpN=udvUAFnkSHgti9TZuG=Rw@mail.gmail.com>
Hi, Kalesh Anakkur Purayil
On 2020/10/11 0:38, Kalesh Anakkur Purayil wrote:
>
>
> On Sat, Oct 10, 2020 at 12:42 PM Wei Hu (Xavier)
> <huwei013@chinasoftinc.com <mailto:huwei013@chinasoftinc.com>> wrote:
>
> From: Chengchang Tang <tangchengchang@huawei.com
> <mailto:tangchengchang@huawei.com>>
>
> This patch adds checking whether the related Tx or Rx queue has been
> setupped in the queue-related API functions to avoid illegal address
> access. And validity check of the queue_id is also added in the API
> functions rte_eth_dev_rx_intr_enable and rte_eth_dev_rx_intr_disable.
>
> Signed-off-by: Chengchang Tang <tangchengchang@huawei.com
> <mailto:tangchengchang@huawei.com>>
> Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com
> <mailto:xavier.huwei@huawei.com>>
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com
> <mailto:fengchengwen@huawei.com>>
> ---
> lib/librte_ethdev/rte_ethdev.c | 56
> ++++++++++++++++++++++++++++++++++++++++++
> lib/librte_ethdev/rte_ethdev.h | 3 ++-
> 2 files changed, 58 insertions(+), 1 deletion(-)
>
> diff --git a/lib/librte_ethdev/rte_ethdev.c
> b/lib/librte_ethdev/rte_ethdev.c
> index 892c246..31a8eb3 100644
> --- a/lib/librte_ethdev/rte_ethdev.c
> +++ b/lib/librte_ethdev/rte_ethdev.c
> @@ -897,6 +897,13 @@ rte_eth_dev_rx_queue_start(uint16_t port_id,
> uint16_t rx_queue_id)
> return -EINVAL;
> }
>
> + if (dev->data->rx_queues[rx_queue_id] == NULL) {
> + RTE_ETHDEV_LOG(ERR, "Rx queue %"PRIu16" of device
> with port_id=%"
> + PRIu16" has not been setupped\n",
> + rx_queue_id, port_id);
> + return -EINVAL;
> + }
> +
>
>
> Hi Xavier,
>
> How about having two common functions which validate RXQ/TXQ ids and
> whether it has been set up or not like below. This helps avoiding lot
> of duplicate code:
>
> static inline int
> rte_eth_dev_validate_rx_queue(uint16_t port_id, uint16_t rx_queue_id)
> {
> struct rte_eth_dev *dev;
>
> RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -EINVAL);
>
> dev = &rte_eth_devices[port_id];
>
> if (rx_queue_id >= dev->data->nb_rx_queues) {
> RTE_ETHDEV_LOG(ERR, "Invalid RX queue_id=%u\n",
> rx_queue_id);
> return -EINVAL;
> }
>
> if (dev->data->rx_queues[rx_queue_id] == NULL) {
> RTE_ETHDEV_LOG(ERR,
> "Queue %u of device with port_id=%u has
> not been setup\n",
> rx_queue_id, port_id);
> return -EINVAL;
> }
>
> return 0;
> }
>
I fixed it in V2.
Thanks, xavier
> Regards,
> Kalesh
>
> --
> 2.9.5
>
>
>
> --
> Regards,
> Kalesh A P
next prev parent reply other threads:[~2020-10-12 3:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-10 7:12 Wei Hu (Xavier)
2020-10-10 15:24 ` Stephen Hemminger
2020-10-12 3:21 ` Wei Hu (Xavier)
2020-10-10 16:38 ` Kalesh Anakkur Purayil
2020-10-12 3:22 ` Wei Hu (Xavier) [this message]
2020-10-12 3:19 ` [dpdk-dev] [PATCH v2] " Wei Hu (Xavier)
2020-10-12 6:29 ` Stephen Hemminger
2020-10-12 7:32 ` [dpdk-dev] [PATCH v3] " Wei Hu (Xavier)
2020-10-12 15:12 ` Ferruh Yigit
2020-10-12 15:15 ` Stephen Hemminger
2020-10-13 2:41 ` [dpdk-dev] [PATCH v4] ethdev: check if queue setup " Wei Hu (Xavier)
2020-10-13 4:28 ` Kalesh Anakkur Purayil
2020-10-13 8:08 ` Andrew Rybchenko
2020-10-13 11:50 ` [dpdk-dev] [PATCH v5 0/3] check queue id " Wei Hu (Xavier)
2020-10-13 11:50 ` [dpdk-dev] [PATCH v5 1/3] ethdev: extract checking queue id into common functions Wei Hu (Xavier)
2020-10-13 12:49 ` Andrew Rybchenko
2020-10-13 11:50 ` [dpdk-dev] [PATCH v5 2/3] ethdev: check if queue setup in queue-related APIs Wei Hu (Xavier)
2020-10-13 11:50 ` [dpdk-dev] [PATCH v5 3/3] ethdev: check queue id in Rx interrupt control routine Wei Hu (Xavier)
2020-10-13 13:17 ` [dpdk-dev] [PATCH v5 0/3] check queue id in queue-related APIs Ferruh Yigit
2020-10-13 14:13 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5c61bc2-455e-2c9d-0722-8c34dc0e5efd@chinasoftinc.com \
--to=huwei013@chinasoftinc.com \
--cc=dev@dpdk.org \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=xavier.huwei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).