From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f195.google.com (mail-wr0-f195.google.com [209.85.128.195]) by dpdk.org (Postfix) with ESMTP id 66E641BB57 for ; Fri, 13 Apr 2018 16:33:52 +0200 (CEST) Received: by mail-wr0-f195.google.com with SMTP id o3so8698407wri.2 for ; Fri, 13 Apr 2018 07:33:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language; bh=QLvVkwpl6QmRDbDgGgNIInaeJYvXo//OD/VU3ToHACE=; b=AUYywnE83WF0uyQW6O3ya3gd0D6/+U8jAU57e6KecwIr5N1NJ4rLpAygb2AWl0+L4M 1w8r0w0YI2TfGDqDKvN1cNo8eEACN/VXCXl8YoOalCMx8od2Y3+tctpZ5XTSwqSHtScA VyMNp/m193oXaVzUKI+WNgyvydXttxXZbzoHGNTLbYSVmdzy269yxedwdX9b+SGDXBVS 6CIjn7frb/0iwmSZOF1dk6aw9tk0Im6NHki6YFzEvarxKHQxGd5lc+nMWNVwIBhZoKsw FfBUL1LHGpOikmUGnnlOpIfWhON10SsQWcn4DB7CaIEGV1ER3DurqoDXULODZTiFUa9j 8ysw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language; bh=QLvVkwpl6QmRDbDgGgNIInaeJYvXo//OD/VU3ToHACE=; b=AQ3qNh8WpGCY31fhFWIYBJ88KWZzuuSlL7K35XGcdFHXVILGuh7tPl63nFHF/3811C 3z6HNKtJtRinPC5z4zDivBFewHVlvBz4BvWYPgc/BGHG0aZFdYmVqkqf24czddarzuJP x0FfnY0ZHO77I8M+RzPsRbvixc2XInu4ckG8HYqZUAm+8LDRhXnQ4q92ACB67CteZwc5 KCrmnPA3v9KF381mAWwTNmWN8d51jNBOcLo4Cx6zLVdtidKY6jCgYWyt4AQmp/j223y5 lzjXPNE7ISv28sXx0Fyv82R8oETEmoPQa8gWNY77ggYL6PzR1J3n9Y+jkmVSXlgOhaTi GlgA== X-Gm-Message-State: ALQs6tBy8wp9B75r7EJ3xBD3kU2Urn0WojswJl1RMb1dL+r/geFGchOj gV6wF5vdkrOuzOEkwWUWYqD9XEg9 X-Google-Smtp-Source: AIpwx4/WlHjX2m9gI4IgpLz8z1qQYevh2XGUgbLSySRjH9MkpBKHVTsoZ6c6KrGuDeuVx0FALjgZaA== X-Received: by 10.28.125.88 with SMTP id y85mr99425wmc.95.1523630031930; Fri, 13 Apr 2018 07:33:51 -0700 (PDT) Received: from [10.16.0.123] (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id k35sm5183365wre.55.2018.04.13.07.33.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Apr 2018 07:33:51 -0700 (PDT) To: Yong Wang , "dev@dpdk.org" References: <20180328154349.24976-1-didier.pallard@6wind.com> From: Didier Pallard Message-ID: Date: Fri, 13 Apr 2018 16:33:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Language: fr Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 0/8] net/vmxnet3: fix offload issues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Apr 2018 14:33:52 -0000 Hi wang, We didn't make unitary tests with testpmd tools, the validation tests have been done using our DPDK application in the following topology: +------------------------------+ | +-----------+  +-----------+ | | | Linux VM1 |  | Linux VM2 | | | +------+----+  +----+------+ | |       VMware DvSwitch        | |     +--+------------+--+     | |     |  +---OVSbr0---+  |     | |     |                  |     | |     |  6WIND DPDK app  |     | |     +------------------+     | |      VMware ESXi 6.0/6.5     | +------------------------------+ All the available offloads are enabled in Linux VM 1 and 2. Iperf TCP traffic is started from Linux VM1 to Linux VM2. With ESXi 6.0 (vHW 11), we got the following numbers using 2 cores for our DPDK app: - with LRO enabled on the DPDK app ports: 21 Gbps - with LRO disabled on the DPDK app ports: 9 Gbps With ESXi 6.5 (vHW 13), we got the following numbers using 2 cores for our DPDK app: - with LRO enabled on the DPDK app ports: 40 Gbps - with LRO disabled on the DPDK app ports: 20 Gbps Didier /* */ On 04/13/2018 06:44 AM, Yong Wang wrote: > On 3/28/18, 8:44 AM, "dev on behalf of Didier Pallard" wrote: > > This patchset fixes several issues found in vmxnet3 driver > when enabling LRO offload support: > - Rx offload information are not correctly gathered in > multisegmented packets, leading to inconsistent > packet type and Rx offload bits in resulting mbuf > - MSS recovery from offload information is not done > thus LRO mbufs do not contain a correct tso_segsz value. > - MSS value is not propagated by the host on some > hypervisor versions (6.0 for example) > - If two small TCP segments are aggregated in a single > mbuf, an empty segment that only contains offload > information is appended to this segment, and is > propagated as is to the application. But if the application > sends back to the hypervisor a mbuf with an empty > segment, this mbuf is dropped by the hypervisor. > > Didier Pallard (8): > net: export IPv6 header extensions skip function > net/vmxnet3: return unknown IPv4 extension len ptype > net/vmxnet3: gather offload data on first and last segment > net/vmxnet3: fix Rx offload information in multiseg packets > net/vmxnet3: complete Rx offloads support > net/vmxnet3: guess mss if not provided in LRO mode > net/vmxnet3: ignore emtpy segments in reception > net/vmxnet3: skip empty segments in transmission > > drivers/net/vmxnet3/Makefile | 1 + > drivers/net/vmxnet3/base/vmxnet3_defs.h | 27 ++++- > drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 + > drivers/net/vmxnet3/vmxnet3_ethdev.h | 1 + > drivers/net/vmxnet3/vmxnet3_rxtx.c | 200 ++++++++++++++++++++++++++------ > lib/librte_net/Makefile | 1 + > lib/librte_net/rte_net.c | 21 ++-- > lib/librte_net/rte_net.h | 27 +++++ > lib/librte_net/rte_net_version.map | 1 + > 9 files changed, 238 insertions(+), 43 deletions(-) > > -- > 2.11.0 > > Didier, the changes look good overall. Can you describe how did you test this patch set as well as making sure no regression for non-lro case? >