From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 1ED8D2B91 for ; Thu, 5 Jan 2017 18:46:05 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP; 05 Jan 2017 09:46:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,322,1477983600"; d="scan'208";a="1108471426" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.38]) ([10.237.220.38]) by fmsmga002.fm.intel.com with ESMTP; 05 Jan 2017 09:46:03 -0800 To: Beilei Xing , jingjing.wu@intel.com, helin.zhang@intel.com References: <1483500187-124740-1-git-send-email-beilei.xing@intel.com> <1483631170-16681-1-git-send-email-beilei.xing@intel.com> Cc: dev@dpdk.org From: Ferruh Yigit Message-ID: Date: Thu, 5 Jan 2017 17:46:02 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <1483631170-16681-1-git-send-email-beilei.xing@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v6 00/17] net/i40e: consistent filter API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jan 2017 17:46:06 -0000 On 1/5/2017 3:45 PM, Beilei Xing wrote: > The patch set depends on Adrien's Generic flow API(rte_flow). > > The patches mainly finish following functions: > 1) Store and restore all kinds of filters. > 2) Parse all kinds of filters. > 3) Add flow validate function. > 4) Add flow create function. > 5) Add flow destroy function. > 6) Add flow flush function. > > v6 changes: > Change functions' name to be more readable. > Add comments for parse_pattern functions to list supported rules. > Add comments for parse_action functions to list supported actions. > Add ETHTYPE check when parsing ethertype pattern. > > v5 changes: > Change some local variable name. > Add removing i40e_flow_list during device unint. > Fix compile error when gcc compile option isn't '-O0'. > > v4 changes: > Change I40E_TCI_MASK with 0xFFFF to align with testpmd. > Modidy the stats show when restoring filters. > > v3 changes: > Set the related cause pointer to a non-NULL value when error happens. > Change return value when error happens. > Modify filter_del parameter with key. > Malloc filter after checking when delete a filter. > Delete meaningless initialization. > Add return value when there's error. > Change global variable definition. > Modify some function declaration. > > v2 changes: > Add i40e_flow.c, all flow ops are implemented in the file. > Change the whole implementation of all parse flow functions. > Update error info for all flow ops. > Add flow_list to store flows created. > > Beilei Xing (17): > net/i40e: store ethertype filter > net/i40e: store tunnel filter > net/i40e: store flow director filter > net/i40e: restore ethertype filter > net/i40e: restore tunnel filter > net/i40e: restore flow director filter > net/i40e: add flow validate function > net/i40e: parse flow director filter > net/i40e: parse tunnel filter > net/i40e: add flow create function > net/i40e: add flow destroy function > net/i40e: destroy ethertype filter > net/i40e: destroy tunnel filter > net/i40e: destroy flow directory filter > net/i40e: add flow flush function > net/i40e: flush ethertype filters > net/i40e: flush tunnel filters > Thanks Beilei, Overall looks good to me, just two more comments (as reply to relevant patches).