From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1F48CA09E4; Thu, 28 Jan 2021 17:57:25 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0A55D40682; Thu, 28 Jan 2021 17:57:25 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 0DA3B4067A for ; Thu, 28 Jan 2021 17:57:22 +0100 (CET) IronPort-SDR: gaUV/1wMaO7zo0237WJFfFjsh3FCgxjcpraCCna6wRGijkSwqQn+9BzQM76yTdY5+cctxJRVQL MnOmJED2AI0w== X-IronPort-AV: E=McAfee;i="6000,8403,9878"; a="159441128" X-IronPort-AV: E=Sophos;i="5.79,383,1602572400"; d="scan'208";a="159441128" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2021 08:57:21 -0800 IronPort-SDR: 8XP5FaOmprgxhcK0UjMc67WezzHJl9FGxicBL4MehRuSj8OZ3Zy6SSYjTbHW6V1cJ7trmk9a/0 7EKMb2Va0iGg== X-IronPort-AV: E=Sophos;i="5.79,383,1602572400"; d="scan'208";a="388897045" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.197.127]) ([10.213.197.127]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2021 08:57:19 -0800 To: Nalla Pradeep , Radha Mohan Chintakuntla , Veerasenareddy Burru Cc: jerinj@marvell.com, sburla@marvell.com, dev@dpdk.org References: <20210118093602.5449-1-pnalla@marvell.com> <20210128152220.214485-8-pnalla@marvell.com> From: Ferruh Yigit Message-ID: Date: Thu, 28 Jan 2021 16:57:17 +0000 MIME-Version: 1.0 In-Reply-To: <20210128152220.214485-8-pnalla@marvell.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v5 07/11] net/octeontx_ep: added tx queue setup and release X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/28/2021 3:22 PM, Nalla Pradeep wrote: > Transmit queue setup involves allocating memory for the command queue > considering tx descriptor count and initializing data structure > representing the queue. Transmit queue release function frees the > command queue. > > Signed-off-by: Nalla Pradeep <...> > @@ -275,12 +357,16 @@ struct otx_ep_device { > uint64_t tx_offloads; > }; > > +int otx_ep_setup_iqs(struct otx_ep_device *otx_ep, uint32_t iq_no, > + int num_descs, unsigned int socket_id); > +int otx_ep_delete_iqs(struct otx_ep_device *otx_ep, uint32_t iq_no); > + > int otx_ep_setup_oqs(struct otx_ep_device *otx_ep, int oq_no, int num_descs, > int desc_size, struct rte_mempool *mpool, > unsigned int socket_id); > int otx_ep_delete_oqs(struct otx_ep_device *otx_ep, uint32_t oq_no); > -#define OTX_EP_MAX_PKT_SZ 64000U > > +#define OTX_EP_MAX_PKT_SZ 64000U Can you please fix above where it is introduced at first place?