From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0079.outbound.protection.outlook.com [104.47.41.79]) by dpdk.org (Postfix) with ESMTP id A906F1B76A for ; Fri, 13 Oct 2017 17:45:24 +0200 (CEST) Received: from CY1PR03CA0021.namprd03.prod.outlook.com (10.174.128.31) by CO2PR03MB2357.namprd03.prod.outlook.com (10.166.93.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Fri, 13 Oct 2017 15:45:23 +0000 Received: from BN1AFFO11FD047.protection.gbl (2a01:111:f400:7c10::169) by CY1PR03CA0021.outlook.office365.com (2603:10b6:600::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.9 via Frontend Transport; Fri, 13 Oct 2017 15:45:23 +0000 Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1AFFO11FD047.mail.protection.outlook.com (10.58.53.62) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.77.10 via Frontend Transport; Fri, 13 Oct 2017 15:45:22 +0000 Received: from [10.232.134.49] (B35197-11.ap.freescale.net [10.232.134.49]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v9DFjISx011204; Fri, 13 Oct 2017 08:45:19 -0700 To: , CC: , References: <20171012130726.4332-1-alok.makhariya@nxp.com> <20171013153730.8395-1-alok.makhariya@nxp.com> From: Akhil Goyal Message-ID: Date: Fri, 13 Oct 2017 21:15:18 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171013153730.8395-1-alok.makhariya@nxp.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131523831225728695; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39860400002)(39380400002)(376002)(346002)(2980300002)(1110001)(1109001)(339900001)(199003)(189002)(24454002)(377454003)(356003)(229853002)(81166006)(31686004)(77096006)(64126003)(81156014)(6246003)(8936002)(305945005)(8676002)(53936002)(65806001)(47776003)(68736007)(65956001)(54906003)(53546010)(97736004)(189998001)(23676002)(4326008)(316002)(2950100002)(2906002)(86362001)(31696002)(83506001)(36756003)(110136005)(5660300001)(65826007)(498600001)(76176999)(54356999)(50986999)(50466002)(105606002)(58126008)(33646002)(230700001)(106466001)(8656003)(104016004); DIR:OUT; SFP:1101; SCL:1; SRVR:CO2PR03MB2357; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD047; 1:3V27RNxxFiCQhjnZ9Xb1HYWg+sJ9lA78AyfFjbhkegfPBPzfXgOQT/n8GdjqZDIQaIn7XfDBBcXpH/3/DM/gQQqgIrnVOC10stfWnT5XRCgt3425CbsqWANnba5aiHZ4 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b24017e5-d4e4-446d-33bf-08d512516a19 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017052603199)(201703131430075)(201703131517081); SRVR:CO2PR03MB2357; X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2357; 3:cg1OT8QPW/eFdrdYmTmayCyJ8TzVAbhQh6e72NLp/BGhZ+DYj/A1d/qz6PkmKr4NPj5MzucEFGQAj9c+Pv+SaBe76tCGcMZwB4AnefixwpMncc/d3CUzVN1gm7AJerRqP65qBL15klSzDUuS9ZHaNKUK5NoQMyUZy65fryrRjvuxLzsq9kd43pxGgBsmcRedPBc9gC5nBQmfMjYTpIL9VbvdSdUWoVRskHpHOoQPN3m0GE0/nvcHQL2L9KNYJrz7cqRVPxhGp1vVOvGgkjYCfDGAJx1AE39fRgxzuAUjxjwVewpB6wLquP7j3UOjN2G1/lEMkWJmDa9H8yXTV9IoBBlzFdXe5nG8U1Mr05UDj7A=; 25:tjMTIaephUxt3QApcKxPTCKfk4mGJAgDQVQ6wSMzs3UCHICzlIAHPQMPHbq5pA5QEuZGavBzgCto8yYgQh9S21K8jSExCNN7dnF7MrnQC4Mo8V3Ha/jbvjduJfo0L2ldIrQMWgaCo/qAumNCsGxlUu/n8pQBUTmb0ieBFOvdsuUs0LoZjN7YFWOJmR0iBf9EH0kCGJCqdg2fAVgFyTmez4Nca9Sen1x5nd47CiIdq4F/tazNA/TUxCofuxD3Zx96m5nLE9ZWZt60es2A6sphnxIRUQfjCoOjw3k1eWFhMBz9EoRjA5hbtDXJlk0x6wjnXNHzwJp5SkEZMrHuz/xMVQ== X-MS-TrafficTypeDiagnostic: CO2PR03MB2357: X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2357; 31:tKpvW2oeGF/NZLIaZBHzuGf7CAAn5eCnB5C65r/HxFHG9QWK7vo4Was/sajAilmk6hZ0Ft3FUveV/tQrkhQn4dzxxyNR+yMhz5G7lvrFsYX2YNNiFqI1hn4IG2An6rAsqzqRs/sqHAvHyjAlzNKbuVNFyU1UCIxPxHLdbX3nqEzJ7rOSZ9McTxSdy6RXKhmGWrxAbZl4XsGq0Ji2U+sgIhEJLKQFKaTd0uMP5Aqim7U=; 4:ZnRBnKmigKDeokwMShIgL1oOsDJ+yMVf52apxUoHADNOLRJE027EPQhBGZSrSZrCd+0OrxHbUGQ+lmZFzD7P5LmHF/a1kDu/oBugcfsiQ0fyEJLwRCqdUitkqpUzAMmKE4JZj3tmLJKmJxv3+bNX9/IbYSYED26AAJYxDIy33Sm542LH7zN2GpOxL4KsDZ/nOKYn8ghiVbjjX/KOXTro/d4r9Jc8lmT5Zp7/UdSVXF2nIx+FvOg8r18t5Y8Ua55SaKwxwTAWgFYaZYbNjrnsfr8SWHwQu/aTLqqFqmiiC3Q= X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(100000703101)(100105400095)(6055026)(6096035)(20161123561025)(20161123565025)(20161123556025)(20161123563025)(20161123559100)(201703131430075)(201703131433075)(201703131448075)(201703161259150)(201703151042153)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CO2PR03MB2357; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CO2PR03MB2357; X-Forefront-PRVS: 04599F3534 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDTzJQUjAzTUIyMzU3OzIzOlJSa1AvNDRtYWluanFDQkk3bmx0L0g1cmFx?= =?utf-8?B?TTJqREVka2RoMTBTQS9Ib3p1ZmZGVHU1amN3eTZZUmdjbnJjcnFmaWRmMGdz?= =?utf-8?B?QVQ1cE9VWWxYMTBQL2JkMjlrRzhjT2NDemdpamRDc2VuNExOTFc0aWdoOUYz?= =?utf-8?B?UHJ3aWF5OFVOYTZxZTR3UEpPTmhtcGJRK3o3aXNtb2FpbVVSRHVXaHA4T0dh?= =?utf-8?B?czNUZVFvcWIxYU84MnpvaFlxRS95TklKRzJud2hVaUkzSHFocGROWnk5NTk4?= =?utf-8?B?bVJPTkNvL0RSd2ZQOXk1cU94b093VjB5ZXc3RWJHSVVhS0Y3dVVuTTAza1cx?= =?utf-8?B?SlBXeWhINkJNZHNDZmN3bElGK0pQTjUvVTdTT01sR2MvNWlxU01OR3Vmdk53?= =?utf-8?B?NjVZUGRHQXBvQU43MnhKWjk0em13SloraTdZUS9aaS9KNEdhbFZxYnUyaWlJ?= =?utf-8?B?MmZrWnZkSkN5SVQ0bEdSeTRMNnlrc3RIYis3YkNXWmZTMzVhVkE3N3pnSHJj?= =?utf-8?B?QlN6RDZQazNkdEQyZUJGVEZFeXBlZzRvU29PK2I3V0ZvQzdSRUpvbi9sUDNT?= =?utf-8?B?Z2tLcGJNdFQ4L0Rndk5PUHBYVFFxVFBTRlRpbUFKc1ZQUmxlNjJzMkhuQ2pT?= =?utf-8?B?d0MySUY5VkJRMjV1aGR4cUE0dFhkUEhrZHJ0YmdheTVtKzh0a2ZKMlBRdzVT?= =?utf-8?B?Q3BQc29wRWwvM0ExbmFaU05nNkxINlVPRFZXdkc0ZytGVkRCcVBwWUxxY2tB?= =?utf-8?B?M1hpQVZVYnBUS0gvMSs5RUJ3SU4rQjRDcDZvQjEzNU5mRU9WbjN2MFB5OFcv?= =?utf-8?B?V3I3QjVzNnhZVVBPcHFla3c2ZVhnUzB0eExCd1dLU1VRdkVuVDlVa0dSSVor?= =?utf-8?B?SzY0UWo1QUpLWEE3RW9FQnZOajNVRWtQMGl5Ui9lS05abHh1RDVYT2lPRGJC?= =?utf-8?B?eEFrbC9BSUdyeUVRZlhseE92cUxRcFJyT2c5Rm42M01GNU4yc0xvWHZoK3A1?= =?utf-8?B?UVVsSmk1SGx3RitSRnA0TCtBMmZMRW1EeXZSQlp2TGtFV0VqNmY4dDJNbnFI?= =?utf-8?B?OHhrK240Tm1wTThGS09sVjNxMkxCQi9BaTFZazBNOGVrby9FbXN3S3B1OWNK?= =?utf-8?B?SFMzSW1JdXJ1cXNIa2o0dWdWd0R3WjFud1R5M0UyMjhydmpyQm5kdGNpOTRr?= =?utf-8?B?dTlEaEI4LzhyNmhjaUZybnlxVTlOdGVKSGJXT0RwVG5kWDR2ai94Qk5RbHBN?= =?utf-8?B?RjdBek9TcmR1RTA0TENPNVhDZXJMaTBwSlZXamhOQW03RUFjeDgxSXBuMmhn?= =?utf-8?B?TzZpVTFubFh6aGVQUkFwS2c4cktOSW5mNEt3VGt0eEUvakdWVHcxbXYrVEdQ?= =?utf-8?B?YTJPM3Z2ZHc2TVk5VUNFejNpQlkySzNMVFE5blgrZlplTTVLNVI5c1hvSzU2?= =?utf-8?B?bEdDaGlBV3FFZmlrTG9EUXJrcGozd1hMMzl6NC9JWEM1SlBTd0wvQWhYQXRF?= =?utf-8?B?U1VxMW5RMHNWWmtOdkswRWpwL2ZsQU1EdXVqSXFqZTl6R21mTldRY0g0SHQw?= =?utf-8?B?MFFKTnBtNjdVZmxsWXhKRUxIRU9oT3BYU1p2UGFMb3o4OWtaTVdzQVB6YkZG?= =?utf-8?B?ejBFS1EvcXpQWWdvalcrM1VFcDJMT0VOK2RJL2N2a2IxMWdWYmtJL1JaanVF?= =?utf-8?B?ZithRW5UaGVPWVMyOWp4YndiMTVBSFJuSW1nVC9nTTFIWVI1elRaTEQ0S05n?= =?utf-8?B?MVFIei9GWWwvN3BZVHZaQkZOQjBsd1JyWWptWm9GUW9SelRXVVo4UzlzQit6?= =?utf-8?B?MjVpZEkzaVROUXJOZmJHMHZLNXVJR0p4eXNLdlJBL0drRWc9PQ==?= X-Microsoft-Exchange-Diagnostics: 1; CO2PR03MB2357; 6:W0xGEbQjLu/9Evp/akCGBqdu1j12WiaqvpW3+vozswwLvcY9Nb39hSCSoUw31BFrJHoMUIkpNcyL0b8UcmOstYH8UJOxLS/mpH1cFtpggNuXBY5yqeM6V6rzyx3et9mv90cHXXuNVrDESPhvPCDdixVJY4QG4ixIJfD6UIsfDEf4hcTYKF9xgprwpogm/HNfYofwbVN43wMCptZO+jeTSyyn+j6C0InWB5dTKl+7qDqIroQz8t+dttfTAMhILF5cx97edjGQJU4woQqViwYNbQFa23tNXiipRLI+cvOeU+16nxpd0DLwcZvgzw2kf9tl2vDp1YdtheqHvShs78lGfg==; 5:rqZyF1SjCIm92bdzlNVZP0TuMELe++SeTttcZcvbj2XPA2rhKvwokoqESQd3MFv8fZKKsd1anXuBEBbuT6Jdea8d1qCEn13OTr2Pv1GFvj6/ACmcw/n3Hs6jnh59ExlBZc83VOwRRiEJ3gIG+88P4A==; 24:smOdxVkqjQKM0075WTC073PO76N4Hxayl4/pTR+1MWVU31TngfeLysdhj8kYfSVjuguUqdf0pKD2Y0dJaAXhhuXBPyGqD1hkTmhEfZ2v5hk=; 7:FiUOb24krVl/RguoJ92rlDP/+HbjmSh0c8WWXPElyp0J5V7pxw0A07BX3r/QPqWichZUW4lG4+h5YVLAZqClC7dnLX7A9s/4/KmmUaHHn99uMJ/RVxeFyo3+CiakW3Rq0cN7vadLfpuqiANsUpV3f8Ygo8v3Z0GinrRZqY9wEgcgdnTSeUHzP9ZrR1kG+tlFbxrT8EHMmwR313OoXap5oA+QsgQDn8Hzo/E2aj6b7Ww= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2017 15:45:22.2920 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR03MB2357 Subject: Re: [dpdk-dev] [PATCH v2] crypto/dpaa_sec: add check for segmented buffer X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Oct 2017 15:45:25 -0000 On 10/13/2017 9:07 PM, alok.makhariya@nxp.com wrote: > From: Alok Makhariya > > The code would crash in case of segmented buffer if no check > > Fixes: 89aaf708d44b ("crypto/dpaa_sec: add crypto driver for NXP DPAA platform") > > Signed-off-by: Alok Makhariya > --- > drivers/crypto/dpaa_sec/dpaa_sec.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec/dpaa_sec.c > index 7b9a683..bd13d8c 100644 > --- a/drivers/crypto/dpaa_sec/dpaa_sec.c > +++ b/drivers/crypto/dpaa_sec/dpaa_sec.c > @@ -893,6 +893,13 @@ dpaa_sec_enqueue_op(struct rte_crypto_op *op, struct dpaa_sec_qp *qp) > return ret; > } > > + /* > + * Segmented buffer is not supported. > + */ > + if (!rte_pktmbuf_is_contiguous(op->sym->m_src)) { > + op->status = RTE_CRYPTO_OP_STATUS_ERROR; > + return -ENOTSUP; > + } > if (is_auth_only(ses)) { > cf = build_auth_only(op, ses); > } else if (is_cipher_only(ses)) { > Acked-by: Akhil Goyal