From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 38E9C425DE; Tue, 19 Sep 2023 23:18:52 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0EEC5402C5; Tue, 19 Sep 2023 23:18:52 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2083.outbound.protection.outlook.com [40.107.94.83]) by mails.dpdk.org (Postfix) with ESMTP id C3E0B402A3 for ; Tue, 19 Sep 2023 23:18:50 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xmfez4xWmewid00ElLZVe/ImxyAA23FvL2MQm8tmoI8ASWVrOMJIV8CXj4D4+zAWKSDjpVAKcsByeaQ5egVQe1gXunjlmqIVnC/61xpiRi+yG2gG6K5ZT7PM+MBBKYhe2H/X/wiNdzAZkBwJwacm2gNWApCo7sCUOZON6T/gUYlSXEKFOKuWP6LMt1esA16q8RZvZ8P+ADZms+8fwvvXSV3zIF6uqVRpZTfxmAJU5PBUX1kqzCqhsF4S2NqODDODH7j/5jzhsdxp2tMJtMW0FPZL0EUuCSu7k11YmHwz7SyoFbfo9ihQby0t2ApgbYvGThmQcrzpCcmTStxOexd6Uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=biNdTSLhgSwieLBrfRldJQDXyyQLgWSklZJob4MO9sA=; b=SZKv9Q16dLEM+Kvg99ppL093TrcXIBP9D0+3xgTzWoH0/Mjtl0s10pODHBb6N+5b9fzNhfMFsyKiXRtEzIQfeq7h7UzM0PZ6fGuvpWa1EzuC4bxRKf0j8lfy2TmZ45NLTO0CInHAQZKKLqK8FI9N4/xXVNIWib9Kqy7OR5zfZh6gT97HLvA3p3T3jHzqakvHsm+cH+WZcJsvuGiEv9524f/gXIhELU9pd+733eND116YCT3nI683Jp8lZwBmzuai/mP10JLzwN+b1WMeGBBDNjAnbWkdgZGXPvF12pGswdg0T80Ce1XGFDLW8UQn4mgI7I6OvTNU6Yg2+Mxt2PKACg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=biNdTSLhgSwieLBrfRldJQDXyyQLgWSklZJob4MO9sA=; b=dKhFUflLrM4jDwzvHs/5ct+tJJ5mwOYVR7v1g0NRaZSnTpLYkhypSDsfyAh9Cbz4o6f+IO3h7bJkRKQdkYUnUswQcZSw2gbiB11aWmJGilD3XO+FNGYPjoWriS6xX3TTTE+TprRLRR/HvLyLbp25K0AK8MvP9ES9STiU7L6CU1w= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH0PR12MB5417.namprd12.prod.outlook.com (2603:10b6:510:e1::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.28; Tue, 19 Sep 2023 21:18:48 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8%4]) with mapi id 15.20.6792.026; Tue, 19 Sep 2023 21:18:48 +0000 Message-ID: Date: Tue, 19 Sep 2023 22:18:40 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 00/26] refact the nfpcore module Content-Language: en-US To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com References: <20230918024612.1600536-1-chaoyong.he@corigine.com> <20230919095440.45445-1-chaoyong.he@corigine.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJjb9DJBQkC+3/YAAoJEFRTPtCK Km/6d94P/irGq3mPa7LamXMIioQ8i6ppMSjpr8g+SxH9RnzbmoUjUY6hVzCpXYxEejiJHubg 7lwD+bOocYpiU8Pe0UncVBhIPNk/dIWQAyH0IWK1nd+hOnjxHv3AQpP80Be2o1mUn3oq/b+B QYiyvvre2gIugYq0hzLcG7z4zREeT+Nl0DMDfnLx+Tj2FAOHrOfudUqjdr/VjF5PoTK0bxnb Brqulp0I0ft7hNsufhzf+TlqaB5l0eQO4gDo5xGTP97TT1cGYsXVMsyDhHqW6P3cuj8kkLkO Ch4oq8OLL8GElgRy5y5svU6CJu3f8hT9aiqIoaRpfNv6N8iEk6g4/HNN+uydb9YCA+1pbwBx skmDhtxQrmXpI+Fmfq0aX2NmqHcy6JR8Ekm/nfwLAW/aDpwoMImVN5pPXtOBSjYi4pj7hiJk UA0ZFi8HCW+fic85p8MXn1GPDmbO82Mm3JVJ1uJNAzGsBbW5SP1ol6+XTeaSxcmzFlrDs8vL XQJMRTpcG6Pti7GbbsOtldvmxRQpq9PmCgQg9IrPXpMoaKE3WwtiSiCALs0kYj4F+hhgAfjI RsOuaAJTnKYW31pC/QdroMNAEqIpLveql03jj+xD9ntJIVAsXiCitsLIXzKP0L5tcHkoVLC3 NAjVYq6XkAEssPF4mMRLoEwpvxOytHe1BCJoRl0YA0aQzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmNv0PAFCQL7f/8ACgkQVFM+0Ioqb/oU9hAAisAJJ09j/kiEeA1HGKUg3DyFnYW22zRL z1IHYmcHQanMx4+FAwsb1bonVldQMIYNJ9z69UNIU16zIqLZt3D5QK7Je5F5q4NZgfP2jtjX rc3jyu0PuDerFZQyxNcYhhmlF9JO9NV976WYbBAM3AAr0TDohUk+YicYTKab+ZHYOABXbqHX qi+bzDCH1vKBDfpJviprthhK1tIABUK5lsp9aFwFU2jfu2J3XX3pwQhPMjtn2C4v37XUnOqM SJPr2HLU27IW5I3BBpJn7dZE/BkmDmnceHF8E4tRlXCQ/cf81+eErL832sfhVJo1MpubKh3B j89ZLmw0cDXZP2hqlC9vdXnoWWHI8PDPkiw9z11yLrT9Wd4cTJTjFV49Z9G96rgnOtWDcZ1J xHBAnXYQ7V2k9abY+ZqY1PtAPr/smqzQfPHXyTAhRVZp2f3yQmj7UqB07FJuLQjJ4CGk97Qx ///qeSg7D8x/sGEA8Yp2jgIj6u7tspuz+RgBYrWpfI0VIHhWED0jNXzqztrVX18CzA6r0ReY SG+CSyycKkco6UI9ZeUrXFwnoUJqIJY9wTJo5gD9EgGIbItv3qWTq29dihLYpzd6dqB708k7 4RBz9051oLaFVGkguFw/tXmA17nx+c2uR5jx8wb4j68umG2X++0dSta5eHAVhmtXvrqPW6Ku 3FQ= In-Reply-To: <20230919095440.45445-1-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0666.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:316::17) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH0PR12MB5417:EE_ X-MS-Office365-Filtering-Correlation-Id: c1ebc4a1-9a1d-4cf5-2b0d-08dbb956031d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: G1W0/6QEkyTLS5goNyJKowhkYEMJjvySLXKcMI9dhhdaWT/KKPjTCi3xFxCphRWiSm4uIzpFvyGcbtU6bhisFJ1Ig9NmGKBCXPdYVEQtaL+BGlQ+juM+XrFmSqj1ur5QrEws3a9ELhPSubRtZs/DwWxtr7Qq+BYayakMJaK3GwMzzhPQtWPiyBLIgqJTUW6zinjILNawXgxlf/yOgsWU2m88Lb5EIVWVND0Aww3lof5TcbU9NphjUlHAA0dP+L+dLcwvnh/VDyMCcIwx3iQlxuX5OslIsJgqxd2VelgoWmT/w/d8KJPluCcnXsml5BGZZj6rCseWukspE9B4hHp5npaUBLE6X7HLgkSTLl0tMxuh27Y0pl3ZfivkPkbxYkkunTWTd0gHbhmw4swv9VwJF0xA9+U/1xURileW7Eq/KNaquefT2VOheAVpJANlgPnUbLxzc/VR5zcImKruEJuGX8CXxlDSAHFUL1B1yUqYKHKV2lMDwaI9IRYbc48t5rSScqkhp29b0k5dsCWLa/4OOWGnkR9szn5e/KDs+tP5Rl8LFJhvN5y/Yf3zVgzvsYe8EJavKSZcP6ifR1jpv88VI3J3JT5RvG63W6AK7KIaQ56X/NEG1DVJ8dvb9QgEX9GDx7RjgQZdlToFyn/m7RFjpA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(136003)(346002)(366004)(396003)(376002)(451199024)(186009)(1800799009)(316002)(66556008)(26005)(66946007)(66476007)(2616005)(83380400001)(36756003)(6506007)(6666004)(53546011)(6512007)(6486002)(86362001)(31696002)(38100700002)(478600001)(2906002)(31686004)(8676002)(4326008)(41300700001)(8936002)(5660300002)(44832011)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RS8zdkxmMVliVGhFSExOTDZON3J4WWVlM1hxWUNiSG9wYlNqVk9ScTEwZXVw?= =?utf-8?B?UVhjK2pWSXJFMG91L1ZKcW5yd0xReTZVK25xTE5kQlpESzhITGljbUlXK3lK?= =?utf-8?B?dFpQekVYa2tTeWtYZnM3ckQ1VEU0cHFSUTB4eTl1SUZyYy94V1dBeFBMVVo2?= =?utf-8?B?OWYvdG1PWHJaak90R21oWDlVUFRMMldiTXNld3JjZUZYV1dMLytQdDNrMFN5?= =?utf-8?B?THhCNEQwSXovNUVSbFprenRXRVZpczFBTlo4dm02S2E5elczMjNyOXUyQjhT?= =?utf-8?B?dStIYkhabDl4dFdpbkVtYmF5RXRWd0lCNkk1QlVIaUlnTkdaS01JY1l2Nkww?= =?utf-8?B?MFNTc0VZajBCaTFuWXZZMG5jR1QwcUt1RXN6TUZoejBrbmdVQ3lQeThGZkpr?= =?utf-8?B?VUFoM0UxaDJVcThrb2loekh5Y3NESFpPMkhIN1pNUmVxV1M4MTUrSTZJL21W?= =?utf-8?B?Q2hYWWhOYkJRMktKU2Y5aUdIdllONjd1dmZtVXQzY1JibHFZTlIzRzFGeEV1?= =?utf-8?B?bVlVMU5PZGR5RlFCOXhoR0RnM3E2TWIwdGdsSjEwWGRCbkpyeGI1eVhzekpr?= =?utf-8?B?S1NJcVNNdjNLbjVOMkEzOUF0UVRFeG05RWg3M2RHa2Zha3FGODFJZHhiVEFN?= =?utf-8?B?VVBIVXllK2NWOWdvcXpwMzBxSng2alhDV0FHZDdtbEx2TkpLZXAxSFpwb2c0?= =?utf-8?B?bVgvY0Z0Y2pRSUFZSjJkODhhOWd3RTFDLys0cytoNUI4RE5QZk1vN2o0NkVK?= =?utf-8?B?ZXhRKzFOYlVTckpwN3MzWCt2OFhRbTdTT2V2N05idTc4NnZCVTNpbGMxelp4?= =?utf-8?B?UjF4Sm41cG5XMWNLNzhaOHppaHAxSEluZmhNUEpsdko5REs1OTdLOS82UDBm?= =?utf-8?B?UlFwd0xwR3lPcU9pQzNxVnNSakF6L2FWR1IrbVFvQkZOWjN4dG03TU42VHJm?= =?utf-8?B?Q0JWVDZld3dxeDFIaDUzdTZsYTRIRXJMQjJGQlVQNTJiYjRBSi84cUJuRnFt?= =?utf-8?B?cHYwajJFYWhHZkdzRkkyQmR3RnhqZXN5dEZtTmNRUEcxRXpNRHJ2UDRtY3g5?= =?utf-8?B?NnplTjdFbXVlSHN2U3Qrc2wvaEE5TzYzUVFObUxCY2NuaGpGeWlIdlFRVGN6?= =?utf-8?B?VjJYb09xdE1SK3NrS1JZYkF6SS9jZXRMczNmQWYwZnpuQjgzM1BWV0JtTGpG?= =?utf-8?B?ajNmZVZSSDJUMmU3TFRHallmSXRHRzU0TEszSGVQc25WNzBvVmRWWTZOWkF6?= =?utf-8?B?dlg4VFcxQkxqU1QzclVqMlRyRzVoMitTL3Bsbnp6NXhNZDIrUU1DS2JFRVFS?= =?utf-8?B?azJLZXA4c2Z6UGNTVFdrSW9sTDArc0xLWk5LZEpkT0xkcC9sd2VkSFgvV1V4?= =?utf-8?B?UlVodjdjK0ZhdVI4eFUybVdqTEtTUUJjVWFQVEZqRmQrb3plV1hycUsydmxs?= =?utf-8?B?dzMwaGh3TDhCTE9pMUJBQStzWFI2dGdUOC85eU9jZVhOaGZxanNEUHhKbkg1?= =?utf-8?B?YUJ2RDB3M0laUFRObDFtKzJpM2l2MUxLczNyRUVFVkN5WElJR2lQd2VZdjRF?= =?utf-8?B?ejNqWTdYWG9iUmZWcEdWUW93d3Q3ZENHUXJRVlNTWUNiM3lIdEwrQWtpNkQw?= =?utf-8?B?TWV4YlpoUFRyTXhKQUpWaHZZWE9qaE1aZTdtQld5bEIrY28zVThaQnFtbUhG?= =?utf-8?B?VjRQUmtuVTJMUXlsQnlxK1FzYzJsTHhGSWY4Sk5UTlZiL0JwZDVmeE5nYzhE?= =?utf-8?B?L1p1T0VRVW1CQ3N1cXNrWHhWejBoc3d0NFJ6TFRYeXVNKzVaVXFQZGEvaWs0?= =?utf-8?B?NmhSZVVPTThHclo1YW5DdjRqVmcyMlZld0RleU5VYy8wSlFPT05ZTXNpclho?= =?utf-8?B?UDlnUENpb3dNaHFSUGdLWjJJNVN4bUJja0pmZ0VNaC9sUWVXa1cwMWNEbnBL?= =?utf-8?B?dEJYbUR2OHpnRGkvdzdhYWJITTFqVHo1a1FoQmIrM1J4K25sTm54QTZWaUFo?= =?utf-8?B?NG9jM0tUYjNBeDIwWkdadVJzUGdiQk4xNlNpYmZxMVU5a1UwQ2JmS2VaK0JK?= =?utf-8?B?QVpCb2NzWGUwQ2xkSlpBQ2p0bFJqZEwzWXRkUVpVd1RKK1hDdDBaR25RNjkv?= =?utf-8?Q?oetdE2jXKYJuV3AM3PA9cFaKx?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: c1ebc4a1-9a1d-4cf5-2b0d-08dbb956031d X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Sep 2023 21:18:48.0874 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ArcIHcWgM/cGuzzjdmkzBnZzx6xi/fxl+beHnye67HGju+rAiiJBIdfjIH0jvYyL X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB5417 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/19/2023 10:54 AM, Chaoyong He wrote: > This patch series aims to: > - Make the coding style satisfy with DPDK. > - Sync the logic with kernel driver. > - Make the sub-module more modular. > - Extend the nfp configure BAR from 8 to 24. > > --- > v5: > * Fix one bug in the logic of VF using dev module. > * Remove the R-b tag as the requirement of Niklas. > * Revise logic follow the advice of reviewer. > v4: > * Drop the commit 'using the DPDK memory management API'. > * Modify the commit message of 'standard the comment style'. > * Revise some comment logic as the advice of reviewer. > v3: > * Fix one bug in the BAR find logic. > * Modify more coding style. > v2: > * Fix the compile error in Fodora 37 environment. > --- > > Chaoyong He (26): > net/nfp: explicitly compare to null and 0 > net/nfp: unify the indent coding style > net/nfp: unify the type of integer variable > net/nfp: remove the unneeded logic > net/nfp: standard the local variable coding style > net/nfp: adjust the log statement > net/nfp: standard the comment style > net/nfp: standard the blank character > net/nfp: unify the guide line of header file > net/nfp: rename some parameter and variable > net/nfp: refact the hwinfo module > net/nfp: refact the nffw module > net/nfp: refact the mip module > net/nfp: refact the rtsym module > net/nfp: refact the resource module > net/nfp: refact the target module > net/nfp: add a new header file > net/nfp: refact the nsp module > net/nfp: refact the mutex module > net/nfp: rename data field to sync with kernel driver > net/nfp: add the dev module > net/nfp: add header file for PCIe module > net/nfp: refact the cppcore module > net/nfp: refact the PCIe module > net/nfp: refact the cppcore and PCIe module > net/nfp: extend the usage of nfp BAR from 8 to 24 > Hi Chaoyong, This set has 24 patches in the mail_list/patchwork, last two patches are missing, can you please double check?