From: Shreyansh Jain <shreyansh.jain@nxp.com>
To: <david.marchand@6wind.com>, <thomas.monjalon@6wind.com>
Cc: <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/3] eal/drivers: prefix driver REGISTER macros with EAL
Date: Fri, 7 Oct 2016 19:11:15 +0530 [thread overview]
Message-ID: <a64af194-3c5f-b38e-70ce-3c3f69a844d9@nxp.com> (raw)
In-Reply-To: <1475847187-28967-1-git-send-email-shreyansh.jain@nxp.com>
Hi David, Thomas,
On Friday 07 October 2016 07:03 PM, Shreyansh Jain wrote:
> DRIVER_REGISTER_PCI -> EAL_REGISTER_PCI
> DRIVER_REGISTER_PCI_TABLE -> EAL_REGISTER_PCI_TABLE
>
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> ---
> doc/guides/prog_guide/dev_kit_build_system.rst | 2 +-
> drivers/crypto/qat/rte_qat_cryptodev.c | 4 ++--
> drivers/net/bnx2x/bnx2x_ethdev.c | 8 ++++----
> drivers/net/bnxt/bnxt_ethdev.c | 4 ++--
> drivers/net/cxgbe/cxgbe_ethdev.c | 4 ++--
> drivers/net/e1000/em_ethdev.c | 4 ++--
> drivers/net/e1000/igb_ethdev.c | 8 ++++----
> drivers/net/ena/ena_ethdev.c | 4 ++--
> drivers/net/enic/enic_ethdev.c | 4 ++--
> drivers/net/fm10k/fm10k_ethdev.c | 4 ++--
> drivers/net/i40e/i40e_ethdev.c | 4 ++--
> drivers/net/i40e/i40e_ethdev_vf.c | 4 ++--
> drivers/net/ixgbe/ixgbe_ethdev.c | 8 ++++----
> drivers/net/mlx4/mlx4.c | 2 +-
> drivers/net/mlx5/mlx5.c | 2 +-
> drivers/net/nfp/nfp_net.c | 4 ++--
> drivers/net/qede/qede_ethdev.c | 8 ++++----
> drivers/net/szedata2/rte_eth_szedata2.c | 4 ++--
> drivers/net/thunderx/nicvf_ethdev.c | 4 ++--
> drivers/net/virtio/virtio_ethdev.c | 2 +-
> drivers/net/vmxnet3/vmxnet3_ethdev.c | 4 ++--
> lib/librte_eal/common/include/rte_dev.h | 2 +-
> lib/librte_eal/common/include/rte_pci.h | 2 +-
> 23 files changed, 48 insertions(+), 48 deletions(-)
>
[...]
Ideally there should be a another patch like below as part of the series:
--->8---
diff --git a/mk/internal/rte.compile-pre.mk b/mk/internal/rte.compile-pre.mk
index a42ef03..a91c265 100644
--- a/mk/internal/rte.compile-pre.mk
+++ b/mk/internal/rte.compile-pre.mk
@@ -87,7 +87,7 @@ endif
PMDINFO_GEN = $(RTE_SDK_BIN)/app/dpdk-pmdinfogen $@ $@.pmd.c
PMDINFO_CC = $(CC) $(CPPFLAGS) $(CFLAGS) -c -o $@.pmd.o $@.pmd.c
PMDINFO_LD = $(CROSS)ld $(LDFLAGS) -r -o $@.o $@.pmd.o $@
-PMDINFO_TO_O = if grep -q 'DRIVER_REGISTER_.*(.*)' $<; then \
+PMDINFO_TO_O = if grep 'EAL_REGISTER_.*(.*)' $<; then \
echo "$(if $V,$(PMDINFO_GEN), PMDINFO $@.pmd.c)" && \
$(PMDINFO_GEN) && \
echo "$(if $V,$(PMDINFO_CC), CC $@.pmd.o)" && \
--->8---
But unfortunately, my build system complained about this. (and I stopped
short of sending this patch).
The output of compilation after this patch is something like:
--->8---
CC eal_pci_vfio.o
PMDINFO eal_pci_vfio.o.pmd.c
/bin/sh: 1:
/home/shreyansh/build/DPDK/02_dpdk/x86_64-native-linuxapp-gcc/app/dpdk-pmdinfogen:
not found
/home/shreyansh/build/DPDK/02_dpdk/mk/internal/rte.compile-pre.mk:138:
recipe for target 'eal_pci_vfio.o' failed
--->8---
I don't think PMDINFO should be running on eal_pci_vfio file. Isn't it?
Is it because EAL_REGISTER_* is matching EAL_REGISTER_TAILQ like macro
as well?
I am not very well versed with how PMDINFO is linking with the build
system so any hints/insight into this would be really helpful.
One I get more clarity on this, I will push a new version of this patch.
-
Shreyansh
next prev parent reply other threads:[~2016-10-07 13:40 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-07 13:33 Shreyansh Jain
2016-10-07 13:33 ` [dpdk-dev] [PATCH 2/3] eal/drivers: prefix VDEV driver REGISTER macro " Shreyansh Jain
2016-10-07 13:33 ` [dpdk-dev] [PATCH 3/3] eal/drivers: prefix driver param " Shreyansh Jain
2016-10-07 13:41 ` Shreyansh Jain [this message]
2016-10-07 13:51 ` [dpdk-dev] [PATCH 1/3] eal/drivers: prefix driver REGISTER macros " Thomas Monjalon
2016-10-07 14:18 ` Neil Horman
2016-10-08 13:01 ` Shreyansh Jain
2016-10-08 13:00 ` Shreyansh Jain
2016-10-10 12:56 ` Neil Horman
2016-10-11 6:36 ` Shreyansh Jain
2016-10-11 7:27 ` Thomas Monjalon
2016-10-11 13:38 ` Neil Horman
2016-10-11 13:57 ` Thomas Monjalon
2016-10-11 14:57 ` Neil Horman
2016-10-12 4:29 ` Shreyansh Jain
2016-10-07 13:45 ` Thomas Monjalon
2016-10-08 12:47 ` Shreyansh Jain
2016-10-17 13:09 ` Neil Horman
2016-10-08 18:01 ` [dpdk-dev] [PATCH v1] drivers: prefix driver REGISTER macro with RTE EAL Shreyansh Jain
2016-10-08 18:02 ` Shreyansh Jain
2016-10-08 18:05 ` [dpdk-dev] [PATCH v2] drivers: prefix driver REGISTER macro with RTE PMD Shreyansh Jain
2016-10-08 20:21 ` Thomas Monjalon
2016-10-09 15:12 ` Shreyansh Jain
2016-10-09 19:50 ` Thomas Monjalon
2016-10-10 5:11 ` Shreyansh Jain
2016-10-10 5:16 ` Shreyansh Jain
2016-10-10 5:43 ` [dpdk-dev] [PATCH v3] " Shreyansh Jain
2016-10-13 23:45 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a64af194-3c5f-b38e-70ce-3c3f69a844d9@nxp.com \
--to=shreyansh.jain@nxp.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).