From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0066.outbound.protection.outlook.com [104.47.34.66]) by dpdk.org (Postfix) with ESMTP id E9F121B32C for ; Fri, 19 Jan 2018 16:25:02 +0100 (CET) Received: from BN6PR03CA0023.namprd03.prod.outlook.com (2603:10b6:404:23::33) by SN2PR03MB2367.namprd03.prod.outlook.com (2603:10b6:804:e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.428.17; Fri, 19 Jan 2018 15:25:01 +0000 Received: from BN1BFFO11FD019.protection.gbl (2a01:111:f400:7c10::1:116) by BN6PR03CA0023.outlook.office365.com (2603:10b6:404:23::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.407.7 via Frontend Transport; Fri, 19 Jan 2018 15:25:01 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1BFFO11FD019.mail.protection.outlook.com (10.58.144.82) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.428.12 via Frontend Transport; Fri, 19 Jan 2018 15:24:55 +0000 Received: from [10.214.249.53] ([10.214.249.53]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id w0JEPfQ4026546; Fri, 19 Jan 2018 07:25:43 -0700 To: Jia He , Thomas Monjalon References: <1516161831-28719-1-git-send-email-hejianet@gmail.com> <1516161831-28719-4-git-send-email-hejianet@gmail.com> <2512442.13rg75T8JE@xps> <23810751-921d-4e3a-bac6-95d251cc122f@gmail.com> CC: , Jerin Jacob , Jianbo Liu , Jan Viktorin , Olivier Matz , , Jia He From: Hemant Agrawal Message-ID: Date: Fri, 19 Jan 2018 19:55:41 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <23810751-921d-4e3a-bac6-95d251cc122f@gmail.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131608491011772769; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(376002)(346002)(396003)(39860400002)(39380400002)(2980300002)(1110001)(1109001)(339900001)(189003)(199004)(31696002)(76176011)(107886003)(53546011)(105606002)(59450400001)(106466001)(65956001)(2486003)(4326008)(50466002)(6246003)(23676004)(64126003)(5660300001)(65806001)(498600001)(229853002)(230700001)(53936002)(54906003)(2906002)(110136005)(47776003)(85426001)(2950100002)(65826007)(356003)(86362001)(67846002)(305945005)(104016004)(77096007)(36756003)(93886005)(97736004)(31686004)(26005)(68736007)(83506002)(81156014)(81166006)(8676002)(8936002)(316002)(58126008); DIR:OUT; SFP:1101; SCL:1; SRVR:SN2PR03MB2367; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD019; 1:m5brmhKb9jVdv7/B2wNt1JhTgJqr4rYHEs0nNG65Yfncp3w6fFMOLfXUYgYwmnZ08vxsmpANkyZvYS6z6fVSdh+6rkOWSg5fGona4eq3v+qw/ow4KZCRiBHiCE9To4iP X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4d9c7c28-e2b5-4ef3-e7c1-08d55f50ce94 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(5600026)(4604075)(2017052603307); SRVR:SN2PR03MB2367; X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB2367; 3:FsflSPo8GvFnCOUW0fnT7XeyKB59Btkqis2W0p7bUlQRR9QrxwnOrTjjGXuUNW5+HrqI9y1uvWal42pTv721zHUvndDWSZNPszyuKwSSG05f1ujBEblMM1t9ewH16bnf062lDD3OR1duJz9ILM9LGmsomjiQJGhplfDTPv+oZrfe1NqmmFhSBImLy92ViPvv162EVYpJ5OkgoAXU/strHba1mc0/3Egd7v9spSZWeMzlg9hd7OOSY3dR6Sq3FF46734+ouQzgkbTuHJXzhNayZ7PCJuIZWISuXuxxLXmK4oURhpnrYcuZAKte4fR0BadHXQVr9cAm3fN2jIy98Xi7wXI3jKP9fDRuNaQdbkei0E=; 25:/6nVAr5HDaQ06VkCd7TnthgOuGd+/CQmUIzZJwSyk7F9L2IbzvZtDg3iL5feBgheGZJFgwlNoq9g7v0tURYhZRsTMPF6nL26hL5jJpdOmwyF4CfNwYuy8a2dPPOy1MEPERfTMLAuTcv6nSbFq3OB4i7k2Df8h4VvQfjavOdC2WuYX72e+fPsh0W7fmKMv2qIHYd0X6e+wcomystCl3RQGZ7JmyIWaZWR/q42m0oZAuHGH8WquuiwCTyR/lHEkqPNOWh9EoxLyHUtIQpCDoJ1pahuGiyhCVpbQuoh1Q+57QJsI3GWckw1y8PXknfBVPiAKZdlqxAEYju75ep3JEeqqg== X-MS-TrafficTypeDiagnostic: SN2PR03MB2367: X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB2367; 31:E6HCIPOI7S5R+52jnUCJ2cK0pU4aqDslicmh06mu1Od+sSj7gg8z9mYqq2VCCr3KOS6xHbooqjRl1ufxdRbjymKEL578q21fZdDweQeNqWIr57ayyK87eGOL4UvZ+jU4A2/qCHIp3KCO9qC7/mNfrUE6/xtOUsb2trR+mKqOUe08bSDKdR42rDFcEb/C1OpKv+HZhgBZoLhPHMjrr+Vld/2+uclXpze2j05kX/ssL5U=; 4:LKYEbjWXKJjgTL4mYibAogHKJt63nE2tSXfKvgLtbPCMQ+fvchcQC8UJRDxQoofDB1TOBCGXU5XFT9x87Hl/rminHypoeGCwaF+AgJVeA3jj7NCGI0KaFeerI6sIrUm/0I5hURV91X/LUlh2Kk57GdyPhr189jRoKpJKufwiMcscWoPP0Z7C7OXHfBZzL0iOCCBqE6cAHyPHfsbwB1yX34pi9mLbdgKsp08RwqhG7/6PA0RJD+wVKKHXpJRp/LHnQ0AlfSPe3qluRo5arc5izA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095135)(2401047)(8121501046)(5005006)(3231023)(2400079)(944501161)(3002001)(10201501046)(93006095)(93001095)(6055026)(6096035)(20161123565025)(201703131430075)(201703131448075)(201703131433075)(201703151042153)(20161123556025)(20161123563025)(20161123561025)(20161123559100)(201708071742011); SRVR:SN2PR03MB2367; BCL:0; PCL:0; RULEID:(100000803101)(100110400095)(400006); SRVR:SN2PR03MB2367; X-Forefront-PRVS: 0557CBAD84 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjJQUjAzTUIyMzY3OzIzOkNkRXNYZWVoa0xpUGdDTU1vRHdUc3NQME9U?= =?utf-8?B?WlE3SFRoSWdSM3Aydk9rajMrK0xob2k5TjJka0ZGRG9iOEZialBBb05PV3cy?= =?utf-8?B?OWVQdVNsb200TkpEVFRVVEk2aGQ0aVEwRUhQYUtaWGxFS2FoL2J2dFFyb2Fr?= =?utf-8?B?Y2hRUGloMnJwSm1sVWt2aFlNTU5SaE1IbGtxZjhoNlFWZ2dJd0RzaDJDVmpx?= =?utf-8?B?TVNhWEVWMUpzWjNGQkNmUzBFd1g1VTB4ZS9mcVhWNzJPWDdtTDRtR1NTT2th?= =?utf-8?B?NzBmU1FMTUVvS3R4TDVUdUlrM2RSdW00K2o4SG1xY3R0c1Y4U1VoWk5MZnM0?= =?utf-8?B?TFJiaUg0UzFwaDVoZDg2QzZ4aHY0eXBvVHo5SE41SmQ3WGl4ZEg5YnM3K01p?= =?utf-8?B?NnhmZWhHaVp0QStJa0JDRXdETDltbU1hM1BhZjJXaU5BMkQreXVvSWhDZUdn?= =?utf-8?B?RU9sOXlVbElQUE9jVllxRUdpMzZvVEJjN0p0bitMRjJjSkRJSU1zbE80ckNJ?= =?utf-8?B?ZHRKUDJPYXhvOW5IcmpmY04vWEZEdlZqQU02WTFYdjY5UDBrZFZXMVFBeHdo?= =?utf-8?B?REp2RTl4MnlwbkV4YjJQQ1Z5NnV1REwxeWx0WDE0dC9ZbG15UGtQZytheFNv?= =?utf-8?B?TmdsaGhRZTlaU2tyVVFxbmdremJKQ1IvUlBQRWUzMTRkaWQ5b0E5T09uTU56?= =?utf-8?B?bjdKbkhEQjh3TExZTThkeHZIV2dFSS8xMmVDZnhHUUg0RXRoN01RcWdyU1JD?= =?utf-8?B?T09iWE9YdmdHYTBnS1g2WHdyakJLS09od1VPZ0xFZlI2dUg2TElsQzVRYkZn?= =?utf-8?B?SlRFQ2dNdTI0Yjc3MndGQzBMcGlyTmtzcWE4ZWRKWXNsS2VnODBXQlo0UGtX?= =?utf-8?B?MnRhbk5WS3RpRitaOElEUE9OWU1yOWN3cWI3MmlLd3JMRnN1Y0JOaGM1SzU5?= =?utf-8?B?UGlyK0dScFNWNnRsdjROcm8xWWw3NzVEelBkVVZRRHBSbFJGWVIyZDBrejlR?= =?utf-8?B?MWFPMEhaUUFPTVpwcEVhbkRQMWdreGw2a1p2WDVnYjdMb09PTDU1eGxSTXpo?= =?utf-8?B?eU5WaW10SEtMSUo1TmFYM2t2Y1l4Ty9MSDIyOEk4VERRR1FPdnRpaVVxTnBm?= =?utf-8?B?TzIwOVFWTjNBbjVsMTd2WjVET2FkSStLNzcxS2p0QTR1bXc3dS9PV3NCd21S?= =?utf-8?B?QWNnaW4yWWhFS0NTRUQ5NDBEUkJHM0VkbDAxenRiZ3VjN3ZpYkthUTM2UDBm?= =?utf-8?B?VTdBazA0OEZFQVNmWUJUcnZtdU00cHZSQXFkRzdRWXJMRktHZ25BajJwOWND?= =?utf-8?B?K2Rmb1ZSR2RJdG9wWHlXSmpiRVh5N1YraTlTOS93eUpzMWRUT2FPVXY4RCtT?= =?utf-8?B?cHFOZko1bG41dGs4WDVIV2NxS3ZrOFNnWnhOUU9BM0k4NjBBbGwvTUFPaENO?= =?utf-8?B?SWI2Qlczb3FwUjNFVjlTdUhQcGFOanpDQ0FvME5DVVduZmlZcEZjRmZFenlY?= =?utf-8?B?ajA1SDdEV1NDdmp4Z0xVdTVWTlpEZng2V0QrMVpCb05wSHB0RlVzampxSldZ?= =?utf-8?B?a0Z5bllHNXNWdlVwcGczMDhTaCtXdU9rU0doQTFUZlU2b2lpMG5vQzhYVHcz?= =?utf-8?B?NGZ5aFYyZ0NhblNLditjUi9VZk1IVFRaajJLa0dEd1hpUTJXamU2UldpcGFC?= =?utf-8?B?eTR1U1MvcUlXMjdiSVhYcVlNSzJNRElyd3ppdHpOenU3R2s5VEZ0MjY1R0Zp?= =?utf-8?B?NlFTOVVZRU9wcHRabHgzTGRmQzZweWRHOVBkQlpaekRhSklQbFR5ZmU5OElm?= =?utf-8?Q?ZkmZ0u0T3AzIQ?= X-Microsoft-Exchange-Diagnostics: 1; SN2PR03MB2367; 6:9u6C+3QlDUDAOV7EXlsImUj6I47SX/xss9PL0FuKe3dsQ28Uiz55MsfF9kYqYskG2X3oc9AJdRXFEfLK8/mTgSfNItWv1k8Onf86CicuHK/zvog0Zy7fJSZI4MTm3KxL5kZXXSE4XyeSN5nP/JCGGAdk59cOtSfa0HtQ2TMoUAWZvKUKjuL6IPlQzmPUQDTPpZ6O+AhpnQTP7cFKWByVTKi5EeG4O/kAJkzTQrjjvyw2Jw2xR696JNkt5/xhBWjO+9yQSROgGq3VMSzoVZpUIRKVWMednga2AV37Tyjy4EELGELCIVA+jgpymjKrMuyCTPsYNQtvUSaGsBWKW2Uu+LAYFogN+c/OUSJV4AQaJwU=; 5:lDOXfUCw9wp6/BCr0t6WI3usHY23zrCrTsvgvtjUwq4/sZ7d5WmzN2ygnA5SXdnKmhGUwvU+e/tiPSMFjfJSUJrqhbaWmqYZJSQNHOvBiR4NqF50oLohXRbzx2DRsrmTFYr+HEwCWEU7Hxs1I/ITY11/daimOoRj5lvW75g0Vg0=; 24:dXypZXlDV41LuqM/IKbhpN/TCYKQ6BL6Hed/uFH1pE4IQoIElatLrM8kBTYM9bRTeCff3FsZNpTSzcu37aK8v8bMahPbghJtSsi7ddkL0Qk=; 7:kalwXKiTbUtVHfPUKe4aETM2+hJWh+ooWbOG+NeWtGMG5WLj5DzmwyHx7XTbFK2h6huSidwKetENIvbwZ+30vVYM8A6lPssrzgJM0/B2+l8gfs8UM+OGOXfnf7gUE1RooZt0LidpkmO3k3ORYnDtKvqcuEYojRlhAsPXt3GHfG9T4FqaGDUeAajPKSdjlVUDPyWhoxBHr+T0G7lNpYw3lAZuH8rYrh2FoleuGcWa3fs38tFQmPevhFdpoOtxvCEF SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2018 15:24:55.2804 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4d9c7c28-e2b5-4ef3-e7c1-08d55f50ce94 X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR03MB2367 Subject: Re: [dpdk-dev] [PATCH v8 3/3] ring: introduce new header file to support C11 memory model X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jan 2018 15:25:03 -0000 HI Jia, On 1/17/2018 2:17 PM, Jia He wrote: > > Hi Thomas > > On 1/17/2018 4:24 PM, Thomas Monjalon Wrote: >> 17/01/2018 05:03, Jia He: >>> To support C11 memory model barrier, 2 options are suggested by Jerin: >>> 1. use rte_smp_rmb >>> 2. use load_acquire/store_release(refer to [1]). >>> CONFIG_RTE_RING_USE_C11_MEM_MODEL is provided, and by default it is "n" >>> on any architectures so far. >> In previous patches, it was enabled for ARM. >> You decided to not enable it at all? > Sorry, maybe I misunderstand your previous mail. >>This config option should be added in the common file (as disabled). > Do you mean CONFIG_RTE_RING_USE_C11_MEM_MODEL=n in comm_base and > "y" in armv8 config? > > Cheers, > Jia >> >>> config/common_linuxapp | 2 + >> It should be defined in common_base, not common_linuxapp. >> >>> --- /dev/null >>> +++ b/lib/librte_ring/rte_ring_c11_mem.h >>> @@ -0,0 +1,193 @@ >>> +/*- >>> + * Copyright(c) 2017 Intel Corporation. All rights reserved. >>> + * All rights reserved. >>> + * >>> + * SPDX-License-Identifier: BSD-3-Clause >>> + */ >> It is not complying with the template. >> Please check the license/ directory. >> >> Why is it Intel Copyright? >> "All rights reserved" is probably not needed. SPDX shall be first line. Agree, why are you copyrighting it to Intel? >> >>> +/* >>> + * Derived from FreeBSD's bufring.h >>> + * >>> + >>> ************************************************************************** >>> >>> + * >>> + * Copyright (c) 2007-2009 Kip Macy kmacy@freebsd.org >>> + * All rights reserved. >>> + * >>> + * Redistribution and use in source and binary forms, with or without >>> + * modification, are permitted provided that the following >>> conditions are met: >>> + * >>> + * 1. Redistributions of source code must retain the above copyright >>> notice, >>> + * this list of conditions and the following disclaimer. >>> + * >>> + * 2. The name of Kip Macy nor the names of other >>> + * contributors may be used to endorse or promote products >>> derived from >>> + * this software without specific prior written permission. >>> + * >>> + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND >>> CONTRIBUTORS "AS IS" >>> + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED >>> TO, THE >>> + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A >>> PARTICULAR PURPOSE >>> + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR >>> CONTRIBUTORS BE >>> + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR >>> + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF >>> + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR >>> BUSINESS >>> + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, >>> WHETHER IN >>> + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR >>> OTHERWISE) >>> + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF >>> ADVISED OF THE >>> + * POSSIBILITY OF SUCH DAMAGE. >>> + * >>> + >>> ***************************************************************************/ >>> >> This double license may be an issue. >> Hemant, comment? >> > Check my response in your other patch. This is not a DPDK acceptable license. It need approval from GB. I could not locate a BSD-3 version of bufring.h What can be accepted in this case, without GB approval: BSD-3 only license + Keep copyright of Kip Macy + Put statement that Kip Macy allowed it for BSD-3 uses. Or, Your company (the copyright owner) is re-licensing the original "BSD-2-freebsd" as "BSD-3". + keep the Derived from statement.