* [dpdk-dev] [PATCH] app/testpmd: fix flow query failure
@ 2018-10-10 17:04 Mordechay Haimovsky
2018-10-10 18:56 ` John Daley (johndale)
2018-10-11 9:29 ` Adrien Mazarguil
0 siblings, 2 replies; 6+ messages in thread
From: Mordechay Haimovsky @ 2018-10-10 17:04 UTC (permalink / raw)
To: Adrien Mazarguil, Shahaf Shuler, Ori Kam; +Cc: dev, Mordechay Haimovsky
This patch fixes a bug found in port_flow_query routine which caused
flow query command to fail with the following error "Caught error
type 1 (cause unspecified): unknown object type to retrieve the name
of: Invalid argument".
Fixes: f7ba5e7a0f8c ("app/testpmd: rely on flow API conversion function")
Signed-off-by: Moti Haimovsky <motih@mellanox.com>
---
app/test-pmd/config.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 009c92c..b11317b 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -1239,7 +1239,8 @@ void print_valid_ports(void)
return -ENOENT;
}
ret = rte_flow_conv(RTE_FLOW_CONV_OP_ACTION_NAME_PTR,
- &name, sizeof(name), action, &error);
+ &name, sizeof(name),
+ (void *)(uintptr_t)action->type, &error);
if (ret < 0)
return port_flow_complain(&error);
switch (action->type) {
--
1.8.3.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] app/testpmd: fix flow query failure
2018-10-10 17:04 [dpdk-dev] [PATCH] app/testpmd: fix flow query failure Mordechay Haimovsky
@ 2018-10-10 18:56 ` John Daley (johndale)
2018-10-11 10:40 ` Mordechay Haimovsky
2018-10-11 9:29 ` Adrien Mazarguil
1 sibling, 1 reply; 6+ messages in thread
From: John Daley (johndale) @ 2018-10-10 18:56 UTC (permalink / raw)
To: Mordechay Haimovsky, Adrien Mazarguil, Shahaf Shuler, Ori Kam,
ferruh.yigit
Cc: dev
Ok, makes sense now, both flow query and flow list work with this patch, yeah.
Tested-by: John Daley <johndale@cisco.com>
Remember that https://patches.dpdk.org/patch/46221/ still needs to be reverted out of dpdk-next-net/master otherwise we are still broken. The patch was squished into e5b652ea34.
-johnd
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Mordechay Haimovsky
> Sent: Wednesday, October 10, 2018 10:05 AM
> To: Adrien Mazarguil <adrien.mazarguil@6wind.com>; Shahaf Shuler
> <shahafs@mellanox.com>; Ori Kam <orika@mellanox.com>
> Cc: dev@dpdk.org; Mordechay Haimovsky <motih@mellanox.com>
> Subject: [dpdk-dev] [PATCH] app/testpmd: fix flow query failure
>
> This patch fixes a bug found in port_flow_query routine which caused flow
> query command to fail with the following error "Caught error type 1 (cause
> unspecified): unknown object type to retrieve the name
> of: Invalid argument".
>
> Fixes: f7ba5e7a0f8c ("app/testpmd: rely on flow API conversion function")
>
> Signed-off-by: Moti Haimovsky <motih@mellanox.com>
> ---
> app/test-pmd/config.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index
> 009c92c..b11317b 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -1239,7 +1239,8 @@ void print_valid_ports(void)
> return -ENOENT;
> }
> ret = rte_flow_conv(RTE_FLOW_CONV_OP_ACTION_NAME_PTR,
> - &name, sizeof(name), action, &error);
> + &name, sizeof(name),
> + (void *)(uintptr_t)action->type, &error);
> if (ret < 0)
> return port_flow_complain(&error);
> switch (action->type) {
> --
> 1.8.3.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] app/testpmd: fix flow query failure
2018-10-10 18:56 ` John Daley (johndale)
@ 2018-10-11 10:40 ` Mordechay Haimovsky
0 siblings, 0 replies; 6+ messages in thread
From: Mordechay Haimovsky @ 2018-10-11 10:40 UTC (permalink / raw)
To: John Daley (johndale),
Adrien Mazarguil, Shahaf Shuler, Ori Kam, ferruh.yigit
Cc: dev
Already done by Ferruh.
See attachment.
Thanks
Moti H.
> -----Original Message-----
> From: John Daley (johndale) [mailto:johndale@cisco.com]
> Sent: Wednesday, October 10, 2018 9:56 PM
> To: Mordechay Haimovsky <motih@mellanox.com>; Adrien Mazarguil
> <adrien.mazarguil@6wind.com>; Shahaf Shuler <shahafs@mellanox.com>;
> Ori Kam <orika@mellanox.com>; ferruh.yigit@intel.com
> Cc: dev@dpdk.org
> Subject: RE: [PATCH] app/testpmd: fix flow query failure
>
> Ok, makes sense now, both flow query and flow list work with this patch,
> yeah.
>
> Tested-by: John Daley <johndale@cisco.com>
>
> Remember that
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpat
> ches.dpdk.org%2Fpatch%2F46221%2F&data=02%7C01%7Cmotih%40me
> llanox.com%7C554abadea7134471dc7e08d62ee21143%7Ca652971c7d2e4d9b
> a6a4d149256f461b%7C0%7C0%7C636747945816028762&sdata=7eVxVq0
> AoN0hRVR%2Bb3bQvub5Q%2BXge6Cw9UqripZIWyk%3D&reserved=0
> still needs to be reverted out of dpdk-next-net/master otherwise we are still
> broken. The patch was squished into e5b652ea34.
>
> -johnd
>
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Mordechay Haimovsky
> > Sent: Wednesday, October 10, 2018 10:05 AM
> > To: Adrien Mazarguil <adrien.mazarguil@6wind.com>; Shahaf Shuler
> > <shahafs@mellanox.com>; Ori Kam <orika@mellanox.com>
> > Cc: dev@dpdk.org; Mordechay Haimovsky <motih@mellanox.com>
> > Subject: [dpdk-dev] [PATCH] app/testpmd: fix flow query failure
> >
> > This patch fixes a bug found in port_flow_query routine which caused
> > flow query command to fail with the following error "Caught error type
> > 1 (cause
> > unspecified): unknown object type to retrieve the name
> > of: Invalid argument".
> >
> > Fixes: f7ba5e7a0f8c ("app/testpmd: rely on flow API conversion
> > function")
> >
> > Signed-off-by: Moti Haimovsky <motih@mellanox.com>
> > ---
> > app/test-pmd/config.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index
> > 009c92c..b11317b 100644
> > --- a/app/test-pmd/config.c
> > +++ b/app/test-pmd/config.c
> > @@ -1239,7 +1239,8 @@ void print_valid_ports(void)
> > return -ENOENT;
> > }
> > ret = rte_flow_conv(RTE_FLOW_CONV_OP_ACTION_NAME_PTR,
> > - &name, sizeof(name), action, &error);
> > + &name, sizeof(name),
> > + (void *)(uintptr_t)action->type, &error);
> > if (ret < 0)
> > return port_flow_complain(&error);
> > switch (action->type) {
> > --
> > 1.8.3.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] app/testpmd: fix flow query failure
2018-10-10 17:04 [dpdk-dev] [PATCH] app/testpmd: fix flow query failure Mordechay Haimovsky
2018-10-10 18:56 ` John Daley (johndale)
@ 2018-10-11 9:29 ` Adrien Mazarguil
2018-10-11 10:15 ` Ori Kam
1 sibling, 1 reply; 6+ messages in thread
From: Adrien Mazarguil @ 2018-10-11 9:29 UTC (permalink / raw)
To: Mordechay Haimovsky; +Cc: Shahaf Shuler, Ori Kam, dev
On Wed, Oct 10, 2018 at 05:04:56PM +0000, Mordechay Haimovsky wrote:
> This patch fixes a bug found in port_flow_query routine which caused
> flow query command to fail with the following error "Caught error
> type 1 (cause unspecified): unknown object type to retrieve the name
> of: Invalid argument".
>
> Fixes: f7ba5e7a0f8c ("app/testpmd: rely on flow API conversion function")
>
> Signed-off-by: Moti Haimovsky <motih@mellanox.com>
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
--
Adrien Mazarguil
6WIND
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] app/testpmd: fix flow query failure
2018-10-11 9:29 ` Adrien Mazarguil
@ 2018-10-11 10:15 ` Ori Kam
2018-10-11 10:26 ` Ferruh Yigit
0 siblings, 1 reply; 6+ messages in thread
From: Ori Kam @ 2018-10-11 10:15 UTC (permalink / raw)
To: Adrien Mazarguil, Mordechay Haimovsky, Ferruh Yigit; +Cc: Shahaf Shuler, dev
> -----Original Message-----
> From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> Sent: Thursday, October 11, 2018 12:30 PM
> To: Mordechay Haimovsky <motih@mellanox.com>
> Cc: Shahaf Shuler <shahafs@mellanox.com>; Ori Kam <orika@mellanox.com>;
> dev@dpdk.org
> Subject: Re: [PATCH] app/testpmd: fix flow query failure
>
> On Wed, Oct 10, 2018 at 05:04:56PM +0000, Mordechay Haimovsky wrote:
> > This patch fixes a bug found in port_flow_query routine which caused
> > flow query command to fail with the following error "Caught error
> > type 1 (cause unspecified): unknown object type to retrieve the name
> > of: Invalid argument".
> >
> > Fixes: f7ba5e7a0f8c ("app/testpmd: rely on flow API conversion function")
> >
> > Signed-off-by: Moti Haimovsky <motih@mellanox.com>
>
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
>
> --
> Adrien Mazarguil
> 6WIND
Acked-by: Ori Kam <orika@mellanox.com>
Thanks,
Ori
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] app/testpmd: fix flow query failure
2018-10-11 10:15 ` Ori Kam
@ 2018-10-11 10:26 ` Ferruh Yigit
0 siblings, 0 replies; 6+ messages in thread
From: Ferruh Yigit @ 2018-10-11 10:26 UTC (permalink / raw)
To: Ori Kam, Adrien Mazarguil, Mordechay Haimovsky; +Cc: Shahaf Shuler, dev
On 10/11/2018 11:15 AM, Ori Kam wrote:
>
>
>> -----Original Message-----
>> From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
>> Sent: Thursday, October 11, 2018 12:30 PM
>> To: Mordechay Haimovsky <motih@mellanox.com>
>> Cc: Shahaf Shuler <shahafs@mellanox.com>; Ori Kam <orika@mellanox.com>;
>> dev@dpdk.org
>> Subject: Re: [PATCH] app/testpmd: fix flow query failure
>>
>> On Wed, Oct 10, 2018 at 05:04:56PM +0000, Mordechay Haimovsky wrote:
>>> This patch fixes a bug found in port_flow_query routine which caused
>>> flow query command to fail with the following error "Caught error
>>> type 1 (cause unspecified): unknown object type to retrieve the name
>>> of: Invalid argument".
>>>
>>> Fixes: f7ba5e7a0f8c ("app/testpmd: rely on flow API conversion function")
>>>
>>> Signed-off-by: Moti Haimovsky <motih@mellanox.com>
>>
>> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
>>
>> --
>> Adrien Mazarguil
>> 6WIND
>
> Acked-by: Ori Kam <orika@mellanox.com>
Squashed into relevant commit in next-net, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-10-11 10:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-10 17:04 [dpdk-dev] [PATCH] app/testpmd: fix flow query failure Mordechay Haimovsky
2018-10-10 18:56 ` John Daley (johndale)
2018-10-11 10:40 ` Mordechay Haimovsky
2018-10-11 9:29 ` Adrien Mazarguil
2018-10-11 10:15 ` Ori Kam
2018-10-11 10:26 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).