From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0082.outbound.protection.outlook.com [104.47.32.82]) by dpdk.org (Postfix) with ESMTP id BD5902BB5 for ; Tue, 16 Jan 2018 11:07:17 +0100 (CET) Received: from CY4PR03CA0020.namprd03.prod.outlook.com (10.168.162.30) by BN6PR03MB2692.namprd03.prod.outlook.com (10.173.144.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.407.7; Tue, 16 Jan 2018 10:07:16 +0000 Received: from BY2FFO11FD018.protection.gbl (2a01:111:f400:7c0c::162) by CY4PR03CA0020.outlook.office365.com (2603:10b6:903:33::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.407.7 via Frontend Transport; Tue, 16 Jan 2018 10:07:15 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BY2FFO11FD018.mail.protection.outlook.com (10.1.14.106) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.345.12 via Frontend Transport; Tue, 16 Jan 2018 10:07:15 +0000 Received: from [10.232.14.39] ([10.232.14.39]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id w0GA7CFV028735; Tue, 16 Jan 2018 03:07:13 -0700 To: Thomas Monjalon CC: , , , References: <20180102125749.2379-1-shreyansh.jain@nxp.com> <20180102125749.2379-4-shreyansh.jain@nxp.com> <3616426.fmUHyIAH1S@xps> From: Shreyansh Jain Message-ID: Date: Tue, 16 Jan 2018 15:51:27 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <3616426.fmUHyIAH1S@xps> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131605708356137521; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(39860400002)(39380400002)(376002)(346002)(396003)(2980300002)(1109001)(1110001)(339900001)(199004)(189003)(24454002)(305945005)(65806001)(47776003)(36756003)(2906002)(966005)(8936002)(81166006)(81156014)(356003)(104016004)(8656006)(8676002)(26005)(83506002)(65956001)(86362001)(97736004)(50466002)(67846002)(498600001)(58126008)(65826007)(85426001)(31686004)(6666003)(2950100002)(6916009)(54906003)(31696002)(2486003)(64126003)(23676004)(76176011)(6306002)(59450400001)(4326008)(230700001)(53376002)(229853002)(316002)(6246003)(105606002)(106466001)(53936002)(5660300001)(77096006)(68736007); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR03MB2692; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD018; 1:t3N0H4y6r9U2fmasJEmaGI+kY1bMpTwHL57t7SvnfRdhziPbpPRMDK7J7sgFD7APvKB6Op963Sd+t7y+qS+6P0ffOTyiC76ToISaMQX06tCHK1dTwEoHaZW2OU4Hef7g X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8ecd3bd5-8a33-43a5-d0ce-08d55cc8eb6f X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(5600026)(4604075)(2017052603307); SRVR:BN6PR03MB2692; X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2692; 3:6unGVr24npWBcXuDay+iWFVxalhj3q0R+J769MhXfgRjEW/3ESM32nzFeCT2mUViNrmL1Jj5uzjPSkqlV2dShZQnpS1u9pgSNbT/jl9WtwgM+BkVV8+xmuSFZR7hsqOYDIO5kmobmDzOihqdhPe81egoh2qkAJGzBrEbWOLBZ/vobBsfh+d/EjPfFfV1nRjE/i+XMxvFGSOQ8nI/9KZ60ax8KD04ppQWW8WMLZXStk2JromFF49Y5sLhn1tDXEacDL+yt83qNVA4IedHKiSY2xHvOEM/d6Kx/Sf/2dSjPRDfBnG1v3w4GL++6WNjp4xn/Mh1AqZ+tdu7g+rzuf6WGBchRGOHgRN7D1Rm0iSkRvQ=; 25:/z5lSVVZ3Iu98Nbj/7p/d7i7in5RmjQMtmw/ieaNdNLcCVy2FwJ6sgx2HiiXXJk0hvl8RoY0XcKZuLxviJY5720v7XOT3U5TuWMyuCCh1yE/SsQbyAL3ati9us4UdNYq9atNgykbSQqp5VhvG8EINkLMncII7sUkfRNfOg+1mulOfCidPOkg/mUK8Tly1gLqoHn5g/NHgBsxlhSWMBulR/Dc87CebefMxkV0fbrQthBWfGwdrbRGaxSooo6nAWhbe3iMu5J2E7yzKO0TOdBh6TF//V3/mp7lxhiLu7XLwNmb0PICe/VBdy4Qqfv86Mc/rnazZTx3xgzzfCyMoxYJLA== X-MS-TrafficTypeDiagnostic: BN6PR03MB2692: X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2692; 31:6/KyGO5tjIh/60Gn6oBNoqDGX8Qk0wc93DdilGaoxmvIrlR+2gjA3DKcAzPqguCGtJGZcS90yGIzKil522Kws7KEziOdvdNnqYjFNjpMckwqGge7ghHdfEEUOm3CtYWbAmag8wdgqedGCkvEew6hlCqVvHIRklMqm6QugyshuQUhfwi7xvqonK6XHbhMrvwCHpx0qjLAZVYljLL+ej6nmkN/74JyEWS3kVKH10ysX+0=; 4:YsEzXfiVMou1v0+Q1gPgW3YP7S6DHDRvZJ7QELzFTO3LSSZCANpQvho0PPv+7PhQAuPxD1QCzkT1Q7K4hfvV8S7mufSWeh7Izw3nimwIZfWah366anrZ61hBbT6TE4XdXu8y0eGe+O43lNSUowDj1IKIkGQuZ7TeAc6QIqdKmCQfV+uBo93hWzt6zOoJSdYISedhx1Vrocd2SCZPlGWKIFQW0gFm3kLHSM7MnST+x4EZKXiWrxskbu8FwtIiv6YHKdtOmND4exPEalARJ1i9nA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095135)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3002001)(3231023)(944501161)(6055026)(6096035)(20161123556025)(20161123565025)(20161123561025)(20161123563025)(201703131430075)(201703131448075)(201703131433075)(201703151042153)(20161123559100)(201708071742011); SRVR:BN6PR03MB2692; BCL:0; PCL:0; RULEID:(100000803101)(100110400095)(400006); SRVR:BN6PR03MB2692; X-Forefront-PRVS: 0554B1F54F X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjZQUjAzTUIyNjkyOzIzOlFNVng4U3FPS2tPVUlQcWhYb2RQcDdJZSsv?= =?utf-8?B?L1hRK3FrRmNDdmgzdUJmbXJmVEtvd2ltR1htSFJBcURMTFNkdzV5ODhzbW5a?= =?utf-8?B?Rllwci9DMFU2Z0thSkZDNEw3NHNCZU5LdElaZlZlZEJFVHJSVHVPZGp6U3ht?= =?utf-8?B?RFdWZ0VXN1FlMlFZUVVhMXdXZEZnL2JQU0ZYMWJ2YVk1SWFubWFXU2s3Mnhk?= =?utf-8?B?c3Jxc2RXdXBXTWdIeEU1ZDlUWVB3Rmh4c1VDbnFidFEyY3ovdGplazlsdmJF?= =?utf-8?B?NmRYYW9TT0VadjltbTlHaW8wZEtjbWdhVkdNa2RJenl6YVYraGFXbk5zM0pF?= =?utf-8?B?MDBLSnpac0M1ZVFGUGNvWkFtWnhSRXRKUmlneUpldTlHMGJVeU8wQ3VWcWJm?= =?utf-8?B?dVRRcWxzbXJjK0lzbWdkdnU0R1FCRUNHbHk0eDQ3Y3Rxelg3TkJySkdNVVNM?= =?utf-8?B?OExEUXFSaVRFbUV2Q0xLdUdqd2FnWVI3UGQvdFhOUTIxL3FTQ05CT2tBZE4v?= =?utf-8?B?dUdYTmpLNGhmdjlHOVM2R1VTWHVYRHBwYTJwaS9GWHMrR3VCZW1SZDl1cFQx?= =?utf-8?B?OEYrOFoyR3J3a29JU2hCblJqVHNOTUxLZE9ZT2RMYkRQTkUwNDgvdFM0MkU1?= =?utf-8?B?dW1mRFhJTlVMMnowMlNCQTdDSHRyeGNtVlIxN0tUaVpJSWRIM0x5c1hSb2Vj?= =?utf-8?B?aElCTkxOZ29PSU5vdGd2NGszMGZQcW0rMWQ2YU9hOEFNT1VaUUsvOFlkNThC?= =?utf-8?B?ZW5ZcHlFemNwa1AvRllmd25ROEorYkhxZ2NHUndmZHNVUzYvV204b1d0SG94?= =?utf-8?B?QU10S1FOYS84d05VcEpMRWxCVFJ2Z05od0FYK3lBeW03UW41LzFXK0JXYm5W?= =?utf-8?B?OEsvUzdneXkyRGwxRzE4TUh4dVJyL0F3ZlJCRjlRNnh0U0ZlaDNkRlh5TUM0?= =?utf-8?B?YXQ3VVQ2UVhjcFZ0L1BXTVkzN2hTR1Bac2tNR0tJVzkwaG9pQkZCUmZ2UFQv?= =?utf-8?B?ZDdQRFpuZE4ranZPR3lOOXM2cW1hM3BCSEYyUlRrcnJZRFU3VENJdmxST0Nq?= =?utf-8?B?cHBIU1lNeUtFUGQ2eWNqYld3Z2NTbEVsNEVTbFJ4TXNBdGY1dmxjaTY1TC9p?= =?utf-8?B?WXRDK0lpOEN4ODRwWWZ4Z2hNTUJQV2FhT0NwNDdCa0ljdzNCOFpqbXFkdlFY?= =?utf-8?B?RFhXNHpqVVVveDdMYmNIRUhjZzZnZE9pRS9jeWtscnd2alZSdzJwc094a29Y?= =?utf-8?B?cVZtQkt2U1pscnRxZDMvR2dVTXc0bDVFcmpXL1piQ0xzV01NWXBvV2RnN0kv?= =?utf-8?B?clVQVzUvOVA4R1pJMnJ5cWdQc2hJWm50MlU5RWRLWGs4Z3dWZVVIVWRYTkpt?= =?utf-8?B?bVhGSHgxUkdEa0JDTTh3V1RSRHhQLzErejVjVjVtV0V5d2lEek1yeUlURGg0?= =?utf-8?B?MmRRTTlrN2t0dk9QR0lXdEVVY2kremlYRzNwQ0owS1ZwQUN5VTRvODh5SVZm?= =?utf-8?B?U054WFgwcmVidy9Ia3pMMHlDWjkyVnc3c3lvRUs0aHhQNGdoQ00vdUV0S21m?= =?utf-8?B?ZmxhaXRiMHFaRVJuOHBQVWI5eHFRRjBmZUJmbUZJSHZTeWdwN3BpVFRrQjhX?= =?utf-8?B?RmM3QUl4YWdIYzdFK1doR1hyalJJY044THhBc2JrL2dJd25lUmtiLzdQRHV1?= =?utf-8?B?V2xPLzFPUHEyVU5JUHZ3VFJOSmFwc3dUL1pCTHZhTWVnRVRCNERKOERndW5P?= =?utf-8?B?N212UmNPWG5sbDFCS2FXdVBUWHhteG01R0JOdDBiS3I4NEFvZSs2T29kUUQx?= =?utf-8?B?Z2JBS2Y1dUtvYlFRYWx5d3dIRUhaaURTdHE3azhTeHo3cURaOEFva1RNclZk?= =?utf-8?Q?GV/Qy3RcTmE=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2692; 6:/AxMGuGUNO43O/r0nrNmdmSkl9MAG29aYChNTW/oBU/+pQKrkoixuNMn0lsHL+7gOCnhbcvdaV6Mga2I+fNJfKBRhYayGOFdhb0u8msItUmAyIIdRdQ76uhHL071hDOmeuNhr/zNGFMThJdLpMyIdZI1F270wbODFvkCx0igRV+mpROj3KTzM0+CNayDs5ZJ4k7dRoQu22enN357A0f/zpzxYjPSE/Oq95LEczCYCrpJ4lra3lVT6QzuZOfh5U0PVoEL+IHtfxhhMmbuXz/9PRLZghjBlrjKmHrtYP189Ap5ygaFgNH28GY6Uarunc0G9LMtzXcfQrzU48wPYro2Tl3U3HXdwTKx4FcWoSGrru0=; 5:+8QjShcX7GAA/5jqO7C41VllW+SyEKrMamXaQcJjjRUyqyBmvsVJc79KHxBnX4GLdmydE83vdbM3vWM7/WRlIpVQvxjARxfPq7ue8Im0zTG1MsPinnouz0lb6GX1dTPmmk/ZjBqEbRNtmXLPlv5pWvez9XAqOa8cYVccPgqXmCA=; 24:rx5yn1HQNp3Yt8TceNfAF3KX21Lb56pP5nDK6Q8uUwL+4Fw29R+HosYUDaP96hvAUkQg+fFF8zll7iiq3o4XB5rfnL4DHJ1o9DaXNxr10hE=; 7:f8FEjNIZzWV/7KXOBf9RJxt8R8DX8VFPqx0UDnFOdbb7OX7zDOyCNYwDqvazyp4ttbZyiZ5hWuNlmz4QrDkM8JQATBhONn/d8SC4f16r3qDAPp7bpXKmI9ae7rG3D4Goiyf3DCkhpYSF5p8dvbw77Q3OaLpURMjQOXubJMFIozYDsUV1UXs5t7itRlmtwcuq198CtCsOKdwtBY7AzlwyDyAtHO+h/+vR9LcYXII+vBgP7OOFnlTuLnHMNzxdRsWe SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jan 2018 10:07:15.4109 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8ecd3bd5-8a33-43a5-d0ce-08d55cc8eb6f X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2692 Subject: Re: [dpdk-dev] [PATCH v1 3/5] drivers/raw: introduce skeleton rawdev driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jan 2018 10:07:18 -0000 On Monday 15 January 2018 04:24 AM, Thomas Monjalon wrote: > 02/01/2018 13:57, Shreyansh Jain: >> +struct skeleton_firmware { >> + struct skeleton_firmware_version_info firmware_version; >> + /**< Device firmware information */ >> + enum skeleton_firmware_state firmware_state; >> + /**< Device state */ >> +}; >> + >> +#define SKELETON_MAX_ATTRIBUTES 10 >> +#define SKELETON_ATTRIBUTE_NAME_MAX 20 >> + >> +struct skeleton_rawdev_attributes { >> + char *name; >> + /**< Name of the attribute */ >> + uint64_t value; >> + /**< Value or reference of value of attribute */ >> +}; >> + >> +#define SKELETON_CAPA_FW_LOAD 0x0001 >> +/**< Device supports firmware loading/unloading */ >> +#define SKELETON_CAPA_FW_RESET 0x0002 >> +/**< Device supports firmware reset */ >> +#define SKELETON_CAPA_QUEUES 0x0004 >> +/**< Device support queue based communication */ > > Comment about the style. The style is important :) > You are always writing comments after the item. Yes, I was trying to stick to single method - postfix. > When comments are on a separate line, I think it is preferred to write > them *before* the item they describe. > Consider this: struct dummy { int a; /**< a postfix comment */ /**< a prefix comment */ int b; }; Personally, Even I prefer prefix when it comes to full line comments - but mixing prefix and postfix can lead to non-readable code. Anyways - I was referring [1] [1] http://dpdk.org/doc/guides/contributing/documentation.html#doxygen-guidelines and it seems that I should change all to prefix in case any comment in the structure is not fitting into a single line. I will do that. Regards, Shreyansh