From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 99D73A00C5; Mon, 31 Oct 2022 14:41:00 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 30FE140223; Mon, 31 Oct 2022 14:41:00 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2066.outbound.protection.outlook.com [40.107.93.66]) by mails.dpdk.org (Postfix) with ESMTP id 36DAB40151 for ; Mon, 31 Oct 2022 14:40:58 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ny4jnHWrM9DtpmiFOG06dJyNsOVDHs6c0NS/X2+tYHrMCUfrVf3Vjw6MlvZ5mWbOfXH6Vi9l0L2xtzok3JOfV1pmc5EsCC64ohWOIgnf941t3jJ9BAdW0JLkc59YQ18eDDuOQn7Fm9ohuzGN3CIo1mAB2ETxK9AOg2FlDF7jx9TjxgD9gbObw1zxei7gKzItvikOLJyCUZPuc6l3f1+hZ2XzvOX6mgrOCF9taeFPG3ck0e514zwXku5nOogR/sr5q9nrvW2fRN30XuiRw2NEX9Yh7wvWfKNtsppeVHPCohNVhzXGuatkc+v4WkmvahMVOeMSlhAnYIWwjTODBJ7nwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N4G3co4CfujRQwkxASsTGI8CSRgN6cI0e+b5HwhPrRI=; b=AjS2KFdIOaGZVKNJ3dINE3MtI9yM9B9D/rY1q+gPkl0rgQVaIS4UDoh480pkExfdgUd23AbbwSPbmSENMh4CMEA9l3RDAD1veeKuidV1SbRhTYpF+n6gcu0NEsRW/A+3byNQwFly3d1t2J8nONKCqW73oZZp0UY3Wo59MUXIfFYJuokzcnvbbeYznY7GYcbvqaIu58tmkTUHtbZw1/s5d7TSiBrmJq1Z6m6+b3b270wG7w6z6X3SIuOygR0GHx+TeYQ14Wzuht3c1iFyDpXcmUhDxFuoMZ9nboJPqM36Jvfc3kK1we4MMXjQ5kQuCn/KlCJK3G3J3S7D5BrTv+1peA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N4G3co4CfujRQwkxASsTGI8CSRgN6cI0e+b5HwhPrRI=; b=h1OIcqcaXFQsLN83ZRr41xVse2iERB0jLuvWpBG33rTtC+hQDA5dwF0PUdpe1nEtZACFIvsqvzBGQO/ZdD8ueUF5ydwXJ0ClMv15IOuqdl9FBkxuSeIFGzr+t8qko43m/Tm0S30acbZQPXRvlRNW2kfpRg98Bi02LSktw2p5V20= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) by DM4PR12MB6280.namprd12.prod.outlook.com (2603:10b6:8:a2::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.19; Mon, 31 Oct 2022 13:40:56 +0000 Received: from DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b9fd:e732:4585:6b25]) by DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::b9fd:e732:4585:6b25%7]) with mapi id 15.20.5769.016; Mon, 31 Oct 2022 13:40:56 +0000 Message-ID: Date: Mon, 31 Oct 2022 13:40:51 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH] net/gve: fix pointers dereference before null check To: Junfeng Guo , qi.z.zhang@intel.com, jingjing.wu@intel.com, beilei.xing@intel.com Cc: dev@dpdk.org References: <20221031050516.2289622-1-junfeng.guo@intel.com> Content-Language: en-US From: Ferruh Yigit In-Reply-To: <20221031050516.2289622-1-junfeng.guo@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0303.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:196::20) To DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB4297:EE_|DM4PR12MB6280:EE_ X-MS-Office365-Filtering-Correlation-Id: ef1ae471-b19a-4f05-d45c-08dabb458971 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6+MqzfnvJKny/YKn7x8aZxqemrW1OPYaCFOdILG9kybUglYKicSyn05dgft8+G7dQD95FM/7tj8e4pg6W9Frg4f6J1iZLndMdwd+Kq6sz9JDT1CtgFrFUMyny7lsqQp7Ha0UuZxzMh6qIbP87Fw548IDxjkBUPeVzjKwzDEg0cwMAy1LHkaoZw8EjxuTANiP1reDAadP352o3Vx67un3jxgqhHFyTjtBL8SkGeHUSrQKB/IG/KNfu5KBzUW4B3knu6zxFXbK34S98pYY7dCQ3In6iBk2sXWIW6ge9l9Tv1NBVBQ6WRhSvJw6Q1F4WuoEq0ZoJdsF2xW2w0yMrrKfLFNR5gPHnrZG+SOQgctKUxQ6Fw7PdNbcucG+mnHwHNoP3oWN1Z2Ky3yoGA5vxKEO/XDShb+4n2698PByLagRzv1SHIAuscaz7BGz8V9izP2WeEcUVJdk5HuvFWUgnm/ITSUUDIyQrabNQz4EjJ7/KNpxw7H5c90Z8bcWUa1yDU5M3PKV5tcsL09vn7Z+Y+nciDvuHCVZfjHuSo/I+fitcPfBYgSQ7r0kASvB+CR5jnsSloLSeS/z58dm+aMHXvyOz4/F6GQYd9TekIxQc76xDnGeFZc6827vlJdSfrWgL82kkyQSqHruQIfMjbF1EsrKRpuhNDWvQqC/9qJGKP1k8S6OxBBSsXVycMFe23F+VxYcJXXa25X9o1tAS63rF4eyVoY53nZ0S8dE+qrPPltGOmy0MdGFCdJgd/wItZAE8xGtoFFipxU7jDVdmlUsd4G2/GfgQrRMwd8x7xGaMHD+AAM= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB4297.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(346002)(39860400002)(376002)(136003)(396003)(366004)(451199015)(8676002)(4744005)(5660300002)(31686004)(44832011)(316002)(4326008)(86362001)(478600001)(31696002)(6486002)(53546011)(6506007)(6666004)(36756003)(38100700002)(186003)(2906002)(66946007)(26005)(6512007)(66556008)(66476007)(2616005)(8936002)(41300700001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Vk9OdjBvV0M1ZzYxRmFRMHZ2ZUpzUEpTd2RtL1hJUnhwTUlaVlVneHlocFlO?= =?utf-8?B?QnpBVjRVN25mOWRHOFZ0SlNoVGo3UU1PTWZMbWQyVUt1TURKT3R6c3N1S3lk?= =?utf-8?B?Z1hzby9pQnlxWkwyOWhjSWRpdHl2NGxPajBvSGMydmQ5TnlzYms4YUFPZTdi?= =?utf-8?B?b3haWXlpYmVyVjV5TXowK3JVczhCc2RiYlcwcUUva1UzNkd4NXdnY1pJa3ZU?= =?utf-8?B?UlFXdGVubkYrcUk2MWJuODR5Rm00UkJsdWRCWTFVaUNQSlp4d0dReTA2UGps?= =?utf-8?B?UEt0dGc0Ykl6NWtDUnNVekRERE1HVnk0YlZoMVVsU0FWM0tDUmwxd05qL2M5?= =?utf-8?B?aWdMTVhFS1VvL2dkQ3BvVXpDWlVJUythMy9sLzhmcTB4UXJkQVhVNnJTeHZr?= =?utf-8?B?WHQ1QlcweEtoZzRPVWJFZWlVem5IQ1RvbmwzOWZrd2U3VHNnRklVTjJjSWtv?= =?utf-8?B?N2hMVUxraHB5djBvY2IrUSs5VTJrNExIcGRIbTBJQk9WQTFwblBORWVoeG82?= =?utf-8?B?OTFtbG95N1QxcmM3b1IvdzlldDVVSE9ISlhaQk45UVpjZW53MHFaZXFlNmk1?= =?utf-8?B?NWdGazE3VVI1NXVlRDlqdWQ2dFljbVFlNFpRQThWUk9WVmFmNk16dmZzRHNZ?= =?utf-8?B?aHUvTkI5Z0dxN0M1SnpsWnhDeU5NY0p0S1BGTmo3SHkwWS9vVmJkZGdJbkdn?= =?utf-8?B?RUU2NUQyVytha2RxSUR5WUl2VmN3MW02UVlZcDl5SVI4QlZXM2FraERNZHg2?= =?utf-8?B?M1lVVm94OWZTeVlGUGRjZlRleEJJV1Z6Q1FTY0ROZXJ3UUY1QzZEWFpCV0Q5?= =?utf-8?B?M1MvaDErTGNJemR3aExEeWcvZ21sYVF2UXUvbGxwV3BwMHRXa1E5eTBIQi9G?= =?utf-8?B?aEFrWlhORkF5czVTMUk0TEZIbzV2Ymp1UHliYjUvQjl6TzZxUUhpL1k1c1NI?= =?utf-8?B?UU1tNnJNVmJPREJFaGF4bmdHbS9VVG90SnpGY29ET09JTHlSaHlKeHNmd042?= =?utf-8?B?b0tkK3BTZjRlOGZXN2I4U3Q2aHBoZ1B1dGwyTGVFYy9PbUpnbUpNbG5tbFdp?= =?utf-8?B?OGQ1YW1OVzFZSVVWeW9HaGY2WDhyM2ZYdGxtLzdwMXg0N1pMeU5Dbk1mUUph?= =?utf-8?B?cGVTK0UrMC9wd2krQlJoZ3AwUDBGWSsxbDdLQnpqc3QraXpkMHgySVM0UUVD?= =?utf-8?B?VHdLajUyd2dwV1QxVUZ4UzBLUVl3aURSVVpVSXNMRDgxcDdDa1dHNFNQYlVH?= =?utf-8?B?dllnL3p6eFl6VW0vcmQwQS92cHY2OGV6dEpINHdHbTJHN2FzN2hZUG5LYjVr?= =?utf-8?B?Y01nZERtNzZzaFRVNmt6dEhrRUQ5cS9ESTFkWFRnTnlzajAvZGhnQmRLRTQx?= =?utf-8?B?eHBuMWNJbnRnYVdOV0JhMmkrTVpNQzFwQ1g2dElQOU5WbzF4YjBERzhpcFFM?= =?utf-8?B?T0I4NTBIbnBtbzdsNm5kNGNOZnZHOVZKeGx6azVtOXpoMWlEdTFQSGo1c0Yy?= =?utf-8?B?Mks5azB3VFIra1FUZUZqNmk2cVlzdnNEOHY4OFU4cjY4c3duRlpISTZ1amJP?= =?utf-8?B?K3VCNmZlQ3VRbEtHaUVPOE95eWt4aEFaZXVUUmpoL0g5NWFmeks0ZmY3SC9j?= =?utf-8?B?cHVURG9LbXNBUjE2b0VDbzRYTWVCQWlxcDZaNXl1ZWd6dDdMenRBcnhQaGNM?= =?utf-8?B?Z2JkZ2tPa3poSU9xVk1mODVseVhsYU5Qa2tzWkp2UUxPSGJWY3NoMEtOYU05?= =?utf-8?B?SFVkUHdpSHRJSWl1SXFqTC9wZTR1Uk5xalRwY0VkbTdXVHRHZ3FtVDYzMDd4?= =?utf-8?B?OHZybkRNMWd6dWw3Q0sxMnczMHRHZlp2OVVyV1hEOEpFd0lmZFp3bWFDQlk5?= =?utf-8?B?S01ZYUVFcGoxQlQwMFJpTXRneVFKRTVhZWdEMkErTnphY29vM3ZBT094aWFI?= =?utf-8?B?NDJhSWkrZDAweXhWNnhMZFJVN09zeWJKVW16azUyK3c5N0NyZ1NiMGpFMjJq?= =?utf-8?B?c25ESllZMTNyajBEZUpuTi9CMVNIdGh5cDdlMHFqQmR5ZTlSaW45UHpXZ05K?= =?utf-8?B?WXFYWG1VcXBmblBIL1c0WDNWZWhySGlzdTh6ZmdrOWdScWNVVCthUEt5dFpz?= =?utf-8?Q?lvDoqReuoTrUh5moqdKDGYctw?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: ef1ae471-b19a-4f05-d45c-08dabb458971 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4297.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2022 13:40:56.2390 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oBMVIVBSBmRrdTq9TB9eXiigTn/y1PuNRK7NpaUYHcdYsV9UA2D/09LOSJEGgCV8 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6280 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/31/2022 5:05 AM, Junfeng Guo wrote: > > The pointers 'rxq' and 'txq' are dereferenced before the null check. > Fixed the logic in this patch. > > Fixes: 4bec2d0b5572 ("net/gve: support queue operations") > > Signed-off-by: Junfeng Guo Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.