From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1160A41C97; Tue, 14 Feb 2023 19:14:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 37C3642FB0; Tue, 14 Feb 2023 19:14:57 +0100 (CET) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2048.outbound.protection.outlook.com [40.107.96.48]) by mails.dpdk.org (Postfix) with ESMTP id 348F642FBA for ; Tue, 14 Feb 2023 19:14:55 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AQgzV2IWr0X6SC4R/lzUkSe4PGgZRspaGiCyKr+WFirHr1ze9MH1scUokCtlWtOExhwllAwQd9QuuUinxCiqi/LIQ3Qyn6NLG5i+9j2VpwfkjEBw8FXcn+36V0/g4ib95nvwLmPpnfS2z8Z5S1LwWWbNTmtdG029R4VEFDnd/FB/3MWQA/r6WZYMWGlnDJCBoODBfyqyUoH/36AQ0U+j7288w81r2EvuXwKrPY7NtvkC3DVoIpYLgCB4HrhCn0ceIsbcOQ/QcbeBx/odrujDDPOrqCZyCty7LpAyitc3VmWvGwGNHY07evwiYhlzpqWCA+RS262sWq3E8modZTYn/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VWqszQjAlr5GBeCtIsRypaNpzz1k6fcHPQSP/6vvNto=; b=kk96wMr9VK7NYmqbZwrg/OjTZ9vZFdbLwGgPZJAPxkBgEeAiSWj2Btel4yaZGMTDvGuGdKJ13c+tBec4NG/einRvXmIPcDnLuxkcYsIU1g05JhFwyOkRy20Clrd4OYb4mH+oAuJlXQ92zSo6szwieC7K0BkKcW7bPYCNjxQUtCuZkrmCv2us+uIiDe3FzBNxVmGfjxLPMYkFynti755cuN0L+6VbeX3iW5xpvpKdJQMRjdfe2V84mW3fj3Wtn7c9/vr0RgFswQcMAVBVDbqVmz8y9mA9BSGO/vyYuXqDuMtJZ8kQ/9WObBQc0RVJhKYCIv3RckNxV02lML9+erwkqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VWqszQjAlr5GBeCtIsRypaNpzz1k6fcHPQSP/6vvNto=; b=fDxelBlG0V06mngXEsYSr77haZ+wzkoqyckrSIR0qOK8yr1xuJpgqGAcXB+dRLKSxaLcebo6Y0G7dsbqOqqJrVeaBsWB3IE88VAl4KQHzdTbUcAxVzwyJ+CcT5quzlSzTM+VR8tkiLmlNP9F7bgBYOkCeVOQ6YbxvaCibfmmV7U= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by BN9PR12MB5083.namprd12.prod.outlook.com (2603:10b6:408:134::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.17; Tue, 14 Feb 2023 18:14:53 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48%8]) with mapi id 15.20.6086.026; Tue, 14 Feb 2023 18:14:53 +0000 Message-ID: Date: Tue, 14 Feb 2023 18:14:47 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Content-Language: en-US To: David Marchand , dev@dpdk.org Cc: Aman Singh , Yuying Zhang , Robin Jarry References: <20230124104742.1265439-1-david.marchand@redhat.com> <20230124104742.1265439-5-david.marchand@redhat.com> From: Ferruh Yigit Subject: Re: [PATCH 4/6] app/testpmd: factorize fwd engine init In-Reply-To: <20230124104742.1265439-5-david.marchand@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P123CA0006.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:a6::18) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|BN9PR12MB5083:EE_ X-MS-Office365-Filtering-Correlation-Id: 82f027ce-2b33-426d-6051-08db0eb75e8e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gqdUKE8SPDTd/61FL4rm5eZHC+Q8iD/EKgkdOmq4zSfvBuQW7oQ6jnQ0c8gFzWA1EmOJpR+usDCy/qw4MeYrE+ckYejqn2wHoCuCL5PpBzWvPB74ML6XiPqcOeUGYasNtLfpo0QRniTUCmv6eL5ltTYzFdJICTSgpZN6XmOKCawJzkKjDtLbdVaP5LeGlxFHNUcaLAQR53PUGQbqzIgOyBk507HxfGS2hnA5BWKdE0RjizZVz1dmVo33gXu1LHIcDl56eS8i2t7DtqUzb3VdGV3P+PxhQcHGpXTD0yAeyprR5JkHm7uFN228VkdF/tLb87oCP5d8DpdVHyp81N63TuE5ditPRarMG/IEsDlgqOmU1gQXkKSINWvjttuEIAv8Ja063rr/iKWraFFExYG+dVcz3Lr1oTZu6ABnfFvYSvlWYEQ20r2eMnxwjxVfAYYH3tF49cxhLPGQZIJOBO/mfcYJAGwYkAOpIxg6A7bP1w1ZfyDlxcsCmzkj0h9gsQMqcyrkzCwAMP7aQYVft8nUk88zynYP3RqWMip6BEsvK6ppWdbGWBKCaNhxlNtosTIA6y3rq1Eq2uaQgnrmOjkaRs5JrofzteXxd8DMKdOpan7a2dciAPO5GJVgoR6cwjtSFFWzB1MEwo7mb7RR4QWlWgQe1j5dwGea+iXiMTPmhzV3jOEChHXDSuwoIyu6smnSBHB8ZRoLuwbdxT7KUFn1i8iJEnD/NJgCs9a++DOmw4g= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(346002)(396003)(366004)(136003)(39860400002)(376002)(451199018)(53546011)(8936002)(6666004)(316002)(186003)(6506007)(26005)(6512007)(2906002)(5660300002)(4744005)(478600001)(44832011)(36756003)(54906003)(86362001)(6486002)(31696002)(31686004)(66556008)(41300700001)(66476007)(4326008)(8676002)(66946007)(2616005)(38100700002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RkF3OEJvK3UzczhJTmd2OFJVTE1uUTVmazdCbWNrYkZLTmRCdW5GMU1vNXpO?= =?utf-8?B?NVdVOE4zT1Z2ZHllY2dCK0tqWXhhdzhLQnhnd0hhTXRrbHorMk5kbW9XTUpI?= =?utf-8?B?ay9mRUpOOHBVZjBaVDgyckFpaVU4U3ZKOHFzUVFucDZQTjA5YmFsR1Q0dmFp?= =?utf-8?B?eGxlcmlIckY1UjVkYk9jcittbnZwcmVTOFQ1QlcrTU03bjN4M3BhaFpnUGZp?= =?utf-8?B?Ky8yTzlsUFFyTXZBRXBXK3Y0UlpPekk3NmZ1NzZTUU00R0JiRWdSTklVSWJU?= =?utf-8?B?R1pud2I1S0luZlU0YWFIcW5kOUEzRG9ZaEFzSDZzSllRNm00OG05UlB5aVpJ?= =?utf-8?B?aDdsYnhjbjlsWDQ2OTFpOTdVRGNBZzI2OXF1Ri85eDVHcHl4em4rZEdQcDYz?= =?utf-8?B?MTgvcUFGUnZnYXNNNFAyKzdMZnJhUjl2UnhoREhiQ2xTdWs5WmYvSFM1U0lT?= =?utf-8?B?RThrZVVZRzVjZDNDWkp2ZDlQeWxJa1hocmFPNmhKMitPSWI1bDNaTHgzSGdX?= =?utf-8?B?MWR6TEhVcisza1czV3pnSElROS9ISHhmcDM0eFQwZjBDakFTM3p0QVJRRlpB?= =?utf-8?B?aHRiYlFXM0kxNFM3WkppWXBQWEN5TVlmc3Ryb01oUUMxQXJoTEpNZmpubE40?= =?utf-8?B?dVpUMWRVWFZrRVdhTk9ZYnVNKzlQK1hMYnduWG9jNHpUTjdBUlBlNnAwSURV?= =?utf-8?B?ZC8zWStXSjVvNDN5K2ZLT2Y0YlVSQWZlVXpJZDJQaC9ZSUdyNDBjNUNEMGVz?= =?utf-8?B?YXB1cHZPa2llT2tWR25JaWVuaFF6RVpUTTArU3pmUFd3OEFXaTgvVWFpdjUy?= =?utf-8?B?L1FZNG1KK0JsaHpmdEZmdnRJdlAxWTc1MUxqVFovVk14bnRVL3poa3Bkc29I?= =?utf-8?B?YXZXUktOeW9yMUlCc0lkY1owRnI4RThEdzNPWDNRNDh0UEZNM3FoZWlnWHBv?= =?utf-8?B?MmN0bHJsR2lsSERjR2VJRTRzQ0l2dEQ0dDRwSnFiVVBQMUlCUXcrSkh5WEpV?= =?utf-8?B?RWllbmJHL1U0ZmZ5UFUzTU9jMS9yUi9pRE8rRUNBQXJsNkUvQ3lUbzZBbWRp?= =?utf-8?B?dzBwZlMySkJWQzhwcDFCSDdyeVRPWEx4bTZLMm45Y29qcC9UWkdCVXhpYk5J?= =?utf-8?B?dFlUWmRuSVNKTFhQcUxRRTgxZU4xV1dZT2JsVVlGZkJGT25VTHJaWktzL2Zt?= =?utf-8?B?UlpVQ1VZVDNWSTZtNFQwTzlrbzVBNzNaVjE1SkJNT2QyRTlnV0szcExmYTBX?= =?utf-8?B?TmdFSTFnekFQakNlaUFkeUNha0c1TURQZzM0ZmlGSUJoRjdqM2pGRFcraEdw?= =?utf-8?B?cmh5UkxPNmV0ajIwVVhBcUp2dTFLMGVkUjVIRnRKMjhZS1Z1ZmhZaXRwYnMx?= =?utf-8?B?ditEbENDQVdXcWl5U3Qrd2diRXVDNEVBN01Ha2JkRHNmUnd6VWN5Q3hKVWM1?= =?utf-8?B?cnRmNGpqb3JHUFo1MTRVcEZmRjNYMms3WUVJMVVFUUtEYUpjeFNrZEhwaUh6?= =?utf-8?B?bFpCUGF2eUJLM3R6bml3VzA1TVFpbllVd1pKdHo5WFcwcDlZR21wQituNVB0?= =?utf-8?B?YW9QbUcxbFI1bktzbjMySk01cm8xSlhoSS9qNGNOYUNmY29BZVRSclhXK1hO?= =?utf-8?B?RWVKUGhXOE9UNlFKK2ZjNUdaMHlFK0lWazF1SEh0YUpaUElNWVQ2YXlvb0NS?= =?utf-8?B?YkRlZ0JjWnFTUVovaEU3QW1NZXRUS0tEV29jS1dvRy84ck9tVFBlWDM1VnVD?= =?utf-8?B?Q0FwbkoyQVBqbzlFci83TVFDUk1Oc2hLZURGeXhaUUJSQ2J2YU9qaUNaaEhJ?= =?utf-8?B?ekxmaEpQM1l6bFdnM29jWWttTTYzOG1sL2Q1T0ZUQmlHUm91MDAyZGx0b1pH?= =?utf-8?B?UDlvR1RSS0d4cjkweUsyQWQ2SE84WFE3MzZtMldYYkdEM0xMV05GVnc4aW1M?= =?utf-8?B?SFJyRDhPZmk3NHFiVjRXYjY0UjBmRWtBS2pMWUFUT0hUVmV2T3dJQzdLM3F6?= =?utf-8?B?MTkzYTRlZkxOQmNUSTRsSGhNdUhmK05LTzlrQVErMCsyOG9MSFhkVEg2RDRu?= =?utf-8?B?V3pOSWI5eHh2ZDBZRUVKT2xCU2VCWkppYnVEejQyYUViREc1NWNuQVNNOHAr?= =?utf-8?Q?Vi9zheP5lqmYyFwyDKX0XP7T0?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 82f027ce-2b33-426d-6051-08db0eb75e8e X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 18:14:53.3437 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qvOAZ62aA7n1+06acjTcpkrXdqooHCTuGg2rRMoZrbfAVzux6rIVDW3aMXd+Ol3F X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5083 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/24/2023 10:47 AM, David Marchand wrote: > Reduce code duplication by introducing a helper that takes care of > initialising the fs object. > > While at it, remove unneeded initialisation of fwd_engine empty fields. > > Signed-off-by: David Marchand Reviewed-by: Ferruh Yigit