From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 2350343075;
	Tue, 15 Aug 2023 20:43:57 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id EC2124114B;
	Tue, 15 Aug 2023 20:43:56 +0200 (CEST)
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by mails.dpdk.org (Postfix) with ESMTP id 36D9E410ED
 for <dev@dpdk.org>; Tue, 15 Aug 2023 20:43:56 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id A5EB461DA2;
 Tue, 15 Aug 2023 18:43:55 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 85FC8C433C8;
 Tue, 15 Aug 2023 18:43:54 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
 s=k20201202; t=1692125035;
 bh=cW5hIOQJGCgSxj+7oHN+9k9g85bU39yuv+4hZzMNlq4=;
 h=Subject:From:To:Cc:Date:In-Reply-To:References:From;
 b=jcP9QG2G3o24FLxvgSWhoExTTCLL1b2DJ5GxsG96STfxBQ+g19h3zyWbcWZ69MFWD
 I2cdD3pc5MOB0XOzwBqYvSZdV8WlHIi+rZ2Ltoz5ur/h3XgS8nnAq8Fp8M6edeWGpC
 A+KEwsVnMP/Ea6w+3OFk3ZtaGDpcwjq85Mo+lSxAVuL4QfOr4wS/sOFwcj7lyQleH5
 3XoWYwpy8+Cj9CR0euLBNuoi4Vp/ByTA0uATgXY+/Ub7s3B0b33xWV6lRdDee0itY0
 lOivGSy5PQAhvYbawerOEO2yJOe+Oc62/dBO846NSGfcFGhk8SVHdwBB+4j294I51K
 i2/4+te4wxaPA==
Message-ID: <a6f20b2932d3f3ca20ea4c7f766385ea5a237375.camel@kernel.org>
Subject: Re: [PATCH v4 8/8] eal: initialize worker threads once
From: Sinan Kaya <okaya@kernel.org>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Date: Tue, 15 Aug 2023 14:43:53 -0400
In-Reply-To: <20230815104635.143aaf61@hermes.local>
References: <20230815145023.1386003-1-okaya@kernel.org>
 <20230815145023.1386003-9-okaya@kernel.org>
 <20230815104635.143aaf61@hermes.local>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.5-0ubuntu1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Tue, 2023-08-15 at 10:46 -0700, Stephen Hemminger wrote:
> >   static uint32_t run_once;
> > +static bool worker_initialized;
> >   
> 
> 
> I see a pattern here. Many places are using static to
> 
> only initialize once. Could you name these variables the
> 
> same; suggest using run_once everywhere.

sure, will do.