From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 550ECA034C; Thu, 29 Sep 2022 15:27:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F36C140694; Thu, 29 Sep 2022 15:27:48 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 7F7A040395 for ; Thu, 29 Sep 2022 15:27:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664458067; x=1695994067; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=QwxQEwVxPh53xECgXdeY13zKDv85VpczENIrXVX0pX8=; b=EI3nX4GfAZAwMlIZX3qsBFBzzRLjC931heB8B6adoN16pXljEP4GVD7d L44igfqOXKkha7XGjK8HZBaL0aYgit+v0/WphNNwvT+5w3m1Z3ABsXW80 27hUg+TxvAYaLfoDJpvDEZ9THr48k4cVigBBbSd33IOpIU2rQsOZfcDGM +10oGYcWU9C7do6RKW7DYIyp8UPaM0XF6dQ7EcKk+TIu+ppsktKa/pgku oeqv/xTisSPosoUD2MGmYM7bKh/RX5fTPIWLJP9+UzOKc7xo8fAunIehl TbWKbl4DGFo1pbXEWa433Eoh5HeKos5DeRBuRvZ2teTE5B+9yB8wK3kJX w==; X-IronPort-AV: E=McAfee;i="6500,9779,10485"; a="365935693" X-IronPort-AV: E=Sophos;i="5.93,355,1654585200"; d="scan'208";a="365935693" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2022 06:27:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10485"; a="617599924" X-IronPort-AV: E=Sophos;i="5.93,355,1654585200"; d="scan'208";a="617599924" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga007.jf.intel.com with ESMTP; 29 Sep 2022 06:27:45 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 29 Sep 2022 06:27:45 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 29 Sep 2022 06:27:45 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Thu, 29 Sep 2022 06:27:45 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Thu, 29 Sep 2022 06:27:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nXoG+L18fWswKpxjQ89CLqqVRjfGTiaj+0OMQ1SvXlSIHsuNqvB8JzX3Ku0nc2GrTNkUgCgb5z374KRGqnaKNMOMUJs0ZPa69MpUuaVT5a88sTIgGPMffyWzLXrrSQm2jKvR/dITC3kvJGGmPO34Y0NjfrdmupxwdcFJ3PgmcOrppu/c2VAMJ6VQIgbyEF9LxQipnc0ct32Esaz2sreAamvEZC9VfinYnXG7l6wsgf03L3Jqt9HKbm30NNenCRNLE08S7XvUYZBS+5Waa7ISSwBuh9VWXiyE3nu9/JPLo6tkVLzy848dUcxCvBKyYIQxWvXVFhdiN6Chgzo+mjCCVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d3POM/CAphvAjf0FIBNNQ5HXB2uc1El/2liaTD1xpqw=; b=k5pBAMmJjPQvZ6meeetX5aSF1ItEwoPhhH7+IRFZczKpyrUjSDO/ijJK2cXTpMds3VzbpB4laxOdMZtWRQzUq1rdzblwe5VVhDWIAHRz7JAKpIDhbSSnMTZi1NpBWA+XVrPWVI6DBKNnbUm5P37GnyteTL+Pw5w7uN9Z7mF+hWaXYVihpcHRScdyk4DBBZEv6zINal0kgJkaFfq+A73O1xzfrnwclhx7kmYDdEd8Y0Cskp+ZOOxsUEM/RelAfEgkTlRMQapkO8f6Ev0z3ee1PwhK0Re9j9YeFovRcjeLl1mGp0we/oTAYmsRP9HlrqCOvxJpv4VZdeMGIQUIn+1kUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from BYAPR11MB3799.namprd11.prod.outlook.com (2603:10b6:a03:fb::19) by PH7PR11MB5862.namprd11.prod.outlook.com (2603:10b6:510:134::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17; Thu, 29 Sep 2022 13:27:43 +0000 Received: from BYAPR11MB3799.namprd11.prod.outlook.com ([fe80::2a3b:7b9f:8bce:711f]) by BYAPR11MB3799.namprd11.prod.outlook.com ([fe80::2a3b:7b9f:8bce:711f%4]) with mapi id 15.20.5676.020; Thu, 29 Sep 2022 13:27:42 +0000 Message-ID: Date: Thu, 29 Sep 2022 14:27:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: [PATCH v7 0/3] add uncore api to be called through l3fwd-power Content-Language: en-US To: Tadhg Kearney , CC: , References: <20220928090636.1580647-1-tadhg.kearney@intel.com> <20220928133018.1583280-1-tadhg.kearney@intel.com> From: "Hunt, David" In-Reply-To: <20220928133018.1583280-1-tadhg.kearney@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0513.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:272::23) To BYAPR11MB3799.namprd11.prod.outlook.com (2603:10b6:a03:fb::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR11MB3799:EE_|PH7PR11MB5862:EE_ X-MS-Office365-Filtering-Correlation-Id: ecd729b1-1e15-4dc2-64a8-08daa21e634d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NsEMIGYnvddVjD8pYFuxTPklxqSqF+JGsHhqII3KusNq5qNkTpUcCKUMMSMQp3Bs+UoKci9UXlvR6JQI/L/+fScLHT7nSYY0t3yqzMjMUISOcwYQBKtVXLhrha6CBvcF97fB3dOYWinz6kAMhJnuKWhA0QBGKRFa76ucfYDkzTu/tQ5kERX+rYRuTgcxPkfuJMDNUKXIMY7troajEs0hiPLbG/2mPRBHGR6P5/UG1bzUrUtWUqlHPs6cdsBvEgKxkEhBZwr5JdO8jVkXoHCNJ4bZr4t1Sr5kZc6QbCxjjWtC0ronzXPsw7eqk+1ZEfoWQvakTN5OakNEQZ3AkaOwi3IN+NIg2D7CGeATmOaVA23Kl4gqqxfqcO3ncS1pacsDioddmNDSkS37mauMiFooesIctXLviAOy4jWjVeOJ0G0cvLWB1nkyZzzIPl0pdOPDbSLLm6U1Yh1ZiPFfx0xHDQd5AENCW2X7Y2iahCrz6jGN1QFF3evUFcQtbCEr7bmmN0ZZKW+RuTCw31KzZe6VpVyhJd9Wwcupj+6FMWtGWoJD0TIUw0hJ2IyG1HPetX85ORZcSpq88ub9esEmOLhCb9WiDpgweZxTP5Xatp2rd33H73Hl+jzyoJ7tWbwOQQHZ1wqjJLa2LvuHAkWEi4Jdww4b52QRQhg3q3OXvSCed6QgX5Tuvvw0BBcNwEiXhIo2fv0EGJKyXjfrdRpagzBvHeU1s4xE6w4UFa3z0QGQgqzfZocM6542hawzZReNqB9Vn+zssSeY4XOh+MYf9+6u+nBKHmCAVywipOxPfw1QofnVw6vtodoOIe2MIiIJzLMV X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3799.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(136003)(376002)(346002)(366004)(39860400002)(396003)(451199015)(53546011)(2906002)(6666004)(6486002)(107886003)(6506007)(36756003)(83380400001)(478600001)(38100700002)(82960400001)(316002)(66946007)(8676002)(4326008)(66556008)(41300700001)(86362001)(31696002)(8936002)(5660300002)(31686004)(2616005)(186003)(66476007)(6512007)(26005)(32563001)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N0xmMWZNR1h4MEczQ2g2ZDFMc1FwUGY3T0RFcXNGRTYxY05xMTRjckxsUGdh?= =?utf-8?B?cXJ5SWM2MFJYNVZLZDR4SzgrZThGdWRZNnBMQjRnMy9renJjVVB6cmVjTThL?= =?utf-8?B?Ri8zTjFzcXhhTndKVCt3ZFdXV25kTVI4L0l5YVR2N0F6ckNwajRiM0dObno5?= =?utf-8?B?b0pUMGx0cnAxS2pnMGdobzN4dWJxYjZlUzZITDRGczExTjZ6bURaWVI5VENi?= =?utf-8?B?cnpsV0wxekVVQks0aDFIY0FiN3dMUi8wYXNlQTQvWWJjOC9LTFJNYWJvR3FK?= =?utf-8?B?ZmVPK1dTWlFzTS9NYmVPZENIVmg5T3FrV2QyZ3N3UnR2L3NVRUJ6MEh3NTIx?= =?utf-8?B?V1NVWnBxbklqQjY2bDdPK0Vucmh1SVZBYzFnakFKajRFM1YySTVWNG1wcWwr?= =?utf-8?B?YStBK0dhR3BsdWVhMWhVL0xFVEg3S0pMbHJMVk1nbXZ2ZWo4Y1lXYnlKK2hs?= =?utf-8?B?TGU0QWdna2MzKzV6RTZ5emgvQXRYVU1Da0ZkZ2p6ZjhDTHRwSXVpRlNjY2VR?= =?utf-8?B?a3ZBRyt2cWxBbG5kTTcxRW1YdWZCU1hBcmpxSng4VFhNQkt1R2Vpbk4ycTZN?= =?utf-8?B?aFRxajNWMXQwYVRZdERFVDJrbWhDYVhGSTBSYzRkclA5WWk2SlJ1K1V0V2Zx?= =?utf-8?B?Sk8wc3U5a2pGKzE0cUowM3dMRUI0NHJ2c2NaUzFmZUtvS3ROMnZ5T2o2QitX?= =?utf-8?B?YWUwOVdzTjlRL01jRVhnNkdHL1d0NS9GWkVwYVVmK3JPQlBwQWl2K3lTMGFp?= =?utf-8?B?cjB4R2IyTVg1RFpjNGFlWkJTZ0ZHeCtjS2hxK01hOUNGSnFzMTRMQVQ4WTh2?= =?utf-8?B?MkZkMlp5U0Q0cXA2dUlJZXMyOWhJblhSUnZkOEFlTEpCVnJTQmhJUHo4RElK?= =?utf-8?B?T0o5cFQvaHBYNGZKQkMxK2VBVVZBZ0JzSUZNcVpLNkxOWjBEZHdVYnZnYzBG?= =?utf-8?B?Q2dxbGJ2N3RQSm94ZExac0xNOUxRclJobVlDM1pDcExpQ2h4OU1UZGpKdytT?= =?utf-8?B?dVloKzFiY0hEMDhoWmRQWWtuL1NMMjdrcWR4d0tTL2tQWmNzOEpXNHNZZFRi?= =?utf-8?B?enZueVBYL1pwR2YrUHpZQU15QnBRa0c5QklxaVBRWFZDQXVUZS9sa3cyMkZU?= =?utf-8?B?Z3Q5Vy9FTVRzR0tmMjVDakRoY3BUM3dPbDBWSk81RG1CVTFOUTl5c3lDSjdI?= =?utf-8?B?UmhqUk02ZkVnNTdNdm0xaHUzbmVyYklVWFNwb0xiMEtvdnBOWkpIRTlwTFRu?= =?utf-8?B?SjhXVlBLQ2lVUk5lSFFJdXhCMnkxdW5nOWdUbmRRbUlRQUxRZUpJT3lVMzdW?= =?utf-8?B?cVRnOSsvRUx3U2dwWEp0NWhzLzRNT0YrVFZxU0toN0cvV2JkOG9yRkxhQWRj?= =?utf-8?B?b09xQVpSeEdFcERxNG5IYlV4VkdlVEpvTWtwaVVQRmV1NEVrTnRvWThUanhV?= =?utf-8?B?cHZ4RlowZnp2WVR5RWc2MjlwOXFBRkhNY0pBZW5uOURRbTBHREhWRUxTamIr?= =?utf-8?B?WWZDalhCWHBjWDVnSy83UVR4MVFBRmFZcWUyVXZDUzBmUW9OVFk1S0JSbFg2?= =?utf-8?B?dVlGRm05ZHllQ1ZqT21WRDZ2c1J3VEUyZjBPRXEyTGY1QXowcGhKVEJPTW5L?= =?utf-8?B?NW9kdFEwVkt0VkVqcGNDMC9KTGN2V3JjV3lXRWxjSisrbWxRVXR2WVV2L3lC?= =?utf-8?B?dUtONnZub0ROY0swZWdqeXUwOTNTTUdPYXBVdXRJRHh3ZWl4L2UvSE1ZeFkv?= =?utf-8?B?NnVseFM3TUdoK0NlWGdFblU1VFRkeE95U0puamZ0TmFTVWNnUmpZUGhKenRH?= =?utf-8?B?RkNOVDU1a1ZqeGhML1RKNC8wR2MrblNGTWFiNURKNkNXVTUvS2xGYjBHb01a?= =?utf-8?B?ZGVRaTY0YjVPTVZoVnpJZHliRGFDak9YeTFEQ2pBY2VtQW5VWWdNdzdGamFE?= =?utf-8?B?aXNodW9raUh1bko0S0NyZ3FQYzQ0TFhIMThXN2gvbnZKemovMFdlMHl4L0py?= =?utf-8?B?bER0N3FuRThkMk9JTG1VZFBUN1JCT2dCMGh3MWF3S3VqZ1krSmZwTHlWNjhM?= =?utf-8?B?MXNGNjhwWjlBOElzS3lPdkkxa08xOHhmSTg4bzYrL3Q1dVBrWnEzMG1Wc3d1?= =?utf-8?Q?SnqueN63uPVZtwQP7TcgLVT++?= X-MS-Exchange-CrossTenant-Network-Message-Id: ecd729b1-1e15-4dc2-64a8-08daa21e634d X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3799.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 13:27:42.7893 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dz7PCW3kmMMekAb0A3niQwlUY1O/0bqUagMnMkBxAXjzWPU3cEmEDxuk6ro/tDK1oz68lo36ouPBEEmTwZ3UvQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5862 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Tadhg, On 28/09/2022 14:30, Tadhg Kearney wrote: > This is targeting 22.11 and aims to add an API to DPDK power library to allow > uncore frequency adjustment. This will be called through the l3fwd-power app > and gives the ability to set the minimum and maximum uncore frequency to both min, > max or specific frequency index. > > Signed-off-by: tadhgkearney > Reviewed-by: David Hunt > --- > > v2: > Fix compilation warnings and errors. > v3: > Remove addition of x86 global macros. > Add 2 new API's for getting package and die numbers from system. > Address comments from mailing list. > Improve efficiency of code and code quality. > v4: > Fix compilation warnings and errors. > v5: > Improve error message for uncore access not working. > v6: > Fix uncore exit being called if uncore option not selected. > v7: > Address ml comments. > > > Tadhg Kearney (3): > power: add uncore frequency control API to the power library > l3fwd-power: add option to call uncore API > test/power: add unit tests for uncore API > > app/test/meson.build | 2 + > app/test/test_power_uncore.c | 301 ++++++++++++ > doc/guides/prog_guide/power_man.rst | 38 ++ > doc/guides/rel_notes/release_22_11.rst | 5 + > .../sample_app_ug/l3_forward_power_man.rst | 29 ++ > examples/l3fwd-power/main.c | 126 ++++- > lib/power/meson.build | 2 + > lib/power/rte_power_uncore.c | 451 ++++++++++++++++++ > lib/power/rte_power_uncore.h | 194 ++++++++ > lib/power/version.map | 11 + > 10 files changed, 1157 insertions(+), 2 deletions(-) > create mode 100644 app/test/test_power_uncore.c > create mode 100644 lib/power/rte_power_uncore.c > create mode 100644 lib/power/rte_power_uncore.h Latest revision looks good to me. Consider the series: Acked-by: David Hunt