From: Ferruh Yigit <ferruh.yigit@intel.com>
To: David Zeng <zengxiaoh81@gmail.com>, dev@dpdk.org
Cc: David Zeng <zengxhsh@cn.ibm.com>
Subject: Re: [dpdk-dev] [PATCH] kni: fix build on RHEL 7.6-ALT on IBM POWER9
Date: Fri, 21 Dec 2018 14:34:59 +0000 [thread overview]
Message-ID: <a6f7f0f2-0f30-2d39-916d-ce76d591aac9@intel.com> (raw)
In-Reply-To: <1545372231-45810-1-git-send-email-zengxhsh@cn.ibm.com>
On 12/21/2018 6:03 AM, David Zeng wrote:
> Signed-off-by: David Zeng <zengxhsh@cn.ibm.com>
> ---
> kernel/linux/kni/compat.h | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/linux/kni/compat.h b/kernel/linux/kni/compat.h
> index 5aadebb..1afa3b8 100644
> --- a/kernel/linux/kni/compat.h
> +++ b/kernel/linux/kni/compat.h
> @@ -102,8 +102,14 @@
> #undef NET_NAME_UNKNOWN
> #endif
>
> +/*
> + * RHEL has two different version with different kernel version:
> + * 3.10 is for AMD, Intel, IBM POWER7 and POWER8;
> + * 4.14 is for ARM and IBM POWER9
> + */
> #if (defined(RHEL_RELEASE_CODE) && \
> - (RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 5)))
> + (RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 5)) && \
> + (LINUX_VERSION_CODE < KERNEL_VERSION(4, 14, 0)))
> #define ndo_change_mtu ndo_change_mtu_rh74
> #endif
Do you need to update 'kernel/linux/kni/ethtool/igb/kcompat.h' for same check?
Also there is another update on same line for RHEL8 fix [1], if you can rebase
on top of it makes maintainers life easier.
[1] https://patches.dpdk.org/patch/49104/
Thanks,
ferruh
next prev parent reply other threads:[~2018-12-21 14:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-21 6:03 David Zeng
2018-12-21 14:34 ` Ferruh Yigit [this message]
2018-12-21 16:15 ` [dpdk-dev] [PATCH] kni: fix build on RHEL8 and RHEL7.6-ALT David Zeng
2018-12-21 16:15 ` David Zeng
2018-12-21 16:27 ` [dpdk-dev] " David Zeng
2018-12-21 16:27 ` [dpdk-dev] [PATCH] " David Zeng
2018-12-21 17:02 ` Ferruh Yigit
2019-01-14 13:34 ` Thomas Monjalon
2018-12-21 16:27 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6f7f0f2-0f30-2d39-916d-ce76d591aac9@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=zengxhsh@cn.ibm.com \
--cc=zengxiaoh81@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).