From: "Kinsella, Ray" <mdr@ashroe.eu>
To: Gregory Etelson <getelson@nvidia.com>, dev@dpdk.org
Cc: matan@nvidia.com, rasland@nvidia.com, olivier.matz@6wind.com,
thomas@monjalon.net,
Bernard Iremonger <bernard.iremonger@intel.com>
Subject: Re: [dpdk-dev] [PATCH v5] net: introduce IPv4 ihl and version fields
Date: Wed, 13 Oct 2021 09:58:20 +0100 [thread overview]
Message-ID: <a6fddaa7-858e-f62c-615a-38ef24e7a878@ashroe.eu> (raw)
In-Reply-To: <20211012122934.23659-1-getelson@nvidia.com>
On 12/10/2021 13:29, Gregory Etelson wrote:
> RTE IPv4 header definition combines the `version' and `ihl' fields
> into a single structure member.
> This patch introduces dedicated structure members for both `version'
> and `ihl' IPv4 fields. Separated header fields definitions allow to
> create simplified code to match on the IHL value in a flow rule.
> The original `version_ihl' structure member is kept for backward
> compatibility.
> The patch implements one of 2 announced changes to the
> IPv4 header.
> IPv4 header encodes fragment information into 16 bits field.
> 3 bits hold flags and remaining 13 bits are for fragment offset.
> 13 bits bit-field cannot be defined both for big and little endian
> systems.
>
> Signed-off-by: Gregory Etelson <getelson@nvidia.com>
>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
>
Acked-by: Ray Kinsella <mdr@ashroe.eu>
next prev parent reply other threads:[~2021-10-13 8:58 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 15:28 [dpdk-dev] [PATCH] " Gregory Etelson
2021-05-27 15:56 ` Morten Brørup
2021-05-28 10:20 ` Ananyev, Konstantin
2021-05-28 10:52 ` Morten Brørup
2021-05-28 14:18 ` Gregory Etelson
2021-05-31 9:58 ` Ananyev, Konstantin
2021-05-31 11:10 ` Gregory Etelson
2021-06-02 9:51 ` Gregory Etelson
2021-06-10 4:10 ` Gregory Etelson
2021-06-10 9:22 ` Olivier Matz
2021-06-14 16:36 ` Andrew Rybchenko
2021-06-17 16:29 ` Ferruh Yigit
2021-06-03 0:58 ` Min Hu (Connor)
2021-06-03 2:03 ` Stephen Hemminger
2021-06-03 4:59 ` Gregory Etelson
2021-06-17 15:02 ` Tyler Retzlaff
2021-09-03 7:30 ` [dpdk-dev] [PATCH v2] " getelson
2021-10-04 7:49 ` Olivier Matz
2021-10-04 8:59 ` Gregory Etelson
2021-10-04 8:46 ` [dpdk-dev] [PATCH v3] " Gregory Etelson
2021-10-04 12:13 ` [dpdk-dev] [PATCH v4] " Gregory Etelson
2021-10-04 15:59 ` Stephen Hemminger
2021-10-04 16:48 ` Olivier Matz
2021-10-12 12:36 ` Gregory Etelson
2021-10-12 12:29 ` [dpdk-dev] [PATCH v5] " Gregory Etelson
2021-10-13 8:58 ` Kinsella, Ray [this message]
2021-10-13 12:14 ` Ferruh Yigit
2021-10-13 17:12 ` Gregory Etelson
2021-10-13 17:13 ` [dpdk-dev] [PATCH v6 0/2] " Gregory Etelson
2021-10-13 17:13 ` [dpdk-dev] [PATCH v6 1/2] net: fix IPv4 change announce Gregory Etelson
2021-10-14 8:37 ` Thomas Monjalon
2021-10-14 11:03 ` Ferruh Yigit
2021-10-14 12:21 ` Gregory Etelson
2021-10-14 12:32 ` Ferruh Yigit
2021-10-14 13:34 ` Ori Kam
2021-10-14 12:53 ` [dpdk-dev] [EXT] " Akhil Goyal
2021-10-13 17:13 ` [dpdk-dev] [PATCH v6 2/2] net: introduce IPv4 ihl and version fields Gregory Etelson
2021-10-14 15:11 ` Ferruh Yigit
2021-10-14 16:04 ` Thomas Monjalon
2021-10-14 17:42 ` Gregory Etelson
2021-10-14 8:21 ` [dpdk-dev] [PATCH v6 0/2] " Ferruh Yigit
2021-10-14 8:30 ` Thomas Monjalon
2021-10-14 11:01 ` Ferruh Yigit
2021-10-14 9:29 ` Gregory Etelson
2021-10-14 11:10 ` Ferruh Yigit
2021-10-14 17:41 ` [dpdk-dev] [PATCH v7 " Gregory Etelson
2021-10-14 17:41 ` [dpdk-dev] [PATCH v7 1/2] net: fix IPv4 change announce Gregory Etelson
2021-10-14 20:00 ` Slava Ovsiienko
2021-10-21 22:00 ` Ajit Khaparde
2021-10-14 17:41 ` [dpdk-dev] [PATCH v7 2/2] net: introduce IPv4 ihl and version fields Gregory Etelson
2021-10-14 18:16 ` Ajit Khaparde
2021-10-14 19:52 ` [dpdk-dev] [PATCH v7 0/2] " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6fddaa7-858e-f62c-615a-38ef24e7a878@ashroe.eu \
--to=mdr@ashroe.eu \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=getelson@nvidia.com \
--cc=matan@nvidia.com \
--cc=olivier.matz@6wind.com \
--cc=rasland@nvidia.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).