From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4429AA00C2; Thu, 10 Feb 2022 09:55:01 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8A9D24117E; Thu, 10 Feb 2022 09:54:58 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 9CA724118F for <dev@dpdk.org>; Thu, 10 Feb 2022 09:54:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644483296; x=1676019296; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=bQie9YBdX2EwOTWTsqsN3wfEiRK2Di9q23SC66iW4Yk=; b=VwxCLOa7lDdigVl0WBztdmFitVNibjPe4PpjtQlYDiq21bSNm4n5WMlK IPrDzZdJSSy7akKXt36SgvK3/30MznONQ3LHwzQEfh3UEech1Jpi+iYG/ Guy9rl7LPh8VFwo7SSGId6Z3mUNqm60moDovhRzumqqEcb31m8tUqrIc1 PQ3SV6avCEHwyfSmOzrIb40hXApdhvdIp05Tj0JwddjtpHsErSCYorOse Ajhb4c2DuqoVy5oM/ZEQrrszL9zAh1PH+PDpgbuel0vsbZTJ/aISZnX5/ Wznz+WY7EGxDZrxSznSt98O+QUJjx3zK6WZo0kFWZxhVHJWvkpu73rUdP A==; X-IronPort-AV: E=McAfee;i="6200,9189,10253"; a="248277437" X-IronPort-AV: E=Sophos;i="5.88,358,1635231600"; d="scan'208";a="248277437" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2022 00:54:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,358,1635231600"; d="scan'208";a="622602585" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by FMSMGA003.fm.intel.com with ESMTP; 10 Feb 2022 00:54:51 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 10 Feb 2022 00:54:50 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 10 Feb 2022 00:54:50 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 10 Feb 2022 00:54:50 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.108) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 10 Feb 2022 00:54:50 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lCvyRBKwqiNCx9kPqx0CZ44wLJ3lWINgILzl1axzWlIEZVJ45bd33TweFneX8Lqd2XorVncAV1g2djOK3W3uh4icvE2/OZ6EdYAWlHGMIQyHt0G4N2JjdkHtBf0BuQrB04uKs8OQ0aLljIzdlEzZh/0FyJBxppbBVO93qzsYRbzNtD8JY9g9R/dDVjWEFWUqWxs3J+uU1xmzekzZyRgXYTRmUJwWm/L+DaL3WM6DaUnYwu2X5R8hjbPIif70fK6IYMB1CWP18Y9zUx96PnSrz+K74b1J9aDJiukOeLcFXCVBpOT/m/nPOz5L/AB2vdUjsbudDrwp6joeINVz3Mz9yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8mZ754KD3q0cgnyc0DauSce3EI1bVVAPlxciAdqJ2Uk=; b=bxoGoQHaYXjxt43/OLviUX1GCS6Biq0/yN9OIlY3fNddwtwprdHPHE5nNDTwgRysq36uYhltZIRiTSIyLXuON2rLIhPM1ZR7A3S2YT515L9JrbsdOYOVrCr0HKAolaF18B+S5mErbjPZw0hF/ta9xwsyUWZv+K7RtDERb8ikZbqpRJV39oIwQYOkZpGPtzOgoUM8vLOX6+coNTEHkEwb4I14kAh8W/TDEv3cZk7zLs8s8iuBr1n+DWjn7UXsCniTuTHTyxhQ0xmSXfnyM+4ATUE6qeFu1pQK0ErSqSHpk8OQfIj4S15xUww7e3V8/xBLKNclYQR1xDbManYY9XoPeg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by SN6PR11MB3374.namprd11.prod.outlook.com (2603:10b6:805:c5::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Thu, 10 Feb 2022 08:54:49 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4975.011; Thu, 10 Feb 2022 08:54:49 +0000 Message-ID: <a72c7c18-b8b1-2c4c-12ed-bbe2f16f0882@intel.com> Date: Thu, 10 Feb 2022 08:54:33 +0000 Content-Language: en-US To: Akhil Goyal <gakhil@marvell.com>, <dev@dpdk.org> CC: <anoobj@marvell.com>, <matan@nvidia.com>, <konstantin.ananyev@intel.com>, <thomas@monjalon.net>, <andrew.rybchenko@oktetlabs.ru>, <rosen.xu@intel.com>, <olivier.matz@6wind.com>, <david.marchand@redhat.com>, <radu.nicolau@intel.com>, <jerinj@marvell.com>, <stephen@networkplumber.org>, <mdr@ashroe.eu> References: <20220208201111.420971-1-gakhil@marvell.com> <20220208222027.1364292-1-gakhil@marvell.com> <20220208222027.1364292-2-gakhil@marvell.com> From: Ferruh Yigit <ferruh.yigit@intel.com> Subject: Re: [PATCH v6 1/3] ethdev: introduce IP reassembly offload X-User: ferruhy In-Reply-To: <20220208222027.1364292-2-gakhil@marvell.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0344.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18d::7) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8eaa1e57-6a30-42cd-e1db-08d9ec72fe72 X-MS-TrafficTypeDiagnostic: SN6PR11MB3374:EE_ X-Microsoft-Antispam-PRVS: <SN6PR11MB3374FB625B84106DFA29A42F952F9@SN6PR11MB3374.namprd11.prod.outlook.com> X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gAg7hH6A5G9NxfwEQvKNJCL3CMs6VzqphlyKyt3hK5tl3rUvYI8rJaTwmWOakyPKrIqq7BwcN/0/OPRJpwSbBHie0sfsHUU7y4/gEh3YnTeTYbCJfsod5iDT5qeIxWXpQPyNdf6Z5JKjL27rtsQmgM780j4INFGCAsm5DtwiHjV0Cq/aaD6/lKlCQUWxmYitRzlMALcUZ0uG+AkeCfKr8ejNgu2HjQaRY1/leiicA2mNpHOYMMMqYi8sTPMh0ieiWsvuGmInpI0uazE169cTwv18gq5qipt0r7QzFERkxAitaJdtHZ7DJd6fKu9wqtEXKbUvPF95kt8i4cCvjkwScOLaPKR/PRXFo/ZYJLrMVKE3hIyEm25l082DfFXhxUKPgAO9Ig96PcHecSOQEr6o8HUqVEcLlL20lBVFFBPbQpw+Owegr97mCj5rRp1lWzSXshf6mWq+DHZ+mIhVLA0rIeb7RVf8wwrya9IYhVPf8Apurf+Qe6j4KdX7aJSLK57RdPF0l2lV/uf4ChYP5c5cFjd6YmfbZ91IuvNrwBuyrzrFoJeMruZrRgRCdjtoL3Kb+BkiQunvq2Ba0wpdP2I0UY1HznVhDw/afXjueLFglrVnKGQElwRjY6YzC6K1qDXGmKEpCGGrfCDLD9WTKge7VQKQZ9jTgBxmeMUsabaqgeOZ5gsfb86isQvRIhJcaCyi84Dd0picGbCFYo12Myj2yg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(26005)(186003)(508600001)(6486002)(2616005)(6512007)(7416002)(31686004)(38100700002)(66556008)(4326008)(8676002)(66946007)(66476007)(44832011)(5660300002)(316002)(6666004)(36756003)(31696002)(83380400001)(6506007)(2906002)(86362001)(8936002)(53546011)(82960400001)(55236004)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UjRseU82NkZPR0tCWnFReWM3c3R6WUhTOE92SkEzbzRWS095Y0Nhd05hLzNj?= =?utf-8?B?MzFsVHF1RVZlbThVQVhKVnBORTlCTHBQbDd6cmROL3M0ODZES3g0MzlJZW9l?= =?utf-8?B?RlZRTWsvNGJwZXJvYzh2TStzSFBXakN2QmhIY3dNNjM4Z1FKdnBmYktoeE9B?= =?utf-8?B?UU1reDBjTzlCYmdPalFNeldSVTREUmVaY1lXY1FaSFA3Q05zV0ZJeHlGUlhp?= =?utf-8?B?Qm45NVhvNWJtZEZoM2dndk1JQ0hyZERtYXZTM3EzNXRYMG5LUE1GbGIyTU84?= =?utf-8?B?MjE0dHBtYW5aN1J6RnpScVdqWHNhZk94U2J6eXJSbmszYlorUEtkN0lTNTVz?= =?utf-8?B?cHprWXVKMVUwV040L1JTY0tYYUUxZS9JZFZuNjVqK3N1TUUxTC94ZUpmaHMr?= =?utf-8?B?V2hKamI0VDJWT2ptQVgrZ1ZvR2VVZlAwVFE1azFQRkFGbTlOSGw2TTYva3hR?= =?utf-8?B?aENRanoyeTZTek9nbG1LWmdobkY0c1VYWGFoUWtUUkNJMktOSVVETnBERzlW?= =?utf-8?B?VFF5LzA4UGtuRTBTR2ZRaCs0dGRSaDBrczZvMm1HL2ZRNTV0bjV2Y0tEZVc1?= =?utf-8?B?MHZjZlc5M0FRdWtOamNXVlFHQ29yT283R1VSSGhLMXlwdE9PRnpUYS8rRDdm?= =?utf-8?B?WmlDSk1abWErL1p6SFRsMHdPcm10QnN5emhyOU5qUUNtYklVaHFUT29nQlZa?= =?utf-8?B?cEtGc0RCdjc5bmc2b2x5blRwSzVtM0tpcGNFM2pZc0FtQVJLekxOc1Y5UFVI?= =?utf-8?B?bGFxampJcklmZnVRdy94U1ZtN2FoTHZlbk9JZ043UWdkVlF4dFdoZmdqZGwv?= =?utf-8?B?ZW40c2c5cDlKMENZQTltbW5KOWsyaTFtNXE1aFZNdzNveDdyb1pzUVJOenI4?= =?utf-8?B?dHRrZzVuQituVWtxcUdPVHpJTFBIU0s4Y3FFQmYrekgwZmkzMmJQeHNBQzBm?= =?utf-8?B?K2UzZVFXa2pjaFJYdDlyWlZtZ21UUS9ndkI1bTdLc3pDYUd6NmdocFl1NENr?= =?utf-8?B?NEtqOUNIcHhiMGJuYVhtSmlvMTJTdm1ZeEY2OURMdFlzczdieDBDZHFrc1lP?= =?utf-8?B?bCtubEJFbWJLTFRLNCtrSDdnV0FBM0dvSFdhQThGb0VXZHZZRS9EeloyR3pG?= =?utf-8?B?VGhBMWFUMXhCM1JGSVJ4QmxrL3RPYlkxRExPRHVvZ1NjcStwMkZnSTlSMDdp?= =?utf-8?B?Ly9ueFUwbUNSNnE2WWc4Q21TUSt5bjd2eUx3Zy9EMkdkWXRsY0FlZTdpWi96?= =?utf-8?B?cnNRL1Q4VmRSYU5IaFV3dDduOUlIYVFGRHpJYjArL0JZeTNFUjJ3dDZwblRG?= =?utf-8?B?ODQyZE9PUmM5U0dZYktpbUpTTkxuTFJFTGRPck1zcEpJVXh0SXFYZWZnRUVC?= =?utf-8?B?YTJEVjI4WFZTd3FiODgrZHgxYjdKNE1ZRit3Z3p4bllvUWZnSWRySDBJNTNC?= =?utf-8?B?aDBoRk9QemlEM29nTktOZnMydE1ET2hJc3hlZlNUdDU3VWM5RWh6VGErbzRx?= =?utf-8?B?a3hONXlUTXlhZTBhcjFPcFNoYzg0czV5OTg3ZnZsajdjcFFzV1ZLVlNvMUg4?= =?utf-8?B?eXhNZk54akYwSlZsRmNKWHZhRU4zUjBxSzdiKzdpWDhQUjBCWHZ1WEJsWkxW?= =?utf-8?B?SXdpcjFrRXRKbG02TGc4Z0QrMnFDVTh5c1V4bStEQ25IRk5JNTd6N0xoRGdP?= =?utf-8?B?NkxwN2ova2tCWVZZMkpUNXNyM2pjVWZWR0NKTUZ0alR4MG5RYnhCTWJaTGFL?= =?utf-8?B?ZEt5L0dtOTlybUJIdmlQTXdOcUROempFWVN3YlhUam1TYmxicVZ3U3ZBSTBR?= =?utf-8?B?Nm5LYjhRQ0pVM0lVV1dEdHNvUGJpSFVXOVBrWThNK21WYVYwdVdpNnNTa2ll?= =?utf-8?B?cmdwVDFPakk4bTRxQVlPMVNzR0dCeXZHeEU2c3hwL1dudzJNSUM1RG92dTJv?= =?utf-8?B?d2dBRHdXUmdyMlIvTWpMMVQzZWRNTTNnWTNVZkkrcVlSdmNBUkFybWN6SHBM?= =?utf-8?B?blR3YUlPcnU4YVZxOVBXV01ZcnJka092ZEM5RVdzaUYyZi92T1FQWjJzVlF0?= =?utf-8?B?THhONW83dy8zczIwUFN5cFIwZU44TUJKQ0ErcHU4b281SGJDUWc4SzRVV1Js?= =?utf-8?B?WHFYNTQ5aGdmM3dndW5ZcHhoaGVBMC8vR2x3V3hGNXIwem9xUEQraU9TUGpa?= =?utf-8?Q?jyFST4+Ty0Sgle+C5G5CLLA=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 8eaa1e57-6a30-42cd-e1db-08d9ec72fe72 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2022 08:54:49.2245 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NN7zUkkyShlcQETYpgE+D5ZbDeBp3AYZ8vORgswBx8CNZ1kWPVMEA5V7m99rPJorZMwwytwG1+MJfebULXDyMQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3374 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On 2/8/2022 10:20 PM, Akhil Goyal wrote: > IP Reassembly is a costly operation if it is done in software. > The operation becomes even more costlier if IP fragments are encrypted. > However, if it is offloaded to HW, it can considerably save application > cycles. > > Hence, a new offload feature is exposed in eth_dev ops for devices which > can attempt IP reassembly of packets in hardware. > - rte_eth_ip_reassembly_capability_get() - to get the maximum values > of reassembly configuration which can be set. > - rte_eth_ip_reassembly_conf_set() - to set IP reassembly configuration > and to enable the feature in the PMD (to be called before > rte_eth_dev_start()). > - rte_eth_ip_reassembly_conf_get() - to get the current configuration > set in PMD. > > Now when the offload is enabled using rte_eth_ip_reassembly_conf_set(), > the resulting reassembled IP packet would be a typical segmented mbuf in > case of success. > > And if reassembly of IP fragments is failed or is incomplete (if > fragments do not come before the reass_timeout, overlap, etc), the mbuf > dynamic flags can be updated by the PMD. This is updated in a subsequent > patch. > > Signed-off-by: Akhil Goyal<gakhil@marvell.com> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>