From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Shahaf Shuler <shahafs@mellanox.com>,
Thomas Monjalon <thomasm@mellanox.com>,
Andrew Rybchenko <arybchenko@solarflare.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] ethdev: make default behavior CRC strip on Rx
Date: Fri, 14 Sep 2018 12:37:28 +0100 [thread overview]
Message-ID: <a7389432-1492-d836-5dcc-9919193b9c9c@intel.com> (raw)
In-Reply-To: <DB7PR05MB442643D0A61E46F2A9642223C3030@DB7PR05MB4426.eurprd05.prod.outlook.com>
On 9/4/2018 11:02 AM, Shahaf Shuler wrote:
> Tuesday, September 4, 2018 1:13 PM, Ferruh Yigit:
>> Subject: [PATCH v2] ethdev: make default behavior CRC strip on Rx
>>
>> Removed DEV_RX_OFFLOAD_CRC_STRIP offload flag.
>> Without any specific Rx offload flag, default behavior by PMDs is to
>> strip CRC.
>>
>> PMDs that support keeping CRC should advertise
>> DEV_RX_OFFLOAD_KEEP_CRC
>> Rx offload capability.
>>
>> Applications that require keeping CRC should check PMD capability first
>> and if it is supported can enable this feature by setting
>> DEV_RX_OFFLOAD_KEEP_CRC in Rx offload flag in rte_eth_dev_configure()
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> Acked-by: Tomasz Duszynski <tdu@semihalf.com>
>> ---
>> v2:
>> * fix flag check
>> * add KEEP_CRC flag into "show port cap #"
>>
>> Note "show port cap #" and
>> "show port # [r/t]x_offload capabilities/configuration"
>> does same thing, in long term I suggest removing "show port cap" one
>
>
> Acked-by: Shahaf Shuler <shahafs@mellanox.com>
>
Applied to dpdk-next-net/master, thanks.
next prev parent reply other threads:[~2018-09-14 11:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-03 14:45 [dpdk-dev] [PATCH] " Ferruh Yigit
2018-09-03 13:59 ` Andrew Rybchenko
2018-09-04 5:13 ` Shahaf Shuler
2018-09-04 5:17 ` Shahaf Shuler
2018-09-04 5:54 ` Andrew Rybchenko
2018-09-04 8:06 ` Ferruh Yigit
2018-09-04 6:29 ` Tomasz Duszynski
2018-09-04 10:12 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2018-09-04 10:02 ` Shahaf Shuler
2018-09-14 11:37 ` Ferruh Yigit [this message]
2018-09-19 7:34 ` David Marchand
2018-09-19 18:04 ` Ferruh Yigit
2018-09-10 7:13 ` Maxime Coquelin
2018-09-10 10:40 ` Jan Remeš
2018-09-10 11:34 ` Jerin Jacob
2018-09-18 13:05 ` Legacy, Allain
2018-09-11 8:05 ` Hyong Youb Kim
2018-09-24 17:31 ` [dpdk-dev] [PATCH] doc: announce CRC strip changes in release notes Ferruh Yigit
2018-09-24 17:01 ` Thomas Monjalon
2018-09-24 17:12 ` David Marchand
2018-09-25 15:03 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7389432-1492-d836-5dcc-9919193b9c9c@intel.com \
--to=ferruh.yigit@intel.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=shahafs@mellanox.com \
--cc=thomasm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).