From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C8149A0573; Wed, 19 Oct 2022 10:53:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5ED5840A8B; Wed, 19 Oct 2022 10:53:26 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id D836A4069C for ; Wed, 19 Oct 2022 10:53:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666169604; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=npTEDJosDvGh6SSIiCUZz8zM9eA5u2wEE3sE2OFIwPk=; b=iIU4BZ2V3TH3mBfA6bBVf4ApMgYCtiTvWouXuRFdyLViLG+aSTnlHIk6NWgcMkiz6DxpI3 n+8DMj7M5rH7zb0bL+YbdQTBC+MNVmxRKWCN1VLR0caZ4QSWZO4+/j1QwtUALBDmd2d+Uc Ekna1gsb6Ktr5ETMi7vdqvrDSQ31oWA= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-111-rRC9YLA_PqaL9p4m_y5sCw-1; Wed, 19 Oct 2022 04:53:15 -0400 X-MC-Unique: rRC9YLA_PqaL9p4m_y5sCw-1 Received: by mail-wr1-f72.google.com with SMTP id v4-20020adfa1c4000000b002345526fbc6so3445wrv.8 for ; Wed, 19 Oct 2022 01:53:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:from:references:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=npTEDJosDvGh6SSIiCUZz8zM9eA5u2wEE3sE2OFIwPk=; b=akc9H2N3B1dprLPEJUbnlT51CyvqHvPd8BnYV6UsYOgCK91Z+575aIh9glGamJ29pz nPfQDNhWOvenEDEdgYrK6Azeku4bc0wCpVT4AL/MwGsQcFU465+r82CErSqbFAx9l6gM z/bTYCIt5stpZz4N4DwoNGsTMdxG53TCwqj0zd1RNbcWJN678KfqTerI0NeMdG/vZBWD 08RZdPTBymmMuPsrf0oUe3lfCoOfY7du9dJLz13ikvBXlguuZl+Tg5sEErSj3gIv1/7r Qr2WEo5F8ImP3knE8dWVxBt+QNFJTG3WbpCpS62JwACZmYWUWApfvWzA1Jl1cXvxwJci 0+bQ== X-Gm-Message-State: ACrzQf1Q5x9dBCOBrFKuxbbB4ZFlWA6BMvMq0uTNcoH+C6rlm4PqXnnW 6+Mg0zWhnueSE1bsgf8NKgzz/6xTT5+RxvS/oVbiSrCPja90MfOT3uR3Oum7+czpNPwOCROAEQX IqZA= X-Received: by 2002:a05:600c:3ca1:b0:3c6:ce68:baa5 with SMTP id bg33-20020a05600c3ca100b003c6ce68baa5mr4684994wmb.165.1666169594382; Wed, 19 Oct 2022 01:53:14 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6OB2mLSwNO5OJQaStkgR/tpKy8dlkkG5J4/W8061Msd0IlznGkakkzelvFqQK0aLRqfNFPyQ== X-Received: by 2002:a05:600c:3ca1:b0:3c6:ce68:baa5 with SMTP id bg33-20020a05600c3ca100b003c6ce68baa5mr4684981wmb.165.1666169594185; Wed, 19 Oct 2022 01:53:14 -0700 (PDT) Received: from [192.168.0.36] ([78.19.110.164]) by smtp.gmail.com with ESMTPSA id az25-20020a05600c601900b003b497138093sm16456199wmb.47.2022.10.19.01.53.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Oct 2022 01:53:13 -0700 (PDT) Message-ID: Date: Wed, 19 Oct 2022 09:53:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 To: Yiding Zhou , dev@dpdk.org References: <20221018102602.217673-1-yidingx.zhou@intel.com> <20221019075432.9698-1-yidingx.zhou@intel.com> From: Kevin Traynor Subject: Re: [PATCH v2] net/iavf: revert fix VLAN insertion In-Reply-To: <20221019075432.9698-1-yidingx.zhou@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 19/10/2022 08:54, Yiding Zhou wrote: > When the kernel driver tells to use the L2TAG2 field for VLAN insertion, > the context descriptor needs to be used. There is an issue on the vector Tx > path, because it does not support the context descriptor. > > The previous commit forces to select normal path to avoid the above issue, > but it results in a performance loss of around 40%. So it needs to be > reverted and the original issue needed to be fixed by rework. > Thank you, that is a much clearer explanation. Now on the approach, the commit being reverted says: "When the driver tells the VF to insert VLAN tag using the L2TAG2 field, vector Tx path does not use Tx context descriptor and would cause VLAN tag inserted into the wrong location." So it means this revert is solving a performance regression, but re-introducing the functional issue above. Is there a correct fix for the original issue sent that can be applied too? If not, wouldn't it be better to wait until it is before doing the revert? > To reverts > commit 0d58caa7d6d1 ("net/iavf: fix VLAN insertion") > > Fixes: 0d58caa7d6d1 ("net/iavf: fix VLAN insertion") > > Signed-off-by: Yiding Zhou > --- > drivers/net/iavf/iavf_rxtx_vec_common.h | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/net/iavf/iavf_rxtx_vec_common.h b/drivers/net/iavf/iavf_rxtx_vec_common.h > index 4ab22c6b2b..a59cb2ceee 100644 > --- a/drivers/net/iavf/iavf_rxtx_vec_common.h > +++ b/drivers/net/iavf/iavf_rxtx_vec_common.h > @@ -253,9 +253,6 @@ iavf_tx_vec_queue_default(struct iavf_tx_queue *txq) > if (txq->offloads & IAVF_TX_NO_VECTOR_FLAGS) > return -1; > > - if (txq->vlan_flag == IAVF_TX_FLAGS_VLAN_TAG_LOC_L2TAG2) > - return -1; > - > if (txq->offloads & IAVF_TX_VECTOR_OFFLOAD) > return IAVF_VECTOR_OFFLOAD_PATH; >