From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9384CA09F0; Thu, 17 Dec 2020 11:16:12 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A693DC9D2; Thu, 17 Dec 2020 11:16:10 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 09059C996 for ; Thu, 17 Dec 2020 11:16:07 +0100 (CET) IronPort-SDR: jRAt+rcqBOkOCSjVpvAYZOq1mDrFCRg7dmVPqnD8QVAiWoTi4joM51lwpIfLGD0q2muzPRFcav /iBwY4wNO42A== X-IronPort-AV: E=McAfee;i="6000,8403,9837"; a="172657041" X-IronPort-AV: E=Sophos;i="5.78,426,1599548400"; d="scan'208";a="172657041" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Dec 2020 02:16:06 -0800 IronPort-SDR: T3FwF6fLib4u0aCyneimJa97lPT1cOHtBHauriWhYusUvMucUFdpMdXIUTyclERRbmH1NIOuUD wZ6W81+TP64A== X-IronPort-AV: E=Sophos;i="5.78,426,1599548400"; d="scan'208";a="369774073" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.233.164]) ([10.213.233.164]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Dec 2020 02:16:04 -0800 To: Luca Boccassi , Liron Himi Cc: "dev@dpdk.org" , Kevin Traynor , Akhil Goyal References: <20201202130529.7332-2-lironh@marvell.com> <20201215222319.13816-1-lironh@marvell.com> <57e2bee8-d74a-6c88-f535-24bc1d18b25e@intel.com> From: Ferruh Yigit Message-ID: Date: Thu, 17 Dec 2020 10:16:01 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v2] meson: update meson build for armada drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/17/2020 10:06 AM, Luca Boccassi wrote: > On Wed, 2020-12-16 at 13:52 +0000, Ferruh Yigit wrote: >> On 12/16/2020 1:41 PM, Liron Himi wrote: >>> -----Original Message----- >>> From: Ferruh Yigit >>> Sent: Wednesday, 16 December 2020 15:37 >>> To: Liron Himi >>> Cc: dev@dpdk.org; Luca Boccassi ; Kevin Traynor ; Akhil Goyal >>> Subject: [EXT] Re: [PATCH v2] meson: update meson build for armada drivers >>> >>> External Email >>> >>> ---------------------------------------------------------------------- >>> On 12/15/2020 10:23 PM, lironh@marvell.com wrote: >>>> From: Liron Himi >>>> >>>> With pkg-config support available within musdk library (from >>>> musdk-release-SDK-10.3.5.0-PR2 version), meson option 'lib_musdk_dir' >>>> can be removed. >>>> PKG_CONFIG_PATH environment variable should be set appropriately to >>>> use the musdk library. >>> >>> Hi Liron, >>> >>> It is good change to get rid of an custom meson option, can we or should we backport this to the v20.11? >>> [L.H.] yes, it can be backported. >>> >> >> Kevin, Luca, >> >> What do you think about backporting this patch to 19.11 & 20.11, it removes >> 'lib_musdk_dir' custom meson config option and uses pkg-config to find the musdk >> libraries. >> >> It looks good change but not sure if it is a regression to remove a build option. >> >> Thanks, >> ferruh > > I don't know how used it is, but removing a meson_option is no good for > LTS. If there is no functionality/build breakage and it's 100% > compatible, it could be made a no-op - that would be acceptable for me. > It may affect the ones using 'lib_musdk_dir' meson config, if the removing a meson_option is not wanted, perhaps better to not backport this. Thanks.