From: Hemant Agrawal <hemant.agrawal@nxp.com>
To: Jia He <hejianet@gmail.com>, <dev@dpdk.org>,
Thomas Monjalon <thomas@monjalon.net>
Cc: Jerin Jacob <jerin.jacob@caviumnetworks.com>,
Jianbo Liu <jianbo.liu@arm.com>,
Jan Viktorin <viktorin@rehivetech.com>,
Olivier Matz <olivier.matz@6wind.com>,
<konstantin.ananyev@intel.com>, Jia He <jia.he@hxt-semitech.com>
Subject: Re: [dpdk-dev] [PATCH v8 2/3] ring: introduce new header file to include common functions
Date: Fri, 19 Jan 2018 19:45:30 +0530 [thread overview]
Message-ID: <a779a7be-50ee-7d58-52d6-865b802bfff6@nxp.com> (raw)
In-Reply-To: <1516161831-28719-3-git-send-email-hejianet@gmail.com>
Hi Jia,
On 1/17/2018 9:33 AM, Jia He wrote:
> Move the common part of rte_ring.h into rte_ring_generic.h.
> Move the memory barrier part into update_tail().
>
> No functional changes here.
>
> Signed-off-by: Jia He <jia.he@hxt-semitech.com>
> Suggested-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> Suggested-by: Ananyev Konstantin <konstantin.ananyev@intel.com>
> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
> ---
> diff --git a/lib/librte_ring/rte_ring_generic.h b/lib/librte_ring/rte_ring_generic.h
> new file mode 100644
> index 0000000..01f2cae
> --- /dev/null
> +++ b/lib/librte_ring/rte_ring_generic.h
> @@ -0,0 +1,202 @@
> +/*-
> + * Copyright(c) 2017 Intel Corporation. All rights reserved.
> + * All rights reserved.
> + *
> + * SPDX-License-Identifier: BSD-3-Clause
The SPDX should be first line. See other files for Intel or NXP.
> + */
> +
> +/*
> + * Derived from FreeBSD's bufring.h
> + *
> + **************************************************************************
> + *
> + * Copyright (c) 2007-2009 Kip Macy kmacy@freebsd.org
> + * All rights reserved.
> + *
> + * Redistribution and use in source and binary forms, with or without
> + * modification, are permitted provided that the following conditions are met:
> + *
> + * 1. Redistributions of source code must retain the above copyright notice,
> + * this list of conditions and the following disclaimer.
> + *
> + * 2. The name of Kip Macy nor the names of other
> + * contributors may be used to endorse or promote products derived from
> + * this software without specific prior written permission.
> + *
> + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
> + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
> + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
> + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE
> + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
> + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
> + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
> + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
> + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
> + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> + * POSSIBILITY OF SUCH DAMAGE.
> + *
> + ***************************************************************************/
> +
This is BSD-2-freebsd, which is not a approved license for DPDK.
Can you ask Kip Macy, if he/she is ok to re-license it with BSD-3?
Please check with legal, if you can just keep the copyright of Kip Macy
and re license it with BSD-3.
I see the BSD-3 license to be permissive enough to be re-licensed as
BSD-3. But I am not a lawyer.
next prev parent reply other threads:[~2018-01-19 15:25 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 4:03 [dpdk-dev] [PATCH v8 0/3] support c11 memory model barrier in librte_ring Jia He
2018-01-17 4:03 ` [dpdk-dev] [PATCH v8 1/3] eal/arm64: remove the braces {} for dmb() and dsb() Jia He
2018-01-17 4:03 ` [dpdk-dev] [PATCH v8 2/3] ring: introduce new header file to include common functions Jia He
2018-01-19 14:15 ` Hemant Agrawal [this message]
2018-01-19 16:38 ` Olivier Matz
2018-01-19 16:47 ` Hemant Agrawal
2018-01-22 1:53 ` Jia He
[not found] ` <60d7010d-caf8-8ade-a34c-7e284842cded@nxp.com>
2018-01-22 6:18 ` Jia He
2018-01-22 16:54 ` Stephen Hemminger
2018-01-17 4:03 ` [dpdk-dev] [PATCH v8 3/3] ring: introduce new header file to support C11 memory model Jia He
2018-01-17 8:24 ` Thomas Monjalon
2018-01-17 8:47 ` Jia He
2018-01-17 9:09 ` Thomas Monjalon
2018-01-18 23:52 ` Thomas Monjalon
2018-01-19 2:22 ` Jia He
2018-01-19 15:04 ` Hemant Agrawal
2018-01-19 14:25 ` Hemant Agrawal
2018-01-22 4:41 ` [dpdk-dev] [PATCH v9 0/3] support c11 memory model barrier in librte_ring Jia He
2018-01-22 4:41 ` [dpdk-dev] [PATCH v9 1/3] eal/arm64: remove the braces {} for dmb() and dsb() Jia He
2018-01-22 4:41 ` [dpdk-dev] [PATCH v9 2/3] ring: introduce new header file to include common functions Jia He
2018-01-22 4:41 ` [dpdk-dev] [PATCH v9 3/3] ring: introduce new header file to support C11 memory model Jia He
2018-01-22 7:53 ` [dpdk-dev] [PATCH v9 0/3] support c11 memory model barrier in librte_ring Thomas Monjalon
2018-01-22 8:26 ` Olivier Matz
2018-01-22 8:29 ` Olivier Matz
2018-01-22 8:40 ` Hemant Agrawal
2018-01-29 15:11 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a779a7be-50ee-7d58-52d6-865b802bfff6@nxp.com \
--to=hemant.agrawal@nxp.com \
--cc=dev@dpdk.org \
--cc=hejianet@gmail.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=jia.he@hxt-semitech.com \
--cc=jianbo.liu@arm.com \
--cc=konstantin.ananyev@intel.com \
--cc=olivier.matz@6wind.com \
--cc=thomas@monjalon.net \
--cc=viktorin@rehivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).