From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 471A8A034F;
	Mon, 19 Jul 2021 21:38:33 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id F15364069D;
	Mon, 19 Jul 2021 21:38:32 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 419A64068B;
 Mon, 19 Jul 2021 21:38:31 +0200 (CEST)
Received: from [192.168.100.116] (unknown [37.139.99.76])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 53F2F7F502;
 Mon, 19 Jul 2021 22:38:30 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 53F2F7F502
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1626723510;
 bh=CPVo/Y7fX68gyiDyx2IZReEuP02raiG8PLRUh1E5KwE=;
 h=Subject:From:To:Cc:References:Date:In-Reply-To;
 b=fpeFzlp6jbBkoa0a1NrYadMgian2n9WspAe4W44hZTC4B6It32BGJIpo8QTFxRB98
 iozb82ImC/FhKiWnvvAocFAnIR+duL9sGQhi4QBIKKksHN5jhbxgiEIWF3HqWgjjsD
 mBoYaqel03ALnlkj9zZd2yliFrcDDFE6+3/RLgX0=
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
 Chenbo Xia <chenbo.xia@intel.com>,
 Konstantin Ananyev <konstantin.ananyev@intel.com>,
 Andrew Rybchenko <arybchenko@solarflare.com>,
 Shahaf Shuler <shahafs@mellanox.com>
Cc: dev@dpdk.org, Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>, stable@dpdk.org
References: <20210706141407.2391177-1-andrew.rybchenko@oktetlabs.ru>
 <20210719191517.952999-1-andrew.rybchenko@oktetlabs.ru>
Message-ID: <a79503a1-0c8a-e294-029c-590b7f689433@oktetlabs.ru>
Date: Mon, 19 Jul 2021 22:38:28 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20210719191517.952999-1-andrew.rybchenko@oktetlabs.ru>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2] net/virtio: fix Rx scatter offload
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 7/19/21 10:15 PM, Andrew Rybchenko wrote:
> From: Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>
> 
> Report Rx scatter offload capability depending on VIRTIO_NET_F_MRG_RXBUF.
> 
> If Rx scatter is not requested, ensure that provided Rx buffers on
> each Rx queue are big enough to fit Rx packets up to configured MTU.
> 
> Fixes: ce17eddefc20 ("ethdev: introduce Rx queue offloads API")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Sorry, self NACK. The patch has problem with MTU set when not all
queues are setup. Will send v3 tomorrow.