From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 989EFA0544; Fri, 23 Sep 2022 13:41:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 40D6C40156; Fri, 23 Sep 2022 13:41:58 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 412F44003F for ; Fri, 23 Sep 2022 13:41:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663933315; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FzFW/xxWaEFZVKUI7rsmx1CKutujyoSEvi2OQwfAT/8=; b=NkrtkVP6VBe3Du2dtmdkrskGnWRMzIX6M++UPcqWqWKS8U+GpyvcNmBjSnO+pRIa/AoJ7n 9wS1F0wCJA/YhKvQGNGb4Dp1laqhAGkqoXikGTi+8Z+yOGHjh7ZtAIG1lWiuoLwaj1k8kb SHQUNh5G2kWh4v4r7MORgLypkr/BCX4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-596-Ru4PAFKHNEqBPuCvOmgvuw-1; Fri, 23 Sep 2022 07:41:54 -0400 X-MC-Unique: Ru4PAFKHNEqBPuCvOmgvuw-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2F52F85A583; Fri, 23 Sep 2022 11:41:54 +0000 (UTC) Received: from [10.39.208.26] (unknown [10.39.208.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2B9F749BB60; Fri, 23 Sep 2022 11:41:52 +0000 (UTC) Message-ID: Date: Fri, 23 Sep 2022 13:41:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 To: Nic Chautru , dev@dpdk.org, thomas@monjalon.net Cc: trix@redhat.com, mdr@ashroe.eu, bruce.richardson@intel.com, hemant.agrawal@nxp.com, david.marchand@redhat.com, stephen@networkplumber.org, hernan.vargas@intel.com References: <1663806460-45162-1-git-send-email-nicolas.chautru@intel.com> From: Maxime Coquelin Subject: Re: From: Nic Chautru In-Reply-To: <1663806460-45162-1-git-send-email-nicolas.chautru@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Nicolas, I'm done with v4 review. Please post a v6, I don't plan to review v5 that was posted while I was in the middle of my review. Thanks, Maxime On 9/22/22 02:27, Nic Chautru wrote: > v4: Rebase to split the first commit and change the order within > the series based on Maxime's feedback. No functional change. > v3: Merge ACC100 and ACC200 PMDs in the same directory > v2: Includes now code refactory to have common structures and code reused with the > parallel ACC1XX serie PMD which can be shared moving forward. > v1: This is targeting 22.11 and includes the PMD for the > new integrated accelerator on Intel Xeon SPR-EEC. > There is a dependency on that parallel patch serie still in-flight > which extends the bbdev api https://patches.dpdk.org/project/dpdk/list/?series=23894 > and is required to apply that patch. > > > Nic Chautru (14): > baseband/acc100: remove unused registers > baseband/acc100: refactor to segregate common code > baseband/acc: rename directory from acc100 to acc > baseband/acc: introduce PMD for ACC200 > baseband/acc: add HW register definitions for ACC200 > baseband/acc: add info get function for ACC200 > baseband/acc: add queue configuration for ACC200 > baseband/acc: add LDPC processing functions > baseband/acc: add LTE processing functions > baseband/acc: add support for FFT operations > baseband/acc: support interrupt > baseband/acc: add device status and vf2pf comms > baseband/acc: add PF configure companion function > baseband/acc: simplify meson dependency > > MAINTAINERS | 5 +- > app/test-bbdev/meson.build | 4 +- > app/test-bbdev/test_bbdev_perf.c | 81 +- > doc/guides/bbdevs/acc200.rst | 244 ++ > doc/guides/bbdevs/index.rst | 1 + > drivers/baseband/acc/acc100_pf_enum.h | 147 + > drivers/baseband/acc/acc100_pmd.h | 177 + > drivers/baseband/acc/acc100_vf_enum.h | 73 + > drivers/baseband/acc/acc101_pmd.h | 40 + > drivers/baseband/acc/acc200_pf_enum.h | 108 + > drivers/baseband/acc/acc200_pmd.h | 196 ++ > drivers/baseband/acc/acc200_vf_enum.h | 83 + > drivers/baseband/acc/acc_common.h | 1387 ++++++++ > drivers/baseband/acc/meson.build | 8 + > drivers/baseband/acc/rte_acc100_cfg.h | 49 + > drivers/baseband/acc/rte_acc100_pmd.c | 4655 +++++++++++++++++++++++++ > drivers/baseband/acc/rte_acc200_cfg.h | 48 + > drivers/baseband/acc/rte_acc200_pmd.c | 4195 +++++++++++++++++++++++ > drivers/baseband/acc/rte_acc_common_cfg.h | 101 + > drivers/baseband/acc/version.map | 10 + > drivers/baseband/acc100/acc100_pf_enum.h | 1086 ------ > drivers/baseband/acc100/acc100_pmd.h | 624 ---- > drivers/baseband/acc100/acc100_vf_enum.h | 73 - > drivers/baseband/acc100/acc101_pmd.h | 50 - > drivers/baseband/acc100/meson.build | 8 - > drivers/baseband/acc100/rte_acc100_cfg.h | 113 - > drivers/baseband/acc100/rte_acc100_pmd.c | 5288 ----------------------------- > drivers/baseband/acc100/version.map | 9 - > drivers/baseband/meson.build | 2 +- > 29 files changed, 11605 insertions(+), 7260 deletions(-) > create mode 100644 doc/guides/bbdevs/acc200.rst > create mode 100644 drivers/baseband/acc/acc100_pf_enum.h > create mode 100644 drivers/baseband/acc/acc100_pmd.h > create mode 100644 drivers/baseband/acc/acc100_vf_enum.h > create mode 100644 drivers/baseband/acc/acc101_pmd.h > create mode 100644 drivers/baseband/acc/acc200_pf_enum.h > create mode 100644 drivers/baseband/acc/acc200_pmd.h > create mode 100644 drivers/baseband/acc/acc200_vf_enum.h > create mode 100644 drivers/baseband/acc/acc_common.h > create mode 100644 drivers/baseband/acc/meson.build > create mode 100644 drivers/baseband/acc/rte_acc100_cfg.h > create mode 100644 drivers/baseband/acc/rte_acc100_pmd.c > create mode 100644 drivers/baseband/acc/rte_acc200_cfg.h > create mode 100644 drivers/baseband/acc/rte_acc200_pmd.c > create mode 100644 drivers/baseband/acc/rte_acc_common_cfg.h > create mode 100644 drivers/baseband/acc/version.map > delete mode 100644 drivers/baseband/acc100/acc100_pf_enum.h > delete mode 100644 drivers/baseband/acc100/acc100_pmd.h > delete mode 100644 drivers/baseband/acc100/acc100_vf_enum.h > delete mode 100644 drivers/baseband/acc100/acc101_pmd.h > delete mode 100644 drivers/baseband/acc100/meson.build > delete mode 100644 drivers/baseband/acc100/rte_acc100_cfg.h > delete mode 100644 drivers/baseband/acc100/rte_acc100_pmd.c > delete mode 100644 drivers/baseband/acc100/version.map >