From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8B1F0A04B1; Wed, 4 Nov 2020 20:35:23 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A9FD72BEA; Wed, 4 Nov 2020 20:35:13 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 9004FF90; Wed, 4 Nov 2020 20:35:10 +0100 (CET) IronPort-SDR: r68ii7HLnlZg7byNCU59RqZzB8qm3/8BMMhlm+FrCIiIx3PbDS8Vz86XzuyyGdZ5YR0zYs460t 9NpkzPnB+EGw== X-IronPort-AV: E=McAfee;i="6000,8403,9795"; a="187141912" X-IronPort-AV: E=Sophos;i="5.77,451,1596524400"; d="scan'208";a="187141912" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2020 11:35:08 -0800 IronPort-SDR: KCtA09rtWMzSNLPWoGDoNZbi1q8MFZkhhtuHfsKgKh1reM3YAdWSD8G14T81dlxYTn5RcrGkId yMqiiPn4Sujw== X-IronPort-AV: E=Sophos;i="5.77,451,1596524400"; d="scan'208";a="529049656" Received: from vmedvedk-mobl.ger.corp.intel.com (HELO [10.252.23.60]) ([10.252.23.60]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2020 11:35:06 -0800 To: Dharmik Thakkar , Bruce Richardson , Gavin Hu , Honnappa Nagarahalli , Ruifeng Wang Cc: dev@dpdk.org, nd@arm.com, stable@dpdk.org References: <20201103222352.11566-1-dharmik.thakkar@arm.com> <20201104185858.18397-1-dharmik.thakkar@arm.com> <20201104185858.18397-3-dharmik.thakkar@arm.com> From: "Medvedkin, Vladimir" Message-ID: Date: Wed, 4 Nov 2020 19:35:05 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201104185858.18397-3-dharmik.thakkar@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 2/4] test/lpm: return error on failure in rcu qsbr perf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 04/11/2020 18:58, Dharmik Thakkar wrote: > Return error if Add/Delete fail in multiwriter perf test > > Return error if single or multi writer test fails > > Fixes: eff30b59cc2e ("test/lpm: add RCU performance tests") > Cc: honnappa.nagarahalli@arm.com > Cc: stable@dpdk.org > > Signed-off-by: Dharmik Thakkar > Reviewed-by: Ruifeng Wang > Reviewed-by: Honnappa Nagarahalli > --- > app/test/test_lpm_perf.c | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/app/test/test_lpm_perf.c b/app/test/test_lpm_perf.c > index 45164b23214b..873ecf511c97 100644 > --- a/app/test/test_lpm_perf.c > +++ b/app/test/test_lpm_perf.c > @@ -453,6 +453,7 @@ test_lpm_rcu_qsbr_writer(void *arg) > next_hop_add) != 0) { > printf("Failed to add iteration %d, route# %d\n", > i, j); > + goto error; > } > pthread_mutex_unlock(&lpm_mutex); > } > @@ -464,6 +465,7 @@ test_lpm_rcu_qsbr_writer(void *arg) > large_ldepth_route_table[j].depth) != 0) { > printf("Failed to delete iteration %d, route# %d\n", > i, j); > + goto error; > } > pthread_mutex_unlock(&lpm_mutex); > } > @@ -474,6 +476,10 @@ test_lpm_rcu_qsbr_writer(void *arg) > __atomic_fetch_add(&gwrite_cycles, total_cycles, __ATOMIC_RELAXED); > > return 0; > + > +error: > + pthread_mutex_unlock(&lpm_mutex); > + return -1; > } > > /* > @@ -947,9 +953,11 @@ test_lpm_perf(void) > rte_lpm_delete_all(lpm); > rte_lpm_free(lpm); > > - test_lpm_rcu_perf(); > + if (test_lpm_rcu_perf() < 0) > + return -1; > > - test_lpm_rcu_perf_multi_writer(); > + if (test_lpm_rcu_perf_multi_writer() < 0) > + return -1; > > return 0; > } > Acked-by: Vladimir Medvedkin -- Regards, Vladimir